dex-startup-optimization results in java.lang.VerifyError: Rejecting class [284334258]

Verified

Bug

Status Update

No update yet.

Description

il...@gmail.com

created issue #1

May 26, 2023 11:56AM

Hello team! I'm trying to play around with startup profiles and dex-startup-optimization, but the final build results in the next exception. Any ideas on how can we debug and troubleshoot it?

FATAL EXCEPTION: main
Process: xxx, PID: 5246
java.lang.VerifyError: Rejecting class xxx.yyyApplication that attempts to sub-type erroneous class mQ (declaration of 'xxx.yyyApplication' appears in /data/app/~~yrjjUPjOxBs5lFDKXXNxhA==/xxx-06TuSPwE6KLgPDzMFRrjlA==/base.apk)
	at java.lang.Class.newInstance(Native Method)
	at android.app.AppComponentFactory.instantiateApplication(AppComponentFactory.java:76)
	at androidx.core.app.CoreComponentFactory.instantiateApplication(SourceFile:1)
	at android.app.Instrumentation.newApplication(Instrumentation.java:1243)
	at android.app.LoadedApk.makeApplicationInner(LoadedApk.java:1458)
	at android.app.LoadedApk.makeApplicationInner(LoadedApk.java:1395)
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6732)
	at android.app.ActivityThread.-$$Nest$mhandleBindApplication(Unknown Source:0)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2129)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7884)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
Caused by: java.lang.VerifyError: Verifier rejected class mQ: void mQ.<init>() failed to verify: void mQ.<init>(): [0x0] 'this' arg must be initialized
 void mQ.a() failed to verify: void mQ.a(): [0x0] Expected initialization on uninitialized reference Reference: mQ (declaration of 'mQ' appears in /data/app/~~yrjjUPjOxBs5lFDKXXNxhA==/xxx-06TuSPwE6KLgPDzMFRrjlA==/base.apk)
	... 16 more

Devices/Android versions reproduced on: Pixel 6 Pro

Env:

Android Studio Hedgehog | 2023.1.1 Canary 5
Build #AI-231.7864.76.2311.10195651, built on May 24, 2023
Runtime version: 17.0.6+0-b2043.56-10027231 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 11.0
GC: G1 Young Generation, G1 Old Generation
Memory: 4096M
Cores: 16

Deps:

com.android.tools.build:gradle:8.2.0-alpha05
com.android.test version 8.2.0-alpha05
org.jetbrains.kotlin.android version 1.9.0-Beta
androidx.baselineprofile version 1.2.0-alpha14
com.android.application version 8.2.0-alpha05
com.google.devtools.ksp version 1.9.0-Beta-1.0.11

experimentalProperties["android.experimental.art-profile-r8-rewriting"] = true
experimentalProperties["android.experimental.r8.dex-startup-optimization"] = true

Comments

ra...@google.com <ra...@google.com> #2May 26, 2023 07:41PM

This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.

ch...@google.com <ch...@google.com> #3May 30, 2023 06:41AM

Reassigned to ch...@google.com.

Almost 2 months later and this is still broken

il...@gmail.com <il...@gmail.com> #4May 30, 2023 01:19PM

Since there is no progression, I wanted to share our quick-fix for the issue.

#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages

ch...@google.com <ch...@google.com> #5May 31, 2023 06:54PM

jb...@google.com What is the update on this?

ap...@google.com <ap...@google.com> #6Jun 1, 2023 08:38AM

What is the status of this item?

ap...@google.com <ap...@google.com> #7Jun 1, 2023 08:38AM

This has been fixed on master today (internal ref: ag/2945015) and will be available in the next SDK release.

ch...@google.com <ch...@google.com> #8Jun 1, 2023 08:57AM

Verified by ch...@google.com.

Any ETA on next release?

il...@gmail.com <il...@gmail.com> #9Jun 1, 2023 09:46AM

Still broken and not updated? --package_file argument is not usable in it's current form on 26.1.1 straight from the developer site.

ap...@google.com <ap...@google.com> #10Jun 1, 2023 10:26AM

Comfirmed that this seems to still be broken. Can we have an update please?

```
(15:58:11) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --version
26.1.1

(15:58:17) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --install --package_file=package_file
Warning: Unknown argument --package_file=package_file
```

ap...@google.com <ap...@google.com> #11Jun 1, 2023 10:26AM

Hi, is there any update to this issue? Thanks.

ap...@google.com <ap...@google.com> #12Jun 1, 2023 10:26AM

Hi Google. You claim it's been fixed on master, but we haven't had a new release since the broken version 26.1.1. Can you please release the fix?

ra...@google.com <ra...@google.com> #13Jun 2, 2023 06:20PM

Yeah, still not fixed --'

il...@gmail.com <il...@gmail.com> #14Jun 5, 2023 07:22AM

Can't believe this still isn't fixed 2 years later for a command line utility that sits on the main dev site.

sg...@google.com <sg...@google.com> #15Jun 6, 2023 09:15AM

Any updates on this? The help for this command clearly states this argument is supported.

bi...@gmail.com <bi...@gmail.com> #16Nov 5, 2023 08:26AM

Has anyone re-tried it? We switched back to RUN sdkmanager --package_file=$ANDROID_HOME/packages.txt in our Dockerfile back in March of 2021.