Fixed
Status Update
Comments
le...@gmail.com <le...@gmail.com> #2
I am experiencing the same issue, when I insert a scrollable element in the bottom sheet. When the list is scrolled to the bottom, the sheet jumps up.
Can reproduce it using this sheet content:
Column(
Modifier.fillMaxSize()
.verticalScroll(rememberScrollState())
) {
Text(text = LoremIpsum(1250).values.joinToString { it })
}
jo...@gmail.com <jo...@gmail.com> #3
Same here at compose version "1.4.3"
ga...@gmail.com <ga...@gmail.com> #4
I'm facing the same issue. From what I found looks like this "feature" was added in the 1.4.0 version because I can't reproduce it below that version. Simplest code to reproduce
class MainActivity : ComponentActivity() {
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
setContent {
val scope = rememberCoroutineScope()
val sheetState = rememberModalBottomSheetState(ModalBottomSheetValue.Hidden)
ModalBottomSheetLayout(
sheetState = sheetState,
sheetContent = {
Text(
modifier = Modifier
.fillMaxWidth()
.height(200.dp),
text = "CONTENT"
)
}
) {
Button(onClick = { scope.launch { sheetState.show() } }) {
Text(text = "MODAL")
}
}
}
}
}
dm...@gmail.com <dm...@gmail.com> #5
Same problem with a scrollable list inside
aj...@physics.msu.ru <aj...@physics.msu.ru> #6
Same problem
se...@google.com <se...@google.com>
se...@google.com <se...@google.com>
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit 8de6e21cc59b30a03d203c1f3525ec4f6b8965be
Author: Jose Figueroa <serniebanders@google.com>
Date: Fri Feb 16 11:28:49 2024
[Material3][BottomSheet] Update SheetState default animation to a custom TweenSpec. Additionally remove deprecated constructor.
This updates the default spring animation provided by AnchorDraggable, which causes the observed overshoot.
Test: Manual.
Bug: 285847707
RelNote: "ModalBottomSheet and StandardBottomSheet animation spec is now a TweenSpec, updated from a spring animation. This resolves an issue with a visible overshoot. Deprecated SheetState constructors without density have now been removed."
Change-Id: I7babc194825f4cf6c05f9724eeba14d556c0840c
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/BottomSheetScaffold.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt
https://android-review.googlesource.com/2967503
Branch: androidx-main
commit 8de6e21cc59b30a03d203c1f3525ec4f6b8965be
Author: Jose Figueroa <serniebanders@google.com>
Date: Fri Feb 16 11:28:49 2024
[Material3][BottomSheet] Update SheetState default animation to a custom TweenSpec. Additionally remove deprecated constructor.
This updates the default spring animation provided by AnchorDraggable, which causes the observed overshoot.
Test: Manual.
Bug: 285847707
RelNote: "ModalBottomSheet and StandardBottomSheet animation spec is now a TweenSpec, updated from a spring animation. This resolves an issue with a visible overshoot. Deprecated SheetState constructors without density have now been removed."
Change-Id: I7babc194825f4cf6c05f9724eeba14d556c0840c
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/BottomSheetScaffold.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt
se...@google.com <se...@google.com>
na...@google.com <na...@google.com> #8
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.3.0-alpha02
androidx.compose.material3:material3-android:1.3.0-alpha02
androidx.compose.material3:material3-desktop:1.3.0-alpha02
pe...@gmail.com <pe...@gmail.com> #9
I can confirm the weird jump is gone in 1.3.0 alphas.
ki...@protonmail.com <ki...@protonmail.com> #10
Is this fixed for bottomSheet destinations too?
Description
Steps to Reproduce or Code Sample to Reproduce:
ModalBottomSheet
sample fromI have a minimum reproducible example here:https://github.com/tfcporciuncula/material3-bottomsheet/tree/fling (in the
fling
branch)