[M3] ModalBottomSheet jumps weirdly with when flinging up [285847707]

Fixed

Bug

Status Update

No update yet.

Description

tf...@gmail.com

created issue #1

Jun 5, 2023 02:45PM

Jetpack Compose version: 2023.05.01
Jetpack Compose component used: material3 (1.1.0)
Android Studio Build: #AI-222.4459.24.2221.9971841, built on April 19, 2023
Kotlin version: 1.8.21

Steps to Reproduce or Code Sample to Reproduce:

Run the ModalBottomSheet sample from here.
Make sure the bottom sheet isn't large enough to take the entire height of the screen when fully expanded.
Perform a fling going up starting from anywhere within the bottom sheet.
Observe the weird jumping behavior (I'm also attaching a video you can look at).

I have a minimum reproducible example here: https://github.com/tfcporciuncula/material3-bottomsheet/tree/fling (in the fling branch)

fling.mov

2.1 MB

Download

Comments

le...@gmail.com <le...@gmail.com> #2Jun 10, 2023 10:46PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

Message last modified on Jun 10, 2023 10:50PM

jo...@gmail.com <jo...@gmail.com> #3Jul 19, 2023 11:11AM

Same here at compose version "1.4.3"

ga...@gmail.com <ga...@gmail.com> #4Aug 18, 2023 11:58AM

I'm facing the same issue. From what I found looks like this "feature" was added in the 1.4.0 version because I can't reproduce it below that version. Simplest code to reproduce

class MainActivity : ComponentActivity() {
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContent {
            val scope = rememberCoroutineScope()
            val sheetState = rememberModalBottomSheetState(ModalBottomSheetValue.Hidden)
            ModalBottomSheetLayout(
                sheetState = sheetState,
                sheetContent = {
                    Text(
                        modifier = Modifier
                            .fillMaxWidth()
                            .height(200.dp),
                        text = "CONTENT"
                    )
                }
            ) {
                Button(onClick = { scope.launch { sheetState.show() } }) {
                    Text(text = "MODAL")
                }
            }
        }
    }
}

Message last modified on Aug 18, 2023 11:59AM

Screen Recording 2023-08-18 at 12.12.32.mov

460 KB

Download

dm...@gmail.com <dm...@gmail.com> #5Aug 29, 2023 01:15PM

Same problem with a scrollable list inside

aj...@physics.msu.ru <aj...@physics.msu.ru> #6Jan 31, 2024 04:35PM

Same problem

se...@google.com <se...@google.com> Feb 1, 2024 07:12PM

Reassigned to ma...@google.com.

se...@google.com <se...@google.com> Feb 16, 2024 03:34PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #7Feb 26, 2024 06:17PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8de6e21cc59b30a03d203c1f3525ec4f6b8965be
Author: Jose Figueroa <serniebanders@google.com>
Date: Fri Feb 16 11:28:49 2024

[Material3][BottomSheet] Update SheetState default animation to a custom TweenSpec. Additionally remove deprecated constructor.

This updates the default spring animation provided by AnchorDraggable, which causes the observed overshoot.

Test: Manual.
Bug: 285847707
RelNote: "ModalBottomSheet and StandardBottomSheet animation spec is now a TweenSpec, updated from a spring animation. This resolves an issue with a visible overshoot. Deprecated SheetState constructors without density have now been removed."
Change-Id: I7babc194825f4cf6c05f9724eeba14d556c0840c

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/BottomSheetScaffold.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt

https://android-review.googlesource.com/2967503

se...@google.com <se...@google.com> Feb 26, 2024 06:19PM

Marked as fixed.

na...@google.com <na...@google.com> #8Mar 6, 2024 07:49PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.3.0-alpha02
androidx.compose.material3:material3-android:1.3.0-alpha02
androidx.compose.material3:material3-desktop:1.3.0-alpha02

pe...@gmail.com <pe...@gmail.com> #9Apr 30, 2024 03:09PM

I can confirm the weird jump is gone in 1.3.0 alphas.

ki...@protonmail.com <ki...@protonmail.com> #10Nov 6, 2024 05:49PM

Is this fixed for bottomSheet destinations too?