[M3] ModalBottomSheet jumps weirdly with when flinging up [285847707]

Fixed

Bug

Status Update

No update yet.

Description

tf...@gmail.com

created issue #1

Jun 5, 2023 02:45PM

Jetpack Compose version: 2023.05.01
Jetpack Compose component used: material3 (1.1.0)
Android Studio Build: #AI-222.4459.24.2221.9971841, built on April 19, 2023
Kotlin version: 1.8.21

Steps to Reproduce or Code Sample to Reproduce:

Run the ModalBottomSheet sample from here.
Make sure the bottom sheet isn't large enough to take the entire height of the screen when fully expanded.
Perform a fling going up starting from anywhere within the bottom sheet.
Observe the weird jumping behavior (I'm also attaching a video you can look at).

I have a minimum reproducible example here: https://github.com/tfcporciuncula/material3-bottomsheet/tree/fling (in the fling branch)

fling.mov

2.1 MB

Download

Comments

le...@gmail.com <le...@gmail.com> #2Jun 10, 2023 10:46PM

Project: platform/frameworks/support
Branch: androidx-main

commit e40004b9e772b5e4e66a8dcdc3d2e2a1628108ad
Author: José Figueroa Santos <serniebanders@google.com>
Date: Tue Mar 21 14:39:09 2023

[M3][BottomSheetScaffold] Adds Hidden state boolean flag to sheet state.

This enables standardBottomSheet to implement a fully Hidden state should the user choose to.

Additionally adds documentation to SheetState.requireOffset(), and updates BottomSheetDefaults.MinimizedShape -> BottomSheetDefaults.HiddenShape

Bug: 274463511
Bug: 273870234
Test: Tests updated Hidden functionality for BottomSheetScaffold
Test: Preserves existing unit tests where Hidden state does not exist
RelNote: SheetState now has optional skipHiddenState parameter
RelNote: rememberStandardBottomSheetState now has optional skipHiddenState parameter
RelNote: BottomSheetScaffold now has a defined Hidden anchor, though it is disabled by default
RelNote: SheetState.requireOffset documentation has been updated
RelNote: BottomSheetDefaults.MinimizedShape has been renamed as BottomSheetDefaults.HiddenShape
Change-Id: I839f464c556eafb1b6fd823134da46943475919d

M compose/material3/material3/api/public_plus_experimental_1.1.0-beta01.txt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/BottomSheetScaffoldTest.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/Strings.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/BottomSheetScaffold.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ModalBottomSheet.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Strings.kt
M compose/material3/material3/src/desktopMain/kotlin/androidx/compose/material3/Strings.desktop.kt

https://android-review.googlesource.com/2500395

Message last modified on Jun 10, 2023 10:50PM

jo...@gmail.com <jo...@gmail.com> #3Jul 19, 2023 11:11AM

Resolved as of next release. Please note the default behavior for BottomSheetScaffold will still be to not allow Hidden value, but this can be overriden with a new flag for the State object. This is because StandardBottomSheet by design should generally coexist with the UI, in a Partially or fully expanded state.

ga...@gmail.com <ga...@gmail.com> #4Aug 18, 2023 11:58AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.1.0-beta02

Message last modified on Aug 18, 2023 11:59AM

Screen Recording 2023-08-18 at 12.12.32.mov

460 KB

Download

dm...@gmail.com <dm...@gmail.com> #5Aug 29, 2023 01:15PM

I'm facing this issue again in the new version of material3 1.2.0.alpha-05, It was working fine until alpha-04 but the moment I change it to 05 the app crashes and I get this error. I am also facing this issue if I change the foundation version from 1.6.0-alpha02 to 1.6.0-alpha03

aj...@physics.msu.ru <aj...@physics.msu.ru> #6Jan 31, 2024 04:35PM

Same here as described in #5 the issue seems back in 1.2.0-alpha05 and was working fine on 1.2.0-alpha04 and before. However, this time it doesn't seem to be working even with the defaults (which uses PartiallyExpanded as initialState internally). I've created a new bug ticket for this: b/296707223.

se...@google.com <se...@google.com> Feb 1, 2024 07:12PM

Reassigned to ma...@google.com.

se...@google.com <se...@google.com> Feb 16, 2024 03:34PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #7Feb 26, 2024 06:17PM

Crashing for me as well on `1.2.0-alpha06`

se...@google.com <se...@google.com> Feb 26, 2024 06:19PM

Marked as fixed.

na...@google.com <na...@google.com> #8Mar 6, 2024 07:49PM

Still present on 1.2.1. Can you reopen the issue please ?

pe...@gmail.com <pe...@gmail.com> #9Apr 30, 2024 03:09PM

deleted

ki...@protonmail.com <ki...@protonmail.com> #10Nov 6, 2024 05:49PM

Is this fixed for bottomSheet destinations too?