Fixed
Status Update
Comments
cc...@google.com <cc...@google.com> #2
Any suggestions on where such an interface might live? I don't think it makes sense for the interface to be in the drawerlayout artifact if you're specifically going to use the interface to *not* use DrawerLayout.
ja...@gmail.com <ja...@gmail.com> #3
androidx.customview would be a good candidate. This is used by all of the widget libraries.
ra...@google.com <ra...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 3ed3fb003fa6c1244f923202859a616225b5b2fa
Author: Ian Lake <ilake@google.com>
Date: Fri Feb 14 11:17:46 2020
Create an interface for layouts that can be opened
Create a common interface that represents layouts
that have two states: open and closed. This allows
higher level libraries to rely on the interface,
rather than concrete implementations such as
DrawerLayout, making them more resilient to
changes in the current recommended implementation.
Fixes: 129979320
Test: ./gradlew checkApi
Change-Id: I0f2a1414977825aa053c6555261f2b7d4417bd19
M customview/customview/api/1.1.0-alpha02.txt
M customview/customview/api/current.txt
M customview/customview/api/public_plus_experimental_1.1.0-alpha02.txt
M customview/customview/api/public_plus_experimental_current.txt
M customview/customview/api/restricted_1.1.0-alpha02.txt
M customview/customview/api/restricted_current.txt
A customview/customview/src/main/java/androidx/customview/widget/Openable.java
M drawerlayout/drawerlayout/api/1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/current.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_current.txt
M drawerlayout/drawerlayout/api/restricted_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/restricted_current.txt
M drawerlayout/drawerlayout/build.gradle
M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java
M jetifier/jetifier/migration.config
M slidingpanelayout/slidingpanelayout/api/1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/current.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_current.txt
M slidingpanelayout/slidingpanelayout/api/restricted_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/restricted_current.txt
M slidingpanelayout/slidingpanelayout/src/main/java/androidx/slidingpanelayout/widget/SlidingPaneLayout.java
https://android-review.googlesource.com/940787
Branch: androidx-master-dev
commit 3ed3fb003fa6c1244f923202859a616225b5b2fa
Author: Ian Lake <ilake@google.com>
Date: Fri Feb 14 11:17:46 2020
Create an interface for layouts that can be opened
Create a common interface that represents layouts
that have two states: open and closed. This allows
higher level libraries to rely on the interface,
rather than concrete implementations such as
DrawerLayout, making them more resilient to
changes in the current recommended implementation.
Fixes: 129979320
Test: ./gradlew checkApi
Change-Id: I0f2a1414977825aa053c6555261f2b7d4417bd19
M customview/customview/api/1.1.0-alpha02.txt
M customview/customview/api/current.txt
M customview/customview/api/public_plus_experimental_1.1.0-alpha02.txt
M customview/customview/api/public_plus_experimental_current.txt
M customview/customview/api/restricted_1.1.0-alpha02.txt
M customview/customview/api/restricted_current.txt
A customview/customview/src/main/java/androidx/customview/widget/Openable.java
M drawerlayout/drawerlayout/api/1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/current.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_current.txt
M drawerlayout/drawerlayout/api/restricted_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/restricted_current.txt
M drawerlayout/drawerlayout/build.gradle
M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java
M jetifier/jetifier/migration.config
M slidingpanelayout/slidingpanelayout/api/1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/current.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_current.txt
M slidingpanelayout/slidingpanelayout/api/restricted_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/restricted_current.txt
M slidingpanelayout/slidingpanelayout/src/main/java/androidx/slidingpanelayout/widget/SlidingPaneLayout.java
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit 23c069d4309c8798cdfccaa80478bd486508ca17
Author: Chris Craik <ccraik@google.com>
Date: Mon May 13 15:35:58 2024
Add BlackHole to enable controlling dead code elimination in Benchmark
Fixes: 286091643
Test: BlackHoleBenchmark
Relnote: "Added experimental `BlackHole.consume()` api to prevent dead
code elimination in microbenchmarks."
Change-Id: If681208c4e5ad5d054117c2320b4fd56b86f4ff5
A benchmark/benchmark-common/api/api_lint.ignore
M benchmark/benchmark-common/api/current.txt
M benchmark/benchmark-common/api/restricted_current.txt
M benchmark/benchmark-common/src/main/cpp/CMakeLists.txt
A benchmark/benchmark-common/src/main/cpp/androidx_benchmark_BlackHole.cpp
A benchmark/benchmark-common/src/main/java/androidx/benchmark/BlackHole.kt
A benchmark/benchmark-common/src/main/java/androidx/benchmark/ExperimentalBlackHoleApi.kt
M benchmark/benchmark-junit4/proguard-rules.pro
M benchmark/benchmark/build.gradle
A benchmark/benchmark/proguard-rules.pro
A benchmark/benchmark/src/androidTest/java/androidx/benchmark/benchmark/BlackHoleBenchmark.kt
https://android-review.googlesource.com/3084471
Branch: androidx-main
commit 23c069d4309c8798cdfccaa80478bd486508ca17
Author: Chris Craik <ccraik@google.com>
Date: Mon May 13 15:35:58 2024
Add BlackHole to enable controlling dead code elimination in Benchmark
Fixes: 286091643
Test: BlackHoleBenchmark
Relnote: "Added experimental `BlackHole.consume()` api to prevent dead
code elimination in microbenchmarks."
Change-Id: If681208c4e5ad5d054117c2320b4fd56b86f4ff5
A benchmark/benchmark-common/api/api_lint.ignore
M benchmark/benchmark-common/api/current.txt
M benchmark/benchmark-common/api/restricted_current.txt
M benchmark/benchmark-common/src/main/cpp/CMakeLists.txt
A benchmark/benchmark-common/src/main/cpp/androidx_benchmark_BlackHole.cpp
A benchmark/benchmark-common/src/main/java/androidx/benchmark/BlackHole.kt
A benchmark/benchmark-common/src/main/java/androidx/benchmark/ExperimentalBlackHoleApi.kt
M benchmark/benchmark-junit4/proguard-rules.pro
M benchmark/benchmark/build.gradle
A benchmark/benchmark/proguard-rules.pro
A benchmark/benchmark/src/androidTest/java/androidx/benchmark/benchmark/BlackHoleBenchmark.kt
pr...@google.com <pr...@google.com> #6
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-common:1.3.0-beta01
androidx.benchmark:benchmark-junit4:1.3.0-beta01
Description
We should confirm this, check api versions affected, and consider [switching to heapprofd](