Black image while using flash on Samsung a3 2017 [286190938]

Fixed

Bug

Status Update

No update yet.

Description

ma...@akylas.fr

created issue #1

Jun 7, 2023 12:38PM

While using GrapheneOS new Camera app which uses cameraX we discovered an issue with the Samsung a3 2017. If we take a photo using the flash in low light then we end up with a black image. The discussion started here https://github.com/GrapheneOS/Camera/issues/239 It appears that the flash and actual image capture are not in sync. I did test directly with a cameraX sample app using this:

        imageCapture = ImageCapture.Builder()
                .setCaptureMode(ImageCapture.CAPTURE_MODE_MAXIMIZE_QUALITY)
                .setFlashMode(ImageCapture.FLASH_MODE_ON)
                // We request aspect ratio but no resolution to match preview config, but letting
                // CameraX optimize for whatever specific resolution best fits our use cases
                .setTargetAspectRatio(screenAspectRatio)
                // Set initial target rotation, we will have to call this again if rotation changes
                // during the lifecycle of this use case
                .setTargetRotation(rotation)
                .build()

And i can reproduce the issue. The phone model is SM-a320FL but i would guess it also happens with sm-a320F

As the devs of the grapheneos app explained our device might need to be added to the list here https://android.googlesource.com/platform/frameworks/support/+/refs/heads/androidx-main/camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/FlashTooSlowQuirk.java

Hope there is enough info.

Thanks

PS: duplicate of that issue https://issuetracker.google.com/issues/235172945 from where we had no feedback. Thought it might have been posted in the wrong place

Comments

wu...@google.com <wu...@google.com> #2Jun 7, 2023 01:41PM

Reassigned to ma...@akylas.fr.

Thanks for reporting the issue. Which CameraX version are you using? Is it 100% reproducible?

ma...@akylas.fr <ma...@akylas.fr> #3Jun 7, 2023 02:57PM

Thanks for looking at this. Yes it is 100% reproducible. It has been reported by around 10 different phone users. Right now i just tested it and it is still happening with 1.3.0-alpha06. Havent tested with 1.3.0-alpha07 yet

ta...@google.com <ta...@google.com> Jun 8, 2023 06:26AM

Reassigned to ta...@google.com.

fr...@gmail.com <fr...@gmail.com> #4Jun 9, 2023 11:49AM

I've just tried the most recent GrapheneOS camera app (ie. updated to use 1.3.0-alpha07) and the issue still persists.

ta...@google.com <ta...@google.com> #5Jun 10, 2023 08:53PM

Accepted by ta...@google.com.

Hi Martin,

Thanks for reporting this issue. While we are working on the workaround, could you please help us out with testing the fix since we do not have an SM-A320 model available?

Attached to this comment, I have shared a CameraXBasic test APK compiled with the code you shared and SM-A320 models added to the quirk. If you could test it out on your device and confirm the fix, that would be great!

CameraXBasic-a320quirk-debug.apk

4.8 MB

Download

ma...@akylas.fr <ma...@akylas.fr> #6Jun 11, 2023 04:07PM

Thanks for that fast answer! I can confirm the fix is working. The flash is working fine now with the debug APK you shared! Amazing news for the a3 community. Thanks

ap...@google.com <ap...@google.com> #7Jun 12, 2023 03:31AM

Project: platform/frameworks/support
Branch: androidx-main

commit 3ded8ca486d04262a962e336b211d8629bbe7fcd
Author: Tahsin Masrur <tahsinm@google.com>
Date: Sun Jun 11 03:50:10 2023

Add SM-A320 models to FlashTooSlowQuirks

Reportedly, SM-A320FL model has a black image capture problem during low light due to flash and actual image capture not being in sync. It should be possible to work around this issue by using the torch as flash.

Relnote: "Use torch as flash on Samsung SM-A320 models to improve the speed and the captured image quality in low light"

Bug: 286190938
Test: FlashTooSlowQuirkTest
Change-Id: I6a022547c5a39c1783b9c1b8d9938a7d6494f482

M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/compat/quirk/FlashTooSlowQuirk.kt
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/FlashTooSlowQuirk.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/compat/quirk/FlashTooSlowQuirkTest.kt

https://android-review.googlesource.com/2621669

ta...@google.com <ta...@google.com> #8Jun 12, 2023 04:04AM

Marked as fixed.

Great! Thanks for your quick response. The fix should be available from next releases.

pr...@google.com <pr...@google.com> #9Jun 21, 2023 08:57PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.camera:camera-camera2:1.3.0-beta01