Fixed
Status Update
No update yet.
Comments
an...@northwesternmutual.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <
Link:
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
Expand for full commit details
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component.
Fixes: b/266550551
Fixes: b/204650733
Fixes: b/255554340
Fixes: b/229537244
Test: OverscrollTest
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere."
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61
Files:
- M
compose/foundation/foundation/api/current.txt - M
compose/foundation/foundation/api/restricted_current.txt - M
compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt - M
compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt - M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt - M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024
co...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.8.0-alpha06androidx.compose.foundation:foundation-android:1.8.0-alpha06androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06
an...@northwesternmutual.com
Yes, copying the code from the Sample into a standalone app causes the same behavior.
This is where I grabbed the Sample Code from:
https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/AppBarSamples.kt;l=301
Keep in mind this happens with the Device Font Size is turned all the way up, which is the issue I am facing and is a Accessibility concern for the team.
Below I have provided screenshots of the MediumTopAppBar in both the Expanded / Collapsed states and a image of the Device Font Size Setting.
This is where I grabbed the Sample Code from:
Keep in mind this happens with the Device Font Size is turned all the way up, which is the issue I am facing and is a Accessibility concern for the team.
Below I have provided screenshots of the MediumTopAppBar in both the Expanded / Collapsed states and a image of the Device Font Size Setting.
an...@northwesternmutual.com
Hello! It has been about a month since I last checked in. Just seeing where this is at and if a fix is being planned. Thanks!
se...@google.com
an...@northwesternmutual.com
Hello, is there any update on this issue yet?
sg...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 94c9c1be861c2cc6640411680244cde9c4e2372e
Author: Shalom Gibly <sgibly@google.com>
Date: Wed Mar 13 17:10:06 2024
Adds size customization to top app bars
- Added parameters to allow changing the fixed and expanded heights for
all types of top app bars.
- Deprecated (with Hidden) the previous experimental functions and
created new ones that take those params.
- Removed an older deprecated SmallTopAppBar functions
- Fix a performance issue where the single-line top app bars were
recomposing too much when scrolling content.
- Applied a heightIn with a max value to the app bar to better support
showing of DropDown menus from the app bar.
- Fix an accessibility issue with the Medium app bar that was cutting
some of the displayed title when using large font and display.
Fixes: 316594552
Fixes: 323403446
Fixes: 300953236
Fixes: 286296147
Fixes: 330410290
Bug: 308540676
Test: Added tests to AppBarTest.kt
Relnote: "Top app bar APIs now support custom heights for both fixed
and collapsible sections.
Fixed an issue that caused single-line top app bars to recompose too
many times when scrolling content.
Resolved an issue where MediumTopAppBar truncated titles on devices
with large font/display settings."
Change-Id: Ib8b0ce45ed461e7d5110e1473a90ab48c268caa6
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/AppBarTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/AppBar.kt
https://android-review.googlesource.com/3000717
Branch: androidx-main
commit 94c9c1be861c2cc6640411680244cde9c4e2372e
Author: Shalom Gibly <sgibly@google.com>
Date: Wed Mar 13 17:10:06 2024
Adds size customization to top app bars
- Added parameters to allow changing the fixed and expanded heights for
all types of top app bars.
- Deprecated (with Hidden) the previous experimental functions and
created new ones that take those params.
- Removed an older deprecated SmallTopAppBar functions
- Fix a performance issue where the single-line top app bars were
recomposing too much when scrolling content.
- Applied a heightIn with a max value to the app bar to better support
showing of DropDown menus from the app bar.
- Fix an accessibility issue with the Medium app bar that was cutting
some of the displayed title when using large font and display.
Fixes: 316594552
Fixes: 323403446
Fixes: 300953236
Fixes: 286296147
Fixes: 330410290
Bug: 308540676
Test: Added tests to AppBarTest.kt
Relnote: "Top app bar APIs now support custom heights for both fixed
and collapsible sections.
Fixed an issue that caused single-line top app bars to recompose too
many times when scrolling content.
Resolved an issue where MediumTopAppBar truncated titles on devices
with large font/display settings."
Change-Id: Ib8b0ce45ed461e7d5110e1473a90ab48c268caa6
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/AppBarTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/AppBar.kt
an...@northwesternmutual.com
Hello! I see this has been marked fixed since March, though I don't see a release version attached to it. Is there a planned release we can expect this fix?
Thanks!
Thanks!
Description
Jetpack Compose component used: MediumTopAppBar
Android Studio Build: #AI-221.6008.13.2211.9514443
Kotlin version: "1.8.20"
Steps to Reproduce or Code Sample to Reproduce:
When trying to create a Collapsing Toolbar with a Scaffold & MediumTopAppBar the Title Text is cut off. This happens when the largest text size is enabled on the device. This is what the code looks like:
```
Scaffold(
modifier = Modifier
.nestedScroll(scrollBehavior.nestedScrollConnection),
containerColor = Theme.colors.background,
contentColor = Theme.colors.surface,
topBar = {
MediumTopAppBar(
title = { Text(text = "Cash Flow", maxLines = 1) },
...
```
Also attached is what the it looks like in the view