dialog's lifecycle is wrong [286371387]

Fixed

Bug

Status Update

No update yet.

Description

zh...@gmail.com

created issue #1

Jun 9, 2023 02:24AM

Component used: Navigation Version used: Devices/Android versions reproduced on:

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue.
A screenrecord or screenshots showing the issue (if UI related).

When the user clicks the button twice in a row, the button event is a pop-up window, and then two pop-up windows will appear

The interesting thing is that when I close the pop-up window at the top of the stack, the two pop-up windows will be added to NavigatorState#_transitionsInProgress, and then the pop-up window at the top of the stack will be destroyed from compose and execute dialogNavigator#onTransitionComplete, but the second pop-up If the window does not execute dialogNavigator#onTransitionComplete, the second lifeCycle will always be in the START state, which will cause NavController data exception

I compared screen and DialogHost in the composable function of NavHost, and found that Screen will execute onTransitionComplete after the state changes, while Dialog does not

Comments

jb...@google.com <jb...@google.com> #2Jun 9, 2023 02:54PM

It could easy to reproduce when turning on "Don't keep activities".

zh...@gmail.com <zh...@gmail.com> #3Jun 11, 2023 11:03AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ba0c19707915ff87d9cac2089fcd166bb5cca17d
Author: Ian Lake <ilake@google.com>
Date: Wed Nov 14 16:20:28 2018

Set the correct FragmentManager on active Fragments

All active Fragments should have the correct
FragmentManager set instead of always using the
Activity's FragmentManager.

While added Fragments have their FragmentManager
set correctly in moveToState(), active Fragments
weren't being set correctly, causing issues when
attempting to save the state of the FragmentManager.

Test: new FragmentLifecycleTest
BUG: 119256498
Change-Id: I830f729d93f00859509a0844fae19752342e6ccc

M fragment/src/androidTest/java/androidx/fragment/app/FragmentLifecycleTest.java
M fragment/src/main/java/androidx/fragment/app/FragmentManagerImpl.java
M fragment/src/main/java/androidx/fragment/app/FragmentState.java

https://android-review.googlesource.com/826954

https://goto.google.com/android-sha1/ba0c19707915ff87d9cac2089fcd166bb5cca17d

zh...@gmail.com <zh...@gmail.com> #4Jun 11, 2023 11:18AM

Thanks Ian! Looking forward to a new alpha release ASAP rather than monthly release.😅

jb...@google.com <jb...@google.com> Jun 15, 2023 11:06PM

Assigned to cl...@google.com.

cl...@google.com <cl...@google.com> #5Jun 19, 2023 09:47PM

Thanks for fixing this!

zh...@gmail.com <zh...@gmail.com> #6Jun 20, 2023 02:09AM

Wondering is there any release plan?

Message last modified on Jun 20, 2023 06:03AM

cl...@google.com <cl...@google.com> #7Jun 20, 2023 05:32PM

Fragments 1.1.0-alpha02 is out now with this fix.

cl...@google.com <cl...@google.com> #8Aug 29, 2023 09:52PM

Marked as fixed.

Does Preferences also depend on Fragments? In which case when will that be updated to 1.1.0-alpha02? Or is the recommended practice to specify both Preferences and Fragments in build.gradle so that we can force Fragments 1.1.0-alpha02?

ap...@google.com <ap...@google.com> #9Aug 29, 2023 09:53PM

Re #8 - yes, if you need a specific version of Fragments, you should specify both Preferences and Fragments in your build.gradle.

The release schedule of AndroidX components is completely independent of one another, so Preferences will only get a new version when there's something new to release in Preferences.

pr...@google.com <pr...@google.com> #10Sep 6, 2023 07:55PM

So, in general it sounds like if an androidx dependency (such as preference) is added to build.gradle, then any dependencies of that (e.g. fragment) should also be explicitly added so that the specific version can be specified. Is that right?

In other words, when we explicitly include preference-1.1.0-alpha01 we need to be aware that the fragment-alpha1.1.0-alpha01 is automatically being brought in and so might affect the fragment behaviour. Sorry, I know this is rather OT.

na...@google.com <na...@google.com> #11Jan 24, 2024 07:53PM

Thanks, fix confirmed