dialog's lifecycle is wrong [286371387]

Fixed

Bug

Status Update

No update yet.

Description

zh...@gmail.com

created issue #1

Jun 9, 2023 02:24AM

Component used: Navigation Version used: Devices/Android versions reproduced on:

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue.
A screenrecord or screenshots showing the issue (if UI related).

When the user clicks the button twice in a row, the button event is a pop-up window, and then two pop-up windows will appear

The interesting thing is that when I close the pop-up window at the top of the stack, the two pop-up windows will be added to NavigatorState#_transitionsInProgress, and then the pop-up window at the top of the stack will be destroyed from compose and execute dialogNavigator#onTransitionComplete, but the second pop-up If the window does not execute dialogNavigator#onTransitionComplete, the second lifeCycle will always be in the START state, which will cause NavController data exception

I compared screen and DialogHost in the composable function of NavHost, and found that Screen will execute onTransitionComplete after the state changes, while Dialog does not

Comments

jb...@google.com <jb...@google.com> #2Jun 9, 2023 02:54PM

since these are in public API (:/) we need to do this in 1.2

zh...@gmail.com <zh...@gmail.com> #3Jun 11, 2023 11:03AM

since it is already marked as deprecated, we can probably do it by now.

zh...@gmail.com <zh...@gmail.com> #4Jun 11, 2023 11:18AM

Opening diff shortly

jb...@google.com <jb...@google.com> Jun 15, 2023 11:06PM

Assigned to cl...@google.com.

cl...@google.com <cl...@google.com> #5Jun 19, 2023 09:47PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

zh...@gmail.com <zh...@gmail.com> #6Jun 20, 2023 02:09AM

Thank you for your answer, I will open a separate post to ask a separate question;

separate question

Message last modified on Jun 20, 2023 06:03AM

cl...@google.com <cl...@google.com> #7Jun 20, 2023 05:32PM

Thanks for filing the new bug! I was thinking a separate bug for the issue you see in commment#4 with NavBackStackEntry possibly leaking. I'm gonna update the new bug's description to match that.

cl...@google.com <cl...@google.com> #8Aug 29, 2023 09:52PM

Marked as fixed.

Fixed internally and will be available in navigation 2.7.2.

ap...@google.com <ap...@google.com> #9Aug 29, 2023 09:53PM

Project: platform/frameworks/support
Branch: androidx-main

commit b624e50960eb6601efe2cd3f5d81b95a12ff56f2
Author: Clara Fok <clarafok@google.com>
Date: Thu Jun 22 14:11:43 2023

Fix Dialog not marked complete

When multiple dialogs are open at the same time and the top one is dismissed, the second dialog in backstack is marked as transitioning to hold it in STARTED state until the top dialog has completed transitioning. But the second dialog was never marked as complete so it stays in STARTED state instead of moving to expected RESUMED state.

Now we make sure to mark Dialogs as complete when Dialog has been commposed.

Test: ./gradlew navigation:navigation-compose:cC
Bug: 286371387
Change-Id: I48da82d4c0db3fecd40b4357b152e807078066c6

M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/DialogNavigatorTest.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/DialogNavigator.kt

https://android-review.googlesource.com/2629401

pr...@google.com <pr...@google.com> #10Sep 6, 2023 07:55PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-compose:2.7.2

na...@google.com <na...@google.com> #11Jan 24, 2024 07:53PM