dialog's lifecycle is wrong [286371387]

Fixed

Bug

Status Update

No update yet.

Description

zh...@gmail.com

created issue #1

Jun 9, 2023 02:24AM

Component used: Navigation Version used: Devices/Android versions reproduced on:

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue.
A screenrecord or screenshots showing the issue (if UI related).

When the user clicks the button twice in a row, the button event is a pop-up window, and then two pop-up windows will appear

The interesting thing is that when I close the pop-up window at the top of the stack, the two pop-up windows will be added to NavigatorState#_transitionsInProgress, and then the pop-up window at the top of the stack will be destroyed from compose and execute dialogNavigator#onTransitionComplete, but the second pop-up If the window does not execute dialogNavigator#onTransitionComplete, the second lifeCycle will always be in the START state, which will cause NavController data exception

I compared screen and DialogHost in the composable function of NavHost, and found that Screen will execute onTransitionComplete after the state changes, while Dialog does not

Comments

jb...@google.com <jb...@google.com> #2Jun 9, 2023 02:54PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

zh...@gmail.com <zh...@gmail.com> #3Jun 11, 2023 11:03AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

zh...@gmail.com <zh...@gmail.com> #4Jun 11, 2023 11:18AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

jb...@google.com <jb...@google.com> Jun 15, 2023 11:06PM

Assigned to cl...@google.com.

cl...@google.com <cl...@google.com> #5Jun 19, 2023 09:47PM

Hi, can you please file a separate bug for the issue you see in comment#4?

On initial bug - when multiple dialogs are open at the same time and the top one is dismissed, the second dialog in backstack is marked as transitioning to hold it in STARTED state until the top dialog has completed transitioning. But the second dialog was not marked as complete when composed so it stays in STARTED state instead of moving to expected RESUMED state.

zh...@gmail.com <zh...@gmail.com> #6Jun 20, 2023 02:09AM

Thank you for your answer, I will open a separate post to ask a separate question;

separate question

Message last modified on Jun 20, 2023 06:03AM

cl...@google.com <cl...@google.com> #7Jun 20, 2023 05:32PM

Thanks for filing the new bug! I was thinking a separate bug for the issue you see in commment#4 with NavBackStackEntry possibly leaking. I'm gonna update the new bug's description to match that.

cl...@google.com <cl...@google.com> #8Aug 29, 2023 09:52PM

Marked as fixed.

Fixed internally and will be available in navigation 2.7.2.

ap...@google.com <ap...@google.com> #9Aug 29, 2023 09:53PM

Project: platform/frameworks/support
Branch: androidx-main

commit b624e50960eb6601efe2cd3f5d81b95a12ff56f2
Author: Clara Fok <clarafok@google.com>
Date: Thu Jun 22 14:11:43 2023

Fix Dialog not marked complete

When multiple dialogs are open at the same time and the top one is dismissed, the second dialog in backstack is marked as transitioning to hold it in STARTED state until the top dialog has completed transitioning. But the second dialog was never marked as complete so it stays in STARTED state instead of moving to expected RESUMED state.

Now we make sure to mark Dialogs as complete when Dialog has been commposed.

Test: ./gradlew navigation:navigation-compose:cC
Bug: 286371387
Change-Id: I48da82d4c0db3fecd40b4357b152e807078066c6

M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/DialogNavigatorTest.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/DialogNavigator.kt

https://android-review.googlesource.com/2629401

pr...@google.com <pr...@google.com> #10Sep 6, 2023 07:55PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-compose:2.7.2

na...@google.com <na...@google.com> #11Jan 24, 2024 07:53PM