Status Update
No update yet.
Comments
ro...@gmail.com
I am not sure I understand the use case. how can the benchmark be code to real world scenario when it's not possible to do right now ? which scenario is it ?
In any case, since this would be for benchmarking, this would clearly not be available through the public DSL. We should find a semi-private way of doing this (maybe the private variant API object could offer that functionality for instance or a property).
su...@google.com
We want benchmarks to measure code after Progaurd / R8, but it's not possible to turn that on for androidTests in library modules at the moment (to my knowledge?)
Benchmarks are also a public facing thing, but we have a plugin to help configure gradle builds for our users, so if support for this ends up in a private API, we could try to keep those usages localized to our code perhaps.
ro...@gmail.com
Any update on the status of this request and when it can be supported?
Thanks,
Amanda
us...@gmail.com
this is not part of our OKR at this point so we are not talking soon. at first glance, we would need to simulate usage patterns to minify against and such, this seems substantial amount of work. there are not a lot of library module that have android tests, most only rely on unit-tests.
how important is this ? we are out of PM right now but I suspect the next step will be to negotiate with J. Eason and xav@ to scale a priority level.
Description
AppSearch version used: 1.1.0-alpha03
Devices/Android versions reproduced on: Pixel 2 API 30
When you encountered this bug:
- Which steps did you take prior to the bug? Starting the app and initializing AppSearchSession
- What behavior did you expect? App initializes AppSearchSession
- What was the actual behavior? App crashes with Thread dump
2023-06-09 13:36:42.716 12797-12853 u.osu.osumobil edu.osu.osumobile A runtime.cc:663] JNI DETECTED ERROR IN APPLICATION: fid == null
runtime.cc:663] in call to GetLongField
runtime.cc:663] from byte[] com.google.android.icing.IcingSearchEngineImpl.nativeInitialize(com.google.android.icing.IcingSearchEngineImpl)
2023-06-09 13:36:42.716 12797-12853 libc edu.osu.osumobile A Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 12853 (pool-14-thread-), pid 12797 (u.osu.osumobile)
App crashes with isMinifyEnabled = true with following android SDK levels
androidSdkCompile = "34"
androidSdkTarget = "34"
androidSdkMin = "26"
androidBuildTools = "34.0.0"
Running this on a device with API level 30 (which uses local-storage instead of platform-storage) in release with minified turned on causes the error.
I was able to fix this bug by adding this to my Proguard (not an expert by any means) but I would like to know the official R8 rules for this library because this seems less than ideal
# AppSearch
-keep class com.google.android.icing.* { *; }