Collect Wakelock and Wakeup events in Macrobenchmark [286551983]

Assigned

Feature Request

Status Update

No update yet.

Description

ys...@google.com

created issue #1

Jun 9, 2023 05:00PM

Component used: Macrobenchmark Version used: 1.2.0-alpha15 Devices/Android versions reproduced on: PixelWatch

CPU Trace from Android Studio has Wakelock events, but I don't see them when collecting from Macrobenchmark.

Is there something for me to enable? Or it's missing in macrobenchmark?

select s.dur / 1e6 as dur_ms, s.name, t.name          
FROM slice s
LEFT JOIN track t
  ON s.track_id = t.id
WHERE s.name GLOB '*WakeLock *' AND s.dur != -1
order by s.dur desc;

dur_ms	name
21408.68027	WakeLock (ExoPlayer:WakeLockManager)
1157.484269	WakeLock (com.android.server.stats.StatsCompanionService.PullingAlarmListener)
566.475731	WakeLock (NetworkStats)

For wakeups, (maybe this is the same thing) I think the data is

https://cs.android.com/android/platform/superproject/+/master:external/perfetto/protos/perfetto/trace/ftrace/ftrace_event.proto;l=519?q=wakeup_source_activate

Comments

cc...@google.com <cc...@google.com> #2Jun 12, 2023 05:51PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

sh...@google.com <sh...@google.com> #3Jun 12, 2023 05:57PM

Is this an atrace cateogry? Studio's config for Perfetto is defined here. Currently it is the following. It's pretty easy to update.

  private val standardAtraceCategories = listOf("gfx", "input", "view", "wm", "am", "sm", "camera", "hal", "res", "pm", "ss", "power",
                                                "database", "dalvik", "audio",
                                                "binder_driver", "binder_lock")

cc...@google.com <cc...@google.com> #4Jun 12, 2023 06:03PM

Here are ours: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoConfig.kt;l=142;drc=b5ad2a8e91a12682778b5f15182d42bb4ae62437

From Studio's list, we're missing several: sm, pm, ss, power, database and binder_lock.

Lalit, two questions:

what configures wakelocks + should we always capture it?
and what of the other tags should we be always turning on?

And yes, long term we should look into ways to let apps tweak the config, but simple adding may only work for simple atrace categories.

la...@google.com <la...@google.com> #5Jun 14, 2023 10:23AM

what configures wakelocks + should we always capture it?

Wakelocks AFAIK are start of the power category. It's almost always worth capturing yes.

and what of the other tags should we be always turning on?

Realistically, this strongly depends on what you are looking to capture. go/perfetto-aot-config has the config we roll out on field devices and I guess is the authoritative list of every category the perf team/our team consider useful.

cc...@google.com <cc...@google.com> #6Oct 19, 2023 07:43PM

Reassigned to ma...@google.com.

Over to Marcello to add wakelocks for now, and review go/perfetto-aot-config to see if we're missing anything else important.

ap...@google.com <ap...@google.com> #7Mar 20, 2024 09:06PM

Project: platform/frameworks/support
Branch: androidx-main

commit 584eeeaa782856850d67496ac76be19451dc1077
Author: Chris Craik <ccraik@google.com>
Date: Mon Mar 18 14:33:20 2024

Add power tag to benchmark perfetto config

Bug: 286551983
Test: SmallListStartupBenchmark # just verified tag was present in output trace capture
Test: adb shell atrace --list_categories # run on API 21, power was present
Relnote: "Added power tag to benchmark Perfetto Config. This captures,
for example, wakelock tracepoints."

Change-Id: Icfe44e708991bb03eff2c8df527a6fe9f872fb88

M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/AtraceTag.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoConfig.kt

https://android-review.googlesource.com/3006960

Issue 286551983