Collect Wakelock and Wakeup events in Macrobenchmark [286551983]

Assigned

Feature Request

Status Update

No update yet.

Description

ys...@google.com

created issue #1

Jun 9, 2023 05:00PM

Component used: Macrobenchmark Version used: 1.2.0-alpha15 Devices/Android versions reproduced on: PixelWatch

CPU Trace from Android Studio has Wakelock events, but I don't see them when collecting from Macrobenchmark.

Is there something for me to enable? Or it's missing in macrobenchmark?

select s.dur / 1e6 as dur_ms, s.name, t.name          
FROM slice s
LEFT JOIN track t
  ON s.track_id = t.id
WHERE s.name GLOB '*WakeLock *' AND s.dur != -1
order by s.dur desc;

dur_ms	name
21408.68027	WakeLock (ExoPlayer:WakeLockManager)
1157.484269	WakeLock (com.android.server.stats.StatsCompanionService.PullingAlarmListener)
566.475731	WakeLock (NetworkStats)

For wakeups, (maybe this is the same thing) I think the data is

https://cs.android.com/android/platform/superproject/+/master:external/perfetto/protos/perfetto/trace/ftrace/ftrace_event.proto;l=519?q=wakeup_source_activate

Comments

cc...@google.com <cc...@google.com> #2Jun 12, 2023 05:51PM

Any suggestions on where such an interface might live? I don't think it makes sense for the interface to be in the drawerlayout artifact if you're specifically going to use the interface to *not* use DrawerLayout.

sh...@google.com <sh...@google.com> #3Jun 12, 2023 05:57PM

androidx.customview would be a good candidate. This is used by all of the widget libraries.

cc...@google.com <cc...@google.com> #4Jun 12, 2023 06:03PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3ed3fb003fa6c1244f923202859a616225b5b2fa
Author: Ian Lake <ilake@google.com>
Date: Fri Feb 14 11:17:46 2020

Create an interface for layouts that can be opened

Create a common interface that represents layouts
that have two states: open and closed. This allows
higher level libraries to rely on the interface,
rather than concrete implementations such as
DrawerLayout, making them more resilient to
changes in the current recommended implementation.

Fixes: 129979320
Test: ./gradlew checkApi
Change-Id: I0f2a1414977825aa053c6555261f2b7d4417bd19

M customview/customview/api/1.1.0-alpha02.txt
M customview/customview/api/current.txt
M customview/customview/api/public_plus_experimental_1.1.0-alpha02.txt
M customview/customview/api/public_plus_experimental_current.txt
M customview/customview/api/restricted_1.1.0-alpha02.txt
M customview/customview/api/restricted_current.txt
A customview/customview/src/main/java/androidx/customview/widget/Openable.java
M drawerlayout/drawerlayout/api/1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/current.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_current.txt
M drawerlayout/drawerlayout/api/restricted_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/restricted_current.txt
M drawerlayout/drawerlayout/build.gradle
M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java
M jetifier/jetifier/migration.config
M slidingpanelayout/slidingpanelayout/api/1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/current.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_current.txt
M slidingpanelayout/slidingpanelayout/api/restricted_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/restricted_current.txt
M slidingpanelayout/slidingpanelayout/src/main/java/androidx/slidingpanelayout/widget/SlidingPaneLayout.java

https://android-review.googlesource.com/940787

la...@google.com <la...@google.com> #5Jun 14, 2023 10:23AM

what configures wakelocks + should we always capture it?

Wakelocks AFAIK are start of the power category. It's almost always worth capturing yes.

and what of the other tags should we be always turning on?

Realistically, this strongly depends on what you are looking to capture. go/perfetto-aot-config has the config we roll out on field devices and I guess is the authoritative list of every category the perf team/our team consider useful.

cc...@google.com <cc...@google.com> #6Oct 19, 2023 07:43PM

Reassigned to ma...@google.com.

Over to Marcello to add wakelocks for now, and review go/perfetto-aot-config to see if we're missing anything else important.

ap...@google.com <ap...@google.com> #7Mar 20, 2024 09:06PM

Project: platform/frameworks/support
Branch: androidx-main

commit 584eeeaa782856850d67496ac76be19451dc1077
Author: Chris Craik <ccraik@google.com>
Date: Mon Mar 18 14:33:20 2024

Add power tag to benchmark perfetto config

Bug: 286551983
Test: SmallListStartupBenchmark # just verified tag was present in output trace capture
Test: adb shell atrace --list_categories # run on API 21, power was present
Relnote: "Added power tag to benchmark Perfetto Config. This captures,
for example, wakelock tracepoints."

Change-Id: Icfe44e708991bb03eff2c8df527a6fe9f872fb88

M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/AtraceTag.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoConfig.kt

https://android-review.googlesource.com/3006960

Issue 286551983