Collect Wakelock and Wakeup events in Macrobenchmark [286551983]

Assigned

Feature Request

Status Update

No update yet.

Description

ys...@google.com

created issue #1

Jun 9, 2023 05:00PM

Component used: Macrobenchmark Version used: 1.2.0-alpha15 Devices/Android versions reproduced on: PixelWatch

CPU Trace from Android Studio has Wakelock events, but I don't see them when collecting from Macrobenchmark.

Is there something for me to enable? Or it's missing in macrobenchmark?

select s.dur / 1e6 as dur_ms, s.name, t.name          
FROM slice s
LEFT JOIN track t
  ON s.track_id = t.id
WHERE s.name GLOB '*WakeLock *' AND s.dur != -1
order by s.dur desc;

dur_ms	name
21408.68027	WakeLock (ExoPlayer:WakeLockManager)
1157.484269	WakeLock (com.android.server.stats.StatsCompanionService.PullingAlarmListener)
566.475731	WakeLock (NetworkStats)

For wakeups, (maybe this is the same thing) I think the data is

https://cs.android.com/android/platform/superproject/+/master:external/perfetto/protos/perfetto/trace/ftrace/ftrace_event.proto;l=519?q=wakeup_source_activate

Comments

cc...@google.com <cc...@google.com> #2Jun 12, 2023 05:51PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

sh...@google.com <sh...@google.com> #3Jun 12, 2023 05:57PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

cc...@google.com <cc...@google.com> #4Jun 12, 2023 06:03PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

la...@google.com <la...@google.com> #5Jun 14, 2023 10:23AM

what configures wakelocks + should we always capture it?

Wakelocks AFAIK are start of the power category. It's almost always worth capturing yes.

and what of the other tags should we be always turning on?

Realistically, this strongly depends on what you are looking to capture. go/perfetto-aot-config has the config we roll out on field devices and I guess is the authoritative list of every category the perf team/our team consider useful.

cc...@google.com <cc...@google.com> #6Oct 19, 2023 07:43PM

Reassigned to ma...@google.com.

Over to Marcello to add wakelocks for now, and review go/perfetto-aot-config to see if we're missing anything else important.

ap...@google.com <ap...@google.com> #7Mar 20, 2024 09:06PM

Project: platform/frameworks/support
Branch: androidx-main

commit 584eeeaa782856850d67496ac76be19451dc1077
Author: Chris Craik <ccraik@google.com>
Date: Mon Mar 18 14:33:20 2024

Add power tag to benchmark perfetto config

Bug: 286551983
Test: SmallListStartupBenchmark # just verified tag was present in output trace capture
Test: adb shell atrace --list_categories # run on API 21, power was present
Relnote: "Added power tag to benchmark Perfetto Config. This captures,
for example, wakelock tracepoints."

Change-Id: Icfe44e708991bb03eff2c8df527a6fe9f872fb88

M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/AtraceTag.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoConfig.kt

https://android-review.googlesource.com/3006960

Issue 286551983