CameraController should start using ResolutionSelector instead of OutputSize [286801438]

Verified

Feature Request

Status Update

No update yet.

Description

ba...@gmail.com

created issue #1

Jun 12, 2023 02:25PM

CAMERAX VERSION: 1.3.0-alpha07

CAMERA APPLICATION NAME AND VERSION: Aperture (https://github.com/LineageOS/android_packages_apps_Aperture), version 13

ANDROID OS BUILD NUMBER: TQ2A.230505.002

DEVICE NAME: Google Pixel 7 Pro

DESCRIPTION: CameraController is still using OutputSize, which is a class only used by CameraController. Now that ResolutionSelector exists, it should be migrated to that (with the advantage of also adding setAllowedResolutionMode control). A patch has been sent to AOSP Gerrit to implement this change: https://android-review.googlesource.com/c/platform/frameworks/support/+/2621689

LIST ANY EXPERIMENTAL FEATURES:

@androidx.camera.camera2.interop.ExperimentalCamera2Interop
@androidx.camera.core.ExperimentalLensFacing
@androidx.camera.core.ExperimentalZeroShutterLag
@androidx.camera.view.video.ExperimentalVideo

STEPS TO REPRODUCE: Not applicable

OBSERVED RESULTS: Not applicable

EXPECTED RESULTS: Not applicable

REPRODUCIBILITY: Not applicable

ADDITIONAL INFORMATION: N/A

CODE FRAGMENTS (this will help us troubleshoot your issues): https://android-review.googlesource.com/c/platform/frameworks/support/+/2621689

Comments

fu...@google.com <fu...@google.com> #2Jun 12, 2023 08:36PM

Reassigned to xi...@google.com.

+Xi to take a look

xi...@google.com <xi...@google.com> Sep 11, 2023 08:25PM

Accepted by xi...@google.com.

[Deleted User] <[Deleted User]> #3Sep 12, 2023 04:02AM

On Tue, 12 Sep 2023 2:25 AM , <buganizer-system@google.com> wrote:

- Show quoted text -

ap...@google.com <ap...@google.com> #4Sep 20, 2023 04:19PM

Project: platform/frameworks/support
Branch: androidx-main

commit b18f334975a45c3c684a30d64c10a09b41dc4d16
Author: Xi Zhang <xizh@google.com>
Date: Wed Aug 16 10:23:14 2023

[CameraController 1.4]: Set resolution with ResolutionSelector

We are deprecating the OutputSize in CameraController and replace it with ResolutionSelector

Relnote: Deprecate OutputSize and replace it with ResolutionSelector. ResolutionSelector is a more comprehensive way to select resolutions, and it's consistent with the camera-core API.
Bug: 286801438
Test: manual test and ./gradlew bOS
Change-Id: I93abdb2472d82de5af890fccdd253d629f9111e7

M camera/camera-view/api/current.txt
M camera/camera-view/api/restricted_current.txt
M camera/camera-view/src/main/java/androidx/camera/view/CameraController.java
M camera/camera-view/src/test/java/androidx/camera/view/CameraControllerTest.kt

https://android-review.googlesource.com/2712158

xi...@google.com <xi...@google.com> Sep 20, 2023 06:29PM

Verified by xi...@google.com.

pr...@google.com <pr...@google.com> #5Oct 18, 2023 08:41PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.camera:camera-view:1.4.0-alpha02

Issue 286801438