Porting SYSTEM_OVERLAYS to WindowInsetsCompat [287470173]

Fixed

Feature Request

Status Update

No update yet.

Description

ga...@google.com

created issue #1

Jun 15, 2023 04:29PM

SYSTEM_OVERLAYS insets type was recently made public in WindowInsets as part of UDC. The code can be seen here

It is also available as non-public GENERIC_OVERLAYS in android S (only in automotive branches - sc-car-dev) and android T (only in automotive branches - tm-car-dev). But it uses the same int value.

The request is to make it available via androidx (WindowInsetsCompat) as well. Had a brief discussion with @alanv. This can be done and it should be a no-op for S and T on non-automotive devices.

Comments

al...@google.com <al...@google.com> Jun 15, 2023 04:36PM

Reassigned to ga...@google.com.

ga...@google.com <ga...@google.com> #2Jul 11, 2023 06:12PM

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

ga...@google.com <ga...@google.com> Aug 21, 2023 04:37PM

Reassigned to ja...@google.com.

xi...@google.com <xi...@google.com> #3Mar 19, 2024 08:32PM

Thanks for the report!

xi...@google.com <xi...@google.com> #4Jun 18, 2024 11:16PM

Reassigned to ga...@google.com.

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

ga...@google.com <ga...@google.com> #5Jun 18, 2024 11:19PM

Reassigned to ja...@google.com.

deleted

bs...@google.com <bs...@google.com> #6Nov 5, 2024 03:19PM

In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).

Message last modified on Nov 5, 2024 07:32PM

ap...@google.com <ap...@google.com> #7Nov 26, 2024 10:06PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Rachit Jain <jainrachit@google.com>
Link: https://android-review.googlesource.com/3355679

Add SYSTEM_OVERLAYS to WindowInsetsCompat

Expand for full commit details

Add SYSTEM_OVERLAYS to WindowInsetsCompat 
 
Relnote: Added API for SYSTEM_OVERLAYS 
Bug: 287470173 
Test: WindowInsetsCompatTest 
Change-Id: Ibd1fd4a28dae7ccdc3193f1afcfac7b097265d71

Files:

M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/androidTest/java/androidx/core/view/WindowInsetsCompatTest.kt
M core/core/src/main/java/androidx/core/view/WindowInsetsCompat.java

Hash: 8f88d3c0efcbe5f4cbfbff78e1797b4f3568905a
Date: Thu Nov 14 14:39:16 2024

ja...@google.com <ja...@google.com> #8Nov 26, 2024 10:09PM

Marked as fixed.

Compose part (more or less ready) CL is out and is being tracked in another bug (b/347270464). Further development is pending version upgrade of jetpack core.

pr...@google.com <pr...@google.com> #9Dec 11, 2024 06:27PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.core:core:1.16.0-alpha01

ja...@google.com <ja...@google.com> #10Dec 28, 2024 04:16AM

Hi prajakt@google.com, does this mean that the core jetpack been upgraded and I can test out the compose part?