Dialog composable not removed from visibleBackStack after dismiss [287969970]

Fixed

Bug

Status Update

No update yet.

Description

zh...@gmail.com

created issue #1

Jun 20, 2023 02:18AM

Component used: Navigation

Version used: 2.7.0-beta01

Devices/Android versions reproduced on: any

Operating procedure:

When the tester frequently clicks the button, the button event is to display a Dialog, Dialog is set to be destroyed by external click, so Dialog is always displayed and destroyed

Interesting thing, because it may be too fast, causing DialogHost to not notice that Dialog appears and disappears, but it has actually joined NavController#_visibleEntries

But because NavHost#DialogHost did not process DisposableEffect, it will not execute dialogNavigator#onTransitionComplete, so it will not be removed from NavController#_visibleEntries, and a NavBackStackEntry leak occurs

The reason may be that the pop-up window appears and disappears within one frame.

Comments

jb...@google.com <jb...@google.com> Jun 20, 2023 02:07PM

Assigned to cl...@google.com.

cl...@google.com <cl...@google.com> #2Jun 20, 2023 05:35PM

since these are in public API (:/) we need to do this in 1.2

ap...@google.com <ap...@google.com> #3Oct 12, 2023 11:14PM

since it is already marked as deprecated, we can probably do it by now.

cl...@google.com <cl...@google.com> #4Oct 12, 2023 11:15PM

Marked as fixed.

Opening diff shortly

na...@google.com <na...@google.com> #5Nov 1, 2023 05:20PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

na...@google.com <na...@google.com> #6Jan 24, 2024 07:53PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-compose:2.8.0-alpha01

Issue 287969970