[Partner Bug]Missing R8/Proguard rules [288120539]

Fixed

Bug

Status Update

No update yet.

Description

dm...@ownid.com

created issue #1

Jun 21, 2023 05:27AM

Component used: Credentials

Version used: androidx.credentials:credentials-play-services-auth:1.0.0-alpha09

Looks like there is no R8/Proguard rules embedded in the lib.

There was a commit specifically for that:

https://android-review.googlesource.com/c/platform/frameworks/support/+/2456851
but I cannot find a `proguard.txt` file in `credentials-play-services-auth-1.0.0-alpha09.aar`

I know that there is an instruction to add rules manually

https://developer.android.com/training/sign-in/passkeys#proguard
but why we have to do this manually?

Comments

bl...@google.com <bl...@google.com> #2Jun 21, 2023 05:33AM

Reassigned to re...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

re...@google.com <re...@google.com> Jun 21, 2023 06:44PM

Reassigned to sg...@google.com.

ar...@google.com <ar...@google.com> #3Jun 21, 2023 07:51PM

Accepted by ar...@google.com.

Hi, thanks for sharing.

Did you check these proguard rules : https://developer.android.com/training/sign-in/passkeys#proguard

Isn't something missing?

dm...@ownid.com <dm...@ownid.com> #4Jun 22, 2023 04:00AM

Hi. I know proguard rules that in docs https://developer.android.com/training/sign-in/passkeys#proguard And I put them manually. They are ok.

But my ticket is about embedding these proguard rules into lib itself.

As I wrote, there was a commit specifically for that: https://android-review.googlesource.com/c/platform/frameworks/support/+/2456851 but I cannot find a proguard.txt file in credentials-play-services-auth-1.0.0-alpha09.aar

ar...@google.com <ar...@google.com> #5Jun 22, 2023 01:36PM

Sure, let me check and update you on this, thanks for sharing.

ar...@google.com <ar...@google.com> #6Jul 13, 2023 06:56AM

Hey, the rules are already added to the library. It might be h due to some configuration on your gradle file

Can you check if this is the root cause? https://stackoverflow.com/questions/38503434/gradle-are-proguard-configurations-inherited

dm...@ownid.com <dm...@ownid.com> #7Jul 13, 2023 07:12AM

Hi. I checked my gradle file for proguard config. It's correct.

Next. I cannot confirm that rules are already added to the library.

You can check it yourself: In file in https://dl.google.com/dl/android/maven2/androidx/credentials/credentials-play-services-auth/1.0.0-alpha08/credentials-play-services-auth-1.0.0-alpha08.aar there is no proguard.txt file, but it has to be there.

ar...@google.com <ar...@google.com> #8Jul 13, 2023 08:11AM

i believe this was added in alpha09, you shared alpha08 with me. Am i missing something?

dm...@ownid.com <dm...@ownid.com> #9Jul 13, 2023 08:14AM

Well, it's true that alpha09 is the latest one.

But you can check yourself that there is no proguard file in it too:

https://dl.google.com/dl/android/maven2/androidx/credentials/credentials-play-services-auth/1.0.0-alpha09/credentials-play-services-auth-1.0.0-alpha09.aar

ar...@google.com <ar...@google.com> #10Jul 14, 2023 09:08AM

Yeah, thanks for reporting. We are checking this issue on our end. There seems to be some discrepancy.

ar...@google.com <ar...@google.com> Aug 22, 2023 07:58AM

Assigned to sg...@google.com.

sg...@google.com <sg...@google.com> Aug 25, 2023 04:37AM

Accepted by sg...@google.com.

sg...@google.com <sg...@google.com> #11Aug 25, 2023 08:56PM

We're working on a fix for this problem, it will be available in our next version release in a few weeks.

ap...@google.com <ap...@google.com> #12Aug 25, 2023 08:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0087efbd0a8ce75be8619e8718d217a1c771cf16
Author: Guangjie Shi <sgjerry@google.com>
Date: Fri Aug 25 18:27:54 2023

include proguard in the gradle

Test: local build
Bug: 288120539
Change-Id: I1b5a4cc823aeae3dbadcc9d949b02fc5d7ca86dc

M credentials/credentials-play-services-auth/build.gradle

https://android-review.googlesource.com/2726919

sg...@google.com <sg...@google.com> #13Sep 13, 2023 04:42PM

Marked as fixed.

The fix will be out in our release next week.

na...@google.com <na...@google.com> #14Sep 20, 2023 07:16PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.credentials:credentials-play-services-auth:1.2.0-beta04