Status Update
Comments
bl...@google.com <bl...@google.com> #2
re...@google.com <re...@google.com>
ar...@google.com <ar...@google.com> #3
dm...@ownid.com <dm...@ownid.com> #4
Hi.
I know proguard rules that in docs
But my ticket is about embedding these proguard rules into lib itself.
As I wrote, there was a commit specifically for that:
proguard.txt
file in credentials-play-services-auth-1.0.0-alpha09.aar
ar...@google.com <ar...@google.com> #5
Sure, let me check and update you on this, thanks for sharing.
ar...@google.com <ar...@google.com> #6
Hey, the rules are already added to the library. It might be h due to some configuration on your gradle file
Can you check if this is the root cause?
dm...@ownid.com <dm...@ownid.com> #7
Hi. I checked my gradle file for proguard config. It's correct.
Next. I cannot confirm that rules are already added to the library.
You can check it yourself:
In file in https://dl.google.com/dl/android/maven2/androidx/credentials/credentials-play-services-auth/1.0.0-alpha08/credentials-play-services-auth-1.0.0-alpha08.aar
there is no proguard.txt
file, but it has to be there.
ar...@google.com <ar...@google.com> #8
i believe this was added in alpha09, you shared alpha08 with me. Am i missing something?
dm...@ownid.com <dm...@ownid.com> #9
ar...@google.com <ar...@google.com> #10
Yeah, thanks for reporting. We are checking this issue on our end. There seems to be some discrepancy.
ar...@google.com <ar...@google.com>
sg...@google.com <sg...@google.com>
sg...@google.com <sg...@google.com> #11
We're working on a fix for this problem, it will be available in our next version release in a few weeks.
ap...@google.com <ap...@google.com> #12
Branch: androidx-main
commit 0087efbd0a8ce75be8619e8718d217a1c771cf16
Author: Guangjie Shi <sgjerry@google.com>
Date: Fri Aug 25 18:27:54 2023
include proguard in the gradle
Test: local build
Bug: 288120539
Change-Id: I1b5a4cc823aeae3dbadcc9d949b02fc5d7ca86dc
M credentials/credentials-play-services-auth/build.gradle
sg...@google.com <sg...@google.com> #13
The fix will be out in our release next week.
na...@google.com <na...@google.com> #14
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.credentials:credentials-play-services-auth:1.2.0-beta04
Description
Version used: androidx.credentials:credentials-play-services-auth:1.0.0-alpha09
Looks like there is no R8/Proguard rules embedded in the lib.
There was a commit specifically for that:
but I cannot find a `proguard.txt` file in `credentials-play-services-auth-1.0.0-alpha09.aar`
I know that there is an instruction to add rules manually
but why we have to do this manually?