Status Update
Comments
bl...@google.com <bl...@google.com> #2
The internal systemBarsForVisualComponents
right now only uses systemBars
, which doesn't include the display cutout:
Updating to systemBars.union(displayCutout)
should fix this, if that's a change we can make.
re...@google.com <re...@google.com>
ar...@google.com <ar...@google.com> #3
Thank you for looking into this! It would be crucial to get this right soon as the edge2edge project depends on handling this properly :)
dm...@ownid.com <dm...@ownid.com> #4
Not taking the display cutout into account will impact cars heavily, since some have very large display cutouts:
ar...@google.com <ar...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
Author: Alex Vanyo <
Link:
Add displayCutout to default Material insets
Expand for full commit details
Add displayCutout to default Material insets
Relnote: "Adds displayCutout to the group of insets that Material
components take into account by default, to avoid content overlapping
with the display cutout.
This is a behavior change that will impact how inset-aware
components behave around a display cutout. This includes the default
value of the WindowInsets parameter for inset-aware Material 3
components, and the WindowInsets values provided in the component
Defaults objects for both Material 2 and Material 3.
If this change causes undesirable behavior,
manually specify the WindowInsets parameter on a per-component basis."
Fixes: 362508045
Change-Id: I43ee9ad12db0450ebb9c65ce10d5c39d12628b6c
Files:
- M
compose/material/material/src/androidMain/kotlin/androidx/compose/material/SystemBarsDefaultInsets.android.kt
- M
compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/MaterialComponentsInsetSupportTest.kt
- M
compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/internal/SystemBarsDefaultInsets.android.kt
Hash: 692b440ac97b1831d5b35aafff241a98aeeacb93
Date: Wed Dec 18 19:49:15 2024
ar...@google.com <ar...@google.com> #6
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material:material:1.8.0-alpha08
androidx.compose.material:material-android:1.8.0-alpha08
androidx.compose.material:material-jvmstubs:1.8.0-alpha08
androidx.compose.material:material-linuxx64stubs:1.8.0-alpha08
androidx.compose.material3:material3:1.4.0-alpha06
androidx.compose.material3:material3-android:1.4.0-alpha06
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha06
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha06
dm...@ownid.com <dm...@ownid.com> #7
Hi. I checked my gradle file for proguard config. It's correct.
Next. I cannot confirm that rules are already added to the library.
You can check it yourself:
In file in https://dl.google.com/dl/android/maven2/androidx/credentials/credentials-play-services-auth/1.0.0-alpha08/credentials-play-services-auth-1.0.0-alpha08.aar
there is no proguard.txt
file, but it has to be there.
ar...@google.com <ar...@google.com> #8
i believe this was added in alpha09, you shared alpha08 with me. Am i missing something?
dm...@ownid.com <dm...@ownid.com> #9
ar...@google.com <ar...@google.com> #10
Yeah, thanks for reporting. We are checking this issue on our end. There seems to be some discrepancy.
ar...@google.com <ar...@google.com>
sg...@google.com <sg...@google.com>
sg...@google.com <sg...@google.com> #11
We're working on a fix for this problem, it will be available in our next version release in a few weeks.
ap...@google.com <ap...@google.com> #12
Branch: androidx-main
commit 0087efbd0a8ce75be8619e8718d217a1c771cf16
Author: Guangjie Shi <sgjerry@google.com>
Date: Fri Aug 25 18:27:54 2023
include proguard in the gradle
Test: local build
Bug: 288120539
Change-Id: I1b5a4cc823aeae3dbadcc9d949b02fc5d7ca86dc
M credentials/credentials-play-services-auth/build.gradle
sg...@google.com <sg...@google.com> #13
The fix will be out in our release next week.
na...@google.com <na...@google.com> #14
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.credentials:credentials-play-services-auth:1.2.0-beta04
Description
Version used: androidx.credentials:credentials-play-services-auth:1.0.0-alpha09
Looks like there is no R8/Proguard rules embedded in the lib.
There was a commit specifically for that:
but I cannot find a `proguard.txt` file in `credentials-play-services-auth-1.0.0-alpha09.aar`
I know that there is an instruction to add rules manually
but why we have to do this manually?