Add a "draggable: Boolean" argument to material3 ModalBottomSheet [288211587]

Fixed

Feature Request

Status Update

No update yet.

Description

lo...@gmail.com

created issue #1

Jun 21, 2023 11:05AM

Jetpack Compose version: 1.2.0-alpha02

Jetpack Compose component used: androidx.compose.material3:material3

Similar to https://issuetracker.google.com/issues/186669832 (Material 2 ModalBottomSheet) I need to have an option to disable the drag gesture in certain cases for the Material 3 version of ModalBottomSheet.

Currently, there is only the confirmValueChange parameter in rememberModalBottomSheetState but that is only called for the 3 SheetValues, no for any draggable state.

I noticed that the enabled state for draggable in Modifier.modalBottomSheetSwipeable is inly dependent on the visibility of the sheet. Maybe SheetState could get another parameter dragEnabled which could then also be checked.

Comments

se...@google.com <se...@google.com> Aug 29, 2023 02:20PM

Reassigned to ma...@google.com.

ca...@thetrainline.com <ca...@thetrainline.com> #2Oct 19, 2023 12:19PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ko...@gmail.com <ko...@gmail.com> #3Jan 5, 2024 03:48PM

Any update about this?

kl...@naver.com <kl...@naver.com> #4Mar 4, 2024 12:44AM

Any update?

ni...@gmail.com <ni...@gmail.com> #5Mar 7, 2024 06:30PM

Blocked my migration to compose. Bottom sheetDialogFragment already has this.

mu...@gmail.com <mu...@gmail.com> #6Mar 18, 2024 06:39AM

Any update on the issue?

j6...@gmail.com <j6...@gmail.com> #7Apr 29, 2024 08:36PM

An update would be appreciated. As of now, one workaround I'm using is

confirmValueChange = { it != SheetValue.Hidden }

Message last modified on Apr 30, 2024 02:15AM

se...@google.com <se...@google.com> Apr 30, 2024 08:37PM

Reassigned to se...@google.com.

at...@gmail.com <at...@gmail.com> #8Aug 4, 2024 11:31AM

Any update on the issue?

va...@gmail.com <va...@gmail.com> #9Aug 21, 2024 01:01PM

Same question

r....@kaizengaming.com <r....@kaizengaming.com> #10Aug 26, 2024 08:38AM

Any update on this one?

sv...@gmail.com <sv...@gmail.com> #11Sep 3, 2024 12:24PM

Any update on this please?

aj...@gmail.com <aj...@gmail.com> #12Sep 10, 2024 07:34PM

It's really impressive how a small feature like this is still not in progress.

r....@kaizengaming.com <r....@kaizengaming.com> #13Sep 27, 2024 08:14AM

This issue has remained unresolved for an extended period. A status update regarding the progress and any potential roadblocks encountered would be appreciated.

se...@google.com <se...@google.com> Sep 30, 2024 05:47PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #14Oct 2, 2024 08:59PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jose Figueroa <serniebanders@google.com>
Link: https://android-review.googlesource.com/3287876

[Material3][ModalBottomSheet] Add sheetGestureEnabled parameter to allow manual disabling of gestures

Expand for full commit details

[Material3][ModalBottomSheet] Add sheetGestureEnabled parameter to allow manual disabling of gestures

RelNote: "ModalBottomSheet now has sheetGestureEnabled parameter"
Bug: 288211587
Test: Added unit test for nested scrolling behavior
Change-Id: I856cbb6b8907ce773d47589f2c83a828a5740eb8

Files:

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ModalBottomSheet.kt

Hash: 18bebb5575db25ab0ff3b5e439401ea40e7bad0e
Date: Mon Sep 30 14:31:26 2024

se...@google.com <se...@google.com> Oct 2, 2024 09:04PM

Marked as fixed.

aj...@gmail.com <aj...@gmail.com> #15Oct 3, 2024 12:17AM

Can we have the fix version please?

se...@gmail.com <se...@gmail.com> #16Oct 15, 2024 10:39PM

Was this fix also added to Material ModalBottomSheet?

na...@google.com <na...@google.com> #17Oct 16, 2024 05:48PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.4.0-alpha02
androidx.compose.material3:material3-android:1.4.0-alpha02
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha02
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha02

ch...@gmail.com <ch...@gmail.com> #18Dec 9, 2024 05:55AM

Comment has been deleted.

Message last modified on Dec 9, 2024 05:56AM

se...@google.com <se...@google.com> #19Dec 12, 2024 05:40PM

We do not have a timeline for a Material implementation. Please create a separate issue for that component if it does not exist.

ma...@extrabat.com <ma...@extrabat.com> #20Jan 13, 2025 01:39PM

Hi, any delay to have it on a stable release ?