Add a "draggable: Boolean" argument to material3 ModalBottomSheet [288211587]

Fixed

Feature Request

Status Update

No update yet.

Description

lo...@gmail.com

created issue #1

Jun 21, 2023 11:05AM

Jetpack Compose version: 1.2.0-alpha02

Jetpack Compose component used: androidx.compose.material3:material3

Similar to https://issuetracker.google.com/issues/186669832 (Material 2 ModalBottomSheet) I need to have an option to disable the drag gesture in certain cases for the Material 3 version of ModalBottomSheet.

Currently, there is only the confirmValueChange parameter in rememberModalBottomSheetState but that is only called for the 3 SheetValues, no for any draggable state.

I noticed that the enabled state for draggable in Modifier.modalBottomSheetSwipeable is inly dependent on the visibility of the sheet. Maybe SheetState could get another parameter dragEnabled which could then also be checked.

Comments

se...@google.com <se...@google.com> Aug 29, 2023 02:20PM

Reassigned to ma...@google.com.

ca...@thetrainline.com <ca...@thetrainline.com> #2Oct 19, 2023 12:19PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

ko...@gmail.com <ko...@gmail.com> #3Jan 5, 2024 03:48PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

kl...@naver.com <kl...@naver.com> #4Mar 4, 2024 12:44AM

Any update?

ni...@gmail.com <ni...@gmail.com> #5Mar 7, 2024 06:30PM

Blocked my migration to compose. Bottom sheetDialogFragment already has this.

mu...@gmail.com <mu...@gmail.com> #6Mar 18, 2024 06:39AM

Any update on the issue?

j6...@gmail.com <j6...@gmail.com> #7Apr 29, 2024 08:36PM

An update would be appreciated. As of now, one workaround I'm using is

confirmValueChange = { it != SheetValue.Hidden }

Message last modified on Apr 30, 2024 02:15AM

se...@google.com <se...@google.com> Apr 30, 2024 08:37PM

Reassigned to se...@google.com.

at...@gmail.com <at...@gmail.com> #8Aug 4, 2024 11:31AM

Any update on the issue?

va...@gmail.com <va...@gmail.com> #9Aug 21, 2024 01:01PM

Same question

r....@kaizengaming.com <r....@kaizengaming.com> #10Aug 26, 2024 08:38AM

Any update on this one?

sv...@gmail.com <sv...@gmail.com> #11Sep 3, 2024 12:24PM

Any update on this please?

aj...@gmail.com <aj...@gmail.com> #12Sep 10, 2024 07:34PM

It's really impressive how a small feature like this is still not in progress.

r....@kaizengaming.com <r....@kaizengaming.com> #13Sep 27, 2024 08:14AM

This issue has remained unresolved for an extended period. A status update regarding the progress and any potential roadblocks encountered would be appreciated.

se...@google.com <se...@google.com> Sep 30, 2024 05:47PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #14Oct 2, 2024 08:59PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jose Figueroa <serniebanders@google.com>
Link: https://android-review.googlesource.com/3287876

[Material3][ModalBottomSheet] Add sheetGestureEnabled parameter to allow manual disabling of gestures

Expand for full commit details

[Material3][ModalBottomSheet] Add sheetGestureEnabled parameter to allow manual disabling of gestures

RelNote: "ModalBottomSheet now has sheetGestureEnabled parameter"
Bug: 288211587
Test: Added unit test for nested scrolling behavior
Change-Id: I856cbb6b8907ce773d47589f2c83a828a5740eb8

Files:

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ModalBottomSheet.kt

Hash: 18bebb5575db25ab0ff3b5e439401ea40e7bad0e
Date: Mon Sep 30 14:31:26 2024

se...@google.com <se...@google.com> Oct 2, 2024 09:04PM

Marked as fixed.

aj...@gmail.com <aj...@gmail.com> #15Oct 3, 2024 12:17AM

Can we have the fix version please?

se...@gmail.com <se...@gmail.com> #16Oct 15, 2024 10:39PM

Was this fix also added to Material ModalBottomSheet?

na...@google.com <na...@google.com> #17Oct 16, 2024 05:48PM