Optimize Stroke allocations in Wear Material [288234617]

Fixed

Bug

Status Update

No update yet.

Description

an...@google.com

created issue #1

Jun 21, 2023 11:44AM

Based on the decision from

https://docs.google.com/document/d/12PGihnWzAeGD9x9t4400sFyHVa2xnivcMQUREO1ZWdE/edit#heading=h.svl3tbt7wmyh
please use Modifier.drawWithCache() in
Wear ProgressIndicator
Wear PositionIndicator
Wear ToggleControl
In order to not allocate a Stroke on every draw

Comments

st...@google.com <st...@google.com> Jun 30, 2023 09:38AM

Assigned to ha...@google.com.

ha...@google.com <ha...@google.com> #2Jul 11, 2023 09:34AM

Accepted by ha...@google.com.

Good catch!

Possibly relevant https://issuetracker.google.com/issues/214231672 - "sometimes a developer wants to disable touch input for an entire part of the UI, even if it includes children that actively try to handle touch events."

ha...@google.com <ha...@google.com> Jul 25, 2023 12:53PM

Marked as fixed.

ap...@google.com <ap...@google.com> #3Jul 25, 2023 12:54PM

Curious, is it intended that TimeText could have an interact-able composable? Like a Network symbol in leadingCurvedContent that shows network information when clicked?

na...@google.com <na...@google.com> #4Aug 10, 2023 03:47PM

CurvedText (used inside TimeText) had a semantic annotation so talkback could read the text to the user.
In the last patch (going out as alpha19) we removed that, since CurvedText is not a compose-ui node anymore, but we will look into adding it back again (with better bounds).

Issue 288234617