Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
ap...@google.com <ap...@google.com> #3
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit a69200acae2cea60ce0b473134445d050be580cb
Author: Clara Fok <clarafok@google.com>
Date: Fri Jun 30 12:04:07 2023
Migrate all Paging3 classes to commonMain
Test: ./gradlew paging:paging-common:jvmTest
Bug: 288623117
Change-Id: I2a37c3c7c9002d0a43b9f9c254f8584e3cc27dba
M paging/paging-common/src/commonMain/kotlin/androidx/paging/CachedPageEventFlow.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/CachedPagingData.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/ExperimentalPagingApi.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/FlowExt.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/HintHandler.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/HintReceiver.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/InvalidateCallbackTracker.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/InvalidatingPagingSourceFactory.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/Logger.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/MutableCombinedLoadStateCollection.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageEvent.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageFetcher.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageFetcherSnapshot.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageFetcherSnapshotState.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagePresenter.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/Pager.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingConfig.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingData.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataDiffer.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataTransforms.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingSource.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingSourceFactory.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingState.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/RemoteMediator.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/RemoteMediatorAccessor.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/Separators.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/SingleRunner.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/SuspendingPagingSourceFactory.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/TransformablePage.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/ViewportHint.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/CachedPageEventFlowLeakTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/CachedPageEventFlowTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/CachingTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/FailDispatcher.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/FlattenedPageEventStorageTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/FlowExtTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/GarbageCollectionTestHelper.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/HeaderFooterTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/HintHandlerTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/InvalidatingPagingSourceFactoryTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageEventTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageFetcherSnapshotStateTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageFetcherSnapshotTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageFetcherTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagePresenterTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagingConfigTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagingDataDifferTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagingSourceTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagingStateTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/ProcessPageEventCallbackCapture.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/RemoteMediatorAccessorTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/SeparatorsTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/SeparatorsWithRemoteMediatorTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/SimpleChannelFlowTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/SimpleTransformLatestTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/SingleRunnerTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/StateChange.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/TestPagingSourceExt.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/TestUtils.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PagedList.kt
https://android-review.googlesource.com/2647601
Branch: androidx-main
commit a69200acae2cea60ce0b473134445d050be580cb
Author: Clara Fok <clarafok@google.com>
Date: Fri Jun 30 12:04:07 2023
Migrate all Paging3 classes to commonMain
Test: ./gradlew paging:paging-common:jvmTest
Bug: 288623117
Change-Id: I2a37c3c7c9002d0a43b9f9c254f8584e3cc27dba
M paging/paging-common/src/commonMain/kotlin/androidx/paging/CachedPageEventFlow.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/CachedPagingData.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/ExperimentalPagingApi.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/FlowExt.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/HintHandler.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/HintReceiver.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/InvalidateCallbackTracker.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/InvalidatingPagingSourceFactory.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/Logger.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/MutableCombinedLoadStateCollection.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageEvent.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageFetcher.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageFetcherSnapshot.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageFetcherSnapshotState.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagePresenter.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/Pager.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingConfig.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingData.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataDiffer.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataTransforms.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingSource.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingSourceFactory.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingState.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/RemoteMediator.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/RemoteMediatorAccessor.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/Separators.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/SingleRunner.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/SuspendingPagingSourceFactory.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/TransformablePage.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/ViewportHint.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/CachedPageEventFlowLeakTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/CachedPageEventFlowTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/CachingTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/FailDispatcher.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/FlattenedPageEventStorageTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/FlowExtTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/GarbageCollectionTestHelper.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/HeaderFooterTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/HintHandlerTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/InvalidatingPagingSourceFactoryTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageEventTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageFetcherSnapshotStateTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageFetcherSnapshotTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageFetcherTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagePresenterTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagingConfigTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagingDataDifferTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagingSourceTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagingStateTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/ProcessPageEventCallbackCapture.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/RemoteMediatorAccessorTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/SeparatorsTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/SeparatorsWithRemoteMediatorTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/SimpleChannelFlowTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/SimpleTransformLatestTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/SingleRunnerTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/StateChange.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/TestPagingSourceExt.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/TestUtils.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PagedList.kt
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit b536469eba96d3045cf26ee40bf87a4b1d579dbe
Author: Clara Fok <clarafok@google.com>
Date: Fri Jun 30 11:57:20 2023
Remove @JvmDefaultWithCompatibility from Logger.kt
Annotation was added in b/251463569 to maintain binary compatibility.
But Logger is only used internally and we want to move this file to commonMain hence removing it.
Test: ./gradlew buildOnServer
Bug: 288623117
Relnote: "Remove @JvmDefaultWithCompatibility annotation"
Change-Id: I9b67c2e081a15e18797b68f5ce2224858e358a1d
M paging/paging-common/api/current.txt
M paging/paging-common/api/restricted_current.txt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/Logger.kt
https://android-review.googlesource.com/2647600
Branch: androidx-main
commit b536469eba96d3045cf26ee40bf87a4b1d579dbe
Author: Clara Fok <clarafok@google.com>
Date: Fri Jun 30 11:57:20 2023
Remove @JvmDefaultWithCompatibility from Logger.kt
Annotation was added in
But Logger is only used internally and we want to move this file to commonMain hence removing it.
Test: ./gradlew buildOnServer
Bug: 288623117
Relnote: "Remove @JvmDefaultWithCompatibility annotation"
Change-Id: I9b67c2e081a15e18797b68f5ce2224858e358a1d
M paging/paging-common/api/current.txt
M paging/paging-common/api/restricted_current.txt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/Logger.kt
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit 19c9fbd2252535dcb858faf39c1629a9771f9675
Author: Clara Fok <clarafok@google.com>
Date: Fri Jun 30 10:59:11 2023
Add CompatLegacyPagingSource in commonMain
LegacyPagingSource relies on PageFetcher to set the pageSize on new instance creation because LegacyPagingSource does not have access to PagingConfig. By adding CompatLegacyPagingSource interface, PageFetcher in commonMain can reference LegacyPagingSource in jvmMain.
Test: ./gradlew paging:paging-common:jvmTest
Bug: 288623117
Change-Id: I0ef1e7f0426b237d47beffbb4f1197d1e8d21ee5
A paging/paging-common/src/commonMain/kotlin/androidx/paging/CompatLegacyPagingSource.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/LegacyPagingSource.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PageFetcher.kt
https://android-review.googlesource.com/2647599
Branch: androidx-main
commit 19c9fbd2252535dcb858faf39c1629a9771f9675
Author: Clara Fok <clarafok@google.com>
Date: Fri Jun 30 10:59:11 2023
Add CompatLegacyPagingSource in commonMain
LegacyPagingSource relies on PageFetcher to set the pageSize on new instance creation because LegacyPagingSource does not have access to PagingConfig. By adding CompatLegacyPagingSource interface, PageFetcher in commonMain can reference LegacyPagingSource in jvmMain.
Test: ./gradlew paging:paging-common:jvmTest
Bug: 288623117
Change-Id: I0ef1e7f0426b237d47beffbb4f1197d1e8d21ee5
A paging/paging-common/src/commonMain/kotlin/androidx/paging/CompatLegacyPagingSource.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/LegacyPagingSource.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PageFetcher.kt
ap...@google.com <ap...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-main
commit 6b5c1832b782dc20efb9e7bf90d89809efed491a
Author: Clara Fok <clarafok@google.com>
Date: Wed Jul 05 12:50:54 2023
Fix partial native build errors
Test: ./gradlew paging:paging-common:allTests
Bug: 288623117
Change-Id: Iad3a9bf06bbec2e9ab20328961effd1dd5e1b5b8
M paging/paging-common/src/commonTest/kotlin/androidx/paging/CachedPageEventFlowLeakTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageFetcherSnapshotTest.kt
https://android-review.googlesource.com/2647529
Branch: androidx-main
commit 6b5c1832b782dc20efb9e7bf90d89809efed491a
Author: Clara Fok <clarafok@google.com>
Date: Wed Jul 05 12:50:54 2023
Fix partial native build errors
Test: ./gradlew paging:paging-common:allTests
Bug: 288623117
Change-Id: Iad3a9bf06bbec2e9ab20328961effd1dd5e1b5b8
M paging/paging-common/src/commonTest/kotlin/androidx/paging/CachedPageEventFlowLeakTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageFetcherSnapshotTest.kt
ap...@google.com <ap...@google.com> #9
Project: platform/frameworks/support
Branch: androidx-main
commit 8448061e4d0ec86ed6431908dc93e5689d632c31
Author: Clara Fok <clarafok@google.com>
Date: Fri Jul 07 19:13:03 2023
Refactor Logger to PagingLogger
PagingLogger is now an expect object to be implemented by platforms.
Logger interface has been deprecated.
Test: ./gradlew paging:paging-common:allTests
Bug: 288623117
Relnote: "Logger interface has been deprecated"
Change-Id: I16e9505d60bbe864528e0be2266668c6140bcc24
M paging/paging-common/api/current.txt
M paging/paging-common/api/restricted_current.txt
A paging/paging-common/src/androidMain/kotlin/androidx/paging/PagingLogger.android.kt
A paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/Logger.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingLogger.kt
A paging/paging-common/src/jvmMain/kotlin/androidx/paging/PagingLogger.jvm.kt
A paging/paging-common/src/nativeMain/kotlin/androidx/paging/PagingLogger.native.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyPagingItems.kt
M paging/paging-runtime/src/main/java/androidx/paging/AsyncPagingDataDiffer.kt
https://android-review.googlesource.com/2651250
Branch: androidx-main
commit 8448061e4d0ec86ed6431908dc93e5689d632c31
Author: Clara Fok <clarafok@google.com>
Date: Fri Jul 07 19:13:03 2023
Refactor Logger to PagingLogger
PagingLogger is now an expect object to be implemented by platforms.
Logger interface has been deprecated.
Test: ./gradlew paging:paging-common:allTests
Bug: 288623117
Relnote: "Logger interface has been deprecated"
Change-Id: I16e9505d60bbe864528e0be2266668c6140bcc24
M paging/paging-common/api/current.txt
M paging/paging-common/api/restricted_current.txt
A paging/paging-common/src/androidMain/kotlin/androidx/paging/PagingLogger.android.kt
A paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/Logger.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingLogger.kt
A paging/paging-common/src/jvmMain/kotlin/androidx/paging/PagingLogger.jvm.kt
A paging/paging-common/src/nativeMain/kotlin/androidx/paging/PagingLogger.native.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyPagingItems.kt
M paging/paging-runtime/src/main/java/androidx/paging/AsyncPagingDataDiffer.kt
ap...@google.com <ap...@google.com> #10
Project: platform/frameworks/support
Branch: androidx-main
commit 5f18ef3219b7e3c11928df68cd144f3ae27a35c9
Author: Clara Fok <clarafok@google.com>
Date: Fri Jul 07 19:10:23 2023
Add commonJvmAndroidMain source set
Shared source set between android and jvm
Test: ./gradlew paging:paging-common:allTests
Bug: 288623117
Change-Id: I1a3cb7ab78dcf9e9856e1d83598cfc5697165e41
M paging/paging-common/build.gradle
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/ContiguousPagedList.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/DataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/InitialDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/InitialPagedList.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/ItemKeyedDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/LegacyPageFetcher.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/LegacyPagingSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/MainThread.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PageKeyedDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PagedList.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PagedListConfig.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PagedStorage.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PagingDataTransforms.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PositionalDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/SnapshotPagedList.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/WrapperDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/WrapperItemKeyedDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/WrapperPageKeyedDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/WrapperPositionalDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/CachedPageEventFlowLeakTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/ContiguousPagedListTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/DataSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/GarbageCollectionTestHelper.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/ItemKeyedDataSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/LegacyPageFetcherTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/LegacyPagingSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PageFetcherSnapshotTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PageFetcherTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PageKeyedDataSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PagedListConfigBuilderTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PagedListConfigTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PagedListTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PagedStorageTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PositionalDataSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/SingleRunnerTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/WrappedItemKeyedDataSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/WrappedPageKeyedDataSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/WrappedPositionalDataSourceTest.kt
https://android-review.googlesource.com/2651249
Branch: androidx-main
commit 5f18ef3219b7e3c11928df68cd144f3ae27a35c9
Author: Clara Fok <clarafok@google.com>
Date: Fri Jul 07 19:10:23 2023
Add commonJvmAndroidMain source set
Shared source set between android and jvm
Test: ./gradlew paging:paging-common:allTests
Bug: 288623117
Change-Id: I1a3cb7ab78dcf9e9856e1d83598cfc5697165e41
M paging/paging-common/build.gradle
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/ContiguousPagedList.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/DataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/InitialDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/InitialPagedList.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/ItemKeyedDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/LegacyPageFetcher.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/LegacyPagingSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/MainThread.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PageKeyedDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PagedList.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PagedListConfig.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PagedStorage.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PagingDataTransforms.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PositionalDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/SnapshotPagedList.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/WrapperDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/WrapperItemKeyedDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/WrapperPageKeyedDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/WrapperPositionalDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/CachedPageEventFlowLeakTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/ContiguousPagedListTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/DataSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/GarbageCollectionTestHelper.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/ItemKeyedDataSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/LegacyPageFetcherTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/LegacyPagingSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PageFetcherSnapshotTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PageFetcherTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PageKeyedDataSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PagedListConfigBuilderTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PagedListConfigTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PagedListTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PagedStorageTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PositionalDataSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/SingleRunnerTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/WrappedItemKeyedDataSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/WrappedPageKeyedDataSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/WrappedPositionalDataSourceTest.kt
ap...@google.com <ap...@google.com> #11
Project: platform/frameworks/support
Branch: androidx-main
commit 8ca12ffa12870c18855d58b559722ee016fc5273
Author: Clara Fok <clarafok@google.com>
Date: Wed Jul 05 17:24:35 2023
Make paging-common an android library
This allows paging-common to support android-specific implementations such as android logging.
Test: ./gradlew paging:paging-common:allTests
Bug: 288623117
Change-Id: Ia8804f1fb09ce1bb4270315358d8e77bf56a556b
A paging/paging-common/api/res-3.2.0-beta01.txt
A paging/paging-common/api/res-current.txt
M paging/paging-common/build.gradle
https://android-review.googlesource.com/2651248
Branch: androidx-main
commit 8ca12ffa12870c18855d58b559722ee016fc5273
Author: Clara Fok <clarafok@google.com>
Date: Wed Jul 05 17:24:35 2023
Make paging-common an android library
This allows paging-common to support android-specific implementations such as android logging.
Test: ./gradlew paging:paging-common:allTests
Bug: 288623117
Change-Id: Ia8804f1fb09ce1bb4270315358d8e77bf56a556b
A paging/paging-common/api/res-3.2.0-beta01.txt
A paging/paging-common/api/res-current.txt
M paging/paging-common/build.gradle
ap...@google.com <ap...@google.com> #12
Project: platform/frameworks/support
Branch: androidx-main
commit da3a23ad95a7ac83840000d5c38147df3069a7a7
Author: Clara Fok <clarafok@google.com>
Date: Wed Jul 05 17:59:03 2023
Make MainThread annotation optional
We currently only need to implement it in jvm.
Test: ./gradlew paging:paging-common:allTests
Bug: 288623117
Change-Id: I45b7f50488808083c770e7a2cbc86d73f61cd72d
M paging/paging-common/src/commonMain/kotlin/androidx/paging/MainThread.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/MainThread.jvm.kt
D paging/paging-common/src/nativeMain/kotlin/androidx/paging/annotation.kt
https://android-review.googlesource.com/2651247
Branch: androidx-main
commit da3a23ad95a7ac83840000d5c38147df3069a7a7
Author: Clara Fok <clarafok@google.com>
Date: Wed Jul 05 17:59:03 2023
Make MainThread annotation optional
We currently only need to implement it in jvm.
Test: ./gradlew paging:paging-common:allTests
Bug: 288623117
Change-Id: I45b7f50488808083c770e7a2cbc86d73f61cd72d
M paging/paging-common/src/commonMain/kotlin/androidx/paging/MainThread.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/MainThread.jvm.kt
D paging/paging-common/src/nativeMain/kotlin/androidx/paging/annotation.kt
ap...@google.com <ap...@google.com> #13
Project: platform/frameworks/support
Branch: androidx-main
commit 6820b291131c6d088680830ff9885cabb3b27dbe
Author: Clara Fok <clarafok@google.com>
Date: Wed Jul 05 12:24:49 2023
Move files to commonMain
Test: ./gradlew paging:paging-compose:assemble
Bug: 288623117
Change-Id: Ie59ef74259971b5d7c4f9a7b09ced0eaf46051da
M paging/paging-compose/src/androidMain/kotlin/androidx/paging/compose/PagingPlaceholderKey.android.kt
M paging/paging-compose/src/commonMain/kotlin/androidx/paging/compose/LazyFoundationExtensions.kt
M paging/paging-compose/src/commonMain/kotlin/androidx/paging/compose/LazyPagingItems.kt
A paging/paging-compose/src/commonMain/kotlin/androidx/paging/compose/PagingPlaceholders.kt
https://android-review.googlesource.com/2647528
Branch: androidx-main
commit 6820b291131c6d088680830ff9885cabb3b27dbe
Author: Clara Fok <clarafok@google.com>
Date: Wed Jul 05 12:24:49 2023
Move files to commonMain
Test: ./gradlew paging:paging-compose:assemble
Bug: 288623117
Change-Id: Ie59ef74259971b5d7c4f9a7b09ced0eaf46051da
M paging/paging-compose/src/androidMain/kotlin/androidx/paging/compose/PagingPlaceholderKey.android.kt
M paging/paging-compose/src/commonMain/kotlin/androidx/paging/compose/LazyFoundationExtensions.kt
M paging/paging-compose/src/commonMain/kotlin/androidx/paging/compose/LazyPagingItems.kt
A paging/paging-compose/src/commonMain/kotlin/androidx/paging/compose/PagingPlaceholders.kt
ap...@google.com <ap...@google.com> #14
Project: platform/frameworks/support
Branch: androidx-main
commit eade331e6a51105782e5f8168ee67c6c6627be17
Author: Clara Fok <clarafok@google.com>
Date: Tue Jul 04 17:22:57 2023
Change paging-compose to kmp structure
Targeting android build. Ideally we want paging-compose targets to match compose targets, which also includes desktop. But as of compose 1.5.0-beta03, compose has not publically released desktop build yet.
Test: ./graldew paging:paging-compose:cC
Bug: 288623117
Change-Id: I8f631f9533750566f9413dca2376867b6f4fc675
M paging/paging-compose/build.gradle
M paging/paging-compose/src/androidAndroidTest/kotlin/androidx/paging/compose/LazyPagingItemsPreviewTest.kt
M paging/paging-compose/src/androidAndroidTest/kotlin/androidx/paging/compose/LazyPagingItemsTest.kt
M paging/paging-compose/src/androidMain/kotlin/androidx/paging/compose/LazyFoundationExtensions.kt
M paging/paging-compose/src/androidMain/kotlin/androidx/paging/compose/LazyPagingItems.kt
M paging/paging-compose/src/androidMain/kotlin/androidx/paging/compose/PagingPlaceholders.kt
https://android-review.googlesource.com/2647527
Branch: androidx-main
commit eade331e6a51105782e5f8168ee67c6c6627be17
Author: Clara Fok <clarafok@google.com>
Date: Tue Jul 04 17:22:57 2023
Change paging-compose to kmp structure
Targeting android build. Ideally we want paging-compose targets to match compose targets, which also includes desktop. But as of compose 1.5.0-beta03, compose has not publically released desktop build yet.
Test: ./graldew paging:paging-compose:cC
Bug: 288623117
Change-Id: I8f631f9533750566f9413dca2376867b6f4fc675
M paging/paging-compose/build.gradle
M paging/paging-compose/src/androidAndroidTest/kotlin/androidx/paging/compose/LazyPagingItemsPreviewTest.kt
M paging/paging-compose/src/androidAndroidTest/kotlin/androidx/paging/compose/LazyPagingItemsTest.kt
M paging/paging-compose/src/androidMain/kotlin/androidx/paging/compose/LazyFoundationExtensions.kt
M paging/paging-compose/src/androidMain/kotlin/androidx/paging/compose/LazyPagingItems.kt
M paging/paging-compose/src/androidMain/kotlin/androidx/paging/compose/PagingPlaceholders.kt
ap...@google.com <ap...@google.com> #15
Project: platform/frameworks/support
Branch: androidx-main
commit 83b3afd2a0b0eea29e6de5d857244b1cb3ea1060
Author: Clara Fok <clarafok@google.com>
Date: Tue Jul 04 13:19:51 2023
Bump paging-compose dep on compose to 1.5.0-beta03
Bump to 1.5 which supports kmp
Test: ./gradlew paging:paging-compose:cC
Bug: 288623117
Change-Id: I95d2564c5921a384d136ea769f9597d7c29ed460
M paging/paging-compose/build.gradle
https://android-review.googlesource.com/2647526
Branch: androidx-main
commit 83b3afd2a0b0eea29e6de5d857244b1cb3ea1060
Author: Clara Fok <clarafok@google.com>
Date: Tue Jul 04 13:19:51 2023
Bump paging-compose dep on compose to 1.5.0-beta03
Bump to 1.5 which supports kmp
Test: ./gradlew paging:paging-compose:cC
Bug: 288623117
Change-Id: I95d2564c5921a384d136ea769f9597d7c29ed460
M paging/paging-compose/build.gradle
ap...@google.com <ap...@google.com> #16
Project: platform/frameworks/support
Branch: androidx-main
commit 12c32930789d6c6a99a3bcb4547888022fdc1651
Author: Clara Fok <clarafok@google.com>
Date: Mon Jul 10 17:26:25 2023
Fix paging-common connectedCheck task
Added android-specific test depdencies so connectedCheck task can run.
Test: ./gradlew paging:paging-common:cC
Bug: 288623117
Change-Id: I1d2c45bec21e4eeb112def1f184f9faf1d227117
M paging/paging-common/build.gradle
https://android-review.googlesource.com/2653235
Branch: androidx-main
commit 12c32930789d6c6a99a3bcb4547888022fdc1651
Author: Clara Fok <clarafok@google.com>
Date: Mon Jul 10 17:26:25 2023
Fix paging-common connectedCheck task
Added android-specific test depdencies so connectedCheck task can run.
Test: ./gradlew paging:paging-common:cC
Bug: 288623117
Change-Id: I1d2c45bec21e4eeb112def1f184f9faf1d227117
M paging/paging-common/build.gradle
cl...@google.com <cl...@google.com>
na...@google.com <na...@google.com> #17
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.paging:paging-common:3.3.0-alpha01
androidx.paging:paging-compose:3.3.0-alpha01
androidx.paging:paging-runtime:3.3.0-alpha01
Description