WatchFaceType.DIGITAL and other constants within annotation types show as RestrictTo.Scope.LIBRARY [288750666]

Fixed

Bug

Status Update

No update yet.

Description

ia...@gmail.com

created issue #1

Jun 26, 2023 12:04AM

Component used: Wear-Watchface

Version used: 1.2.0-alpha08 or higher

After upgrading to Wear Watchface 1.2.0-alpha08 or higher, I noticed an error in Android Studio on both the WatchFaceType and CanvasType integers that they should only be used within the androidx.wear.watchface library:

Companion.DIGITAL can only be accessed from within the same library
(androidx.wear.watchface:watchface)

It appears this is an unintended side effect of this CL that marked those annotation classes as @RestrictTo(RestrictTo.Scope.LIBRARY).

Would it be possible to separate the constants (which really could just be on a regular Kotlin object, rather than as part of a companion object of a restricted class) from the restricted annotation class (which it doesn't matter what the class name of that annotation actually is)?

It is really annoying to have the red underlines in Android Studio and associated lint failures.

FWIW, I noticed that this does not apply to constants such as WatchFaceStyle.PROTECT_STATUS_BAR, but only to constants within a public annotation class that is restricted.

From this search, it appears this issue affects:

all WatchFaceType constants
all CanvasType constants
all TapType constants
all ComplicationsSlotBoundsType constants

Comments

al...@google.com <al...@google.com> #2Jun 26, 2023 09:14AM

Assigned to al...@google.com.

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

al...@google.com <al...@google.com> #3Jun 26, 2023 09:37AM

Accepted by al...@google.com.

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

ap...@google.com <ap...@google.com> #4Jun 28, 2023 02:07PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

al...@google.com <al...@google.com> #5Jun 28, 2023 03:22PM

Marked as fixed.

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

ia...@gmail.com <ia...@gmail.com> #6Jun 28, 2023 04:17PM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

al...@google.com <al...@google.com> #7Jun 30, 2023 01:53PM

Status: Assigned (reopened)

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!

al...@google.com <al...@google.com> Jun 30, 2023 03:13PM

Accepted by al...@google.com.

al...@google.com <al...@google.com> #8Jul 3, 2023 09:26AM

Marked as fixed.

Thank you, I'll try it and check.

Message last modified on Jul 3, 2023 09:27AM

ia...@gmail.com <ia...@gmail.com> #9Jul 3, 2023 07:23PM

Hello. I have similar experience.

I'm using mlkit-language 16.1.1
I didnot meet this error until using AGP 4.2
I can get this error since using AGP 7.0
This error raised on Release build only(minimized by R8)
This error raised without obfuscation.