Crash when using Modifier.animateBounds without a LookAheadScope [289010786]

Can't Repro

Bug

Status Update

No update yet.

Description

ri...@google.com

created issue #1

Jun 27, 2023 08:13AM

When using Modifier.animateBounds without wrapping content in a LookaheadScope, the following crash occurs. I don't think it should crash, I think it should just not animate, or give a better error message to say that a LookaheadScope is required.

Stack trace:

FATAL EXCEPTION: main
                                                                                                    Process: com.example.jetlagged, PID: 10005
                                                                                                    java.lang.IllegalStateException: LayoutNode should be attached to an owner
                                                                                                        at androidx.compose.ui.node.LayoutNodeKt.requireOwner(LayoutNode.kt:1441)
                                                                                                        at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.placeOuterCoordinator-f8xVGno(LayoutNodeLayoutDelegate.kt:682)
                                                                                                        at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.placeAt-f8xVGno(LayoutNodeLayoutDelegate.kt:667)
                                                                                                        at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:34)
                                                                                                        at androidx.compose.ui.layout.Placeable$PlacementScope.place-70tqf50(Placeable.kt:450)
                                                                                                        at androidx.compose.ui.layout.Placeable$PlacementScope.place-70tqf50$default(Placeable.kt:225)
                                                                                                        at androidx.compose.foundation.layout.BoxKt.placeInBox(Box.kt:185)
                                                                                                        at androidx.compose.foundation.layout.BoxKt.access$placeInBox(Box.kt:1)
                                                                                                        at androidx.compose.foundation.layout.BoxKt$boxMeasurePolicy$1$measure$2.invoke(Box.kt:125)
                                                                                                        at androidx.compose.foundation.layout.BoxKt$boxMeasurePolicy$1$measure$2.invoke(Box.kt:124)
                                                                                                        at androidx.compose.ui.layout.MeasureScope$layout$1.placeChildren(MeasureScope.kt:70)
                                                                                                        at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$createMeasurePolicy$1$measure-3p2s80s$$inlined$createMeasureResult$1.placeChildren(SubcomposeLayout.kt:892)
                                                                                                        at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate$layoutChildren$1$1.invoke(LayoutNodeLayoutDelegate.kt:376)
                                                                                                        at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate$layoutChildren$1$1.invoke(LayoutNodeLayoutDelegate.kt:368)
                                                                                                        at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2303)
                                                                                                        at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:462)
                                                                                                        at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:230)
                                                                                                        at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:133)
                                                                                                        at androidx.compose.ui.node.OwnerSnapshotObserver.observeLayoutSnapshotReads$ui_release(OwnerSnapshotObserver.kt:83)
                                                                                                        at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.layoutChildren(LayoutNodeLayoutDelegate.kt:368)
                                                                                                        at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.onNodePlaced$ui_release(LayoutNodeLayoutDelegate.kt:504)
                                                                                                        at androidx.compose.ui.node.InnerNodeCoordinator.placeAt-f8xVGno(InnerNodeCoordinator.kt:160)
                                                                                                        at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:34)
                                                                                                        at androidx.compose.ui.layout.Placeable$PlacementScope.placeRelative(Placeable.kt:439)
                                                                                                        at androidx.compose.ui.layout.Placeable$PlacementScope.placeRelative$default(Placeable.kt:201)
                                                                                                        at androidx.compose.foundation.layout.PaddingNode$measure$1.invoke(Padding.kt:403)
                                                                                                        at androidx.compose.foundation.layout.PaddingNode$measure$1.invoke(Padding.kt:401)
                                                                                                        at androidx.compose.ui.layout.MeasureScope$layout$1.placeChildren(MeasureScope.kt:70)
                                                                                                        at androidx.compose.ui.node.LayoutModifierNodeCoordinator.placeAt-f8xVGno(LayoutModifierNodeCoordinator.kt:172)
                                                                                                        at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:34)
                                                                                                        at androidx.compose.ui.layout.Placeable$PlacementScope.place-70tqf50(Placeable.kt:450)
                                                                                                        at androidx.compose.ui.layout.IntermediateLayoutModifierNode$IntermediateMeasurablePlaceable.placeAt-f8xVGno(IntermediateLayoutModifierNode.kt:250)
                                                                                                        at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:34)
                                                                                                        at androidx.compose.ui.layout.Placeable$PlacementScope.place(Placeable.kt:447)
                                                                                                        at androidx.compose.ui.layout.Placeable$PlacementScope.place$default(Placeable.kt:213)
                                                                                                        at com.example.jetlagged.AnimateBoundsModifierKt$animateBounds$2$2$1.invoke(AnimateBoundsModifier.kt:92)
                                                                                                        at com.example.jetlagged.AnimateBoundsModifierKt$animateBounds$2$2$1.invoke(AnimateBoundsModifier.kt:86)
2023-06-26 16:01:18.635 10005-10005 AndroidRuntime          pid-10005                            E      at androidx.compose.ui.layout.IntermediateLayoutModifierNode$IntermediateMeasureScopeImpl$layout$1.placeChildren(IntermediateLayoutModifierNode.kt:341)
                                                                                                        at androidx.compose.ui.node.LayoutModifierNodeCoordinator.placeAt-f8xVGno(LayoutModifierNodeCoordinator.kt:172)
                                                                                                        at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:34)
                                                                                                        at androidx.compose.ui.layout.Placeable$PlacementScope.placeRelative(Placeable.kt:439)
                                                                                                        at androidx.compose.ui.layout.Placeable$PlacementScope.placeRelative$default(Placeable.kt:201)
                                                                                                        at androidx.compose.foundation.layout.SizeNode$measure$1.invoke(Size.kt:839)
                                                                                                        at androidx.compose.foundation.layout.SizeNode$measure$1.invoke(Size.kt:838)
                                                                                                        at androidx.compose.ui.layout.MeasureScope$layout$1.placeChildren(MeasureScope.kt:70)
                                                                                                        at androidx.compose.ui.node.LayoutModifierNodeCoordinator.placeAt-f8xVGno(LayoutModifierNodeCoordinator.kt:172)
                                                                                                        at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:34)
                                                                                                        at androidx.compose.ui.layout.Placeable$PlacementScope.place-70tqf50(Placeable.kt:450)
                                                                                                        at androidx.compose.ui.layout.Placeable$PlacementScope.place-70tqf50$default(Placeable.kt:225)
                                                                                                        at androidx.compose.foundation.layout.WrapContentNode$measure$1.invoke(Size.kt:1017)
                                                                                                        at androidx.compose.foundation.layout.WrapContentNode$measure$1.invoke(Size.kt:1009)
                                                                                                        at androidx.compose.ui.layout.MeasureScope$layout$1.placeChildren(MeasureScope.kt:70)
                                                                                                        at androidx.compose.ui.node.LayoutModifierNodeCoordinator.placeAt-f8xVGno(LayoutModifierNodeCoordinator.kt:172)
                                                                                                        at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:34)
                                                                                                        at androidx.compose.ui.layout.Placeable$PlacementScope.place-70tqf50(Placeable.kt:450)
                                                                                                        at androidx.compose.ui.layout.IntermediateLayoutModifierNode$IntermediateMeasurablePlaceable.placeAt-f8xVGno(IntermediateLayoutModifierNode.kt:250)
                                                                                                        at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:34)
                                                                                                        at androidx.compose.ui.layout.Placeable$PlacementScope.place(Placeable.kt:447)
                                                                                                        at androidx.compose.ui.layout.Placeable$PlacementScope.place$default(Placeable.kt:213)
                                                                                                        at com.example.jetlagged.AnimateBoundsModifierKt$animateBounds$2$1$1$1.invoke(AnimateBoundsModifier.kt:68)
                                                                                                        at com.example.jetlagged.AnimateBoundsModifierKt$animateBounds$2$1$1$1.invoke(AnimateBoundsModifier.kt:64)
                                                                                                        at androidx.compose.ui.layout.IntermediateLayoutModifierNode$IntermediateMeasureScopeImpl$layout$1.placeChildren(IntermediateLayoutModifierNode.kt:341)
                                                                                                        at androidx.compose.ui.node.LayoutModifierNodeCoordinator.placeAt-f8xVGno(LayoutModifierNodeCoordinator.kt:172)
                                                                                                        at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:34)
                                                                                                        at androidx.compose.ui.layout.Placeable$PlacementScope.place-70tqf50(Placeable.kt:450)
                                                                                                        at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate$placeOuterCoordinator$1.invoke(LayoutNodeLayoutDelegate.kt:694)
                                                                                                        at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate$placeOuterCoordinator$1.invoke(LayoutNodeLayoutDelegate.kt:689)
                                                                                                        at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2303)
                                                                                                        at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:462)
                                                                                                        at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:230)
                                                                                                        at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:133)
                                                                                                        at androidx.compose.ui.node.OwnerSnapshotObserver.observeLayoutModifierSnapshotReads$ui_release(OwnerSnapshotObserver.kt:98)
                                                                                                        at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.placeOuterCoordinator-f8xVGno(LayoutNodeLayoutDelegate.kt:689)
                                                                                                        at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.placeAt-f8xVGno(LayoutNodeLayoutDelegate.kt:667)
                                                                                                        at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:34)
                                                                                                        at androidx.compose.ui.layout.Placeable$PlacementScope.place(Placeable.kt:447)

Comments

ti...@google.com <ti...@google.com> #2Sep 6, 2023 01:57AM

Can you try with the latest snapshot? Not reproducible for me on androidx-main.

ri...@google.com <ri...@google.com> #3Sep 6, 2023 10:38AM

Status: Won't Fix (Not Reproducible)

Ok, after trying a couple more versions, realized this is a duplicate of b/291094055 and was fixed in 1.6.0-alpha02.

From the release notes:

AndroidView's update callback's first invocation will now be defered until the view is attached, instead of running when the composition that introduces the AndroidView is applied. This fixes a bug where the update callback wouldn't be invalidated if a state it read was changed immediately by an effect. (Ie9438, b/291094055)

Sorry for the confusion!

Issue 289010786

Description

Issue summary

Comments

ti...@google.com <ti...@google.com> #2Sep 6, 2023 01:57AM

ri...@google.com <ri...@google.com> #3Sep 6, 2023 10:38AM

Add comment

Issue metadata