Fixed
Status Update
Comments
lp...@google.com <lp...@google.com>
le...@google.com <le...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
ad...@decathlon.com <ad...@decathlon.com> #3
le...@google.com <le...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ad...@decathlon.com <ad...@decathlon.com> #5
Thanks for your answer !
You're right for the first issue behavior, it works like ViewPager2, and I hopped that Compose will fixed this 😅 ..
You're right for the first issue behavior, it works like ViewPager2, and I hopped that Compose will fixed this 😅 ..
le...@google.com <le...@google.com>
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit 8c5fbba1fe78ac9d1e7752eae7839d4e661be075
Author: Shahd AbuDaghash <shahddaghash@google.com>
Date: Fri Jul 14 16:14:07 2023
Update behavior of prefetcher.
Changed the behavior of the prefetcher not to perform prefetching as the page bounces back when the scrolling operation does not exceed the threshold to move to the next or previous screens. The condition is if the animator scrolling direction is the same as the direction of the pointer gesture, only then prefetching is performed.
Bug: 289088847
Test: Added test to verify behavior.
Change-Id: Ic742d3276d443948b76874ae04671b9b024609ad
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/pager/PagerGestureTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/pager/PagerPrefetcherTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/PagerState.kt
https://android-review.googlesource.com/2657245
Branch: androidx-main
commit 8c5fbba1fe78ac9d1e7752eae7839d4e661be075
Author: Shahd AbuDaghash <shahddaghash@google.com>
Date: Fri Jul 14 16:14:07 2023
Update behavior of prefetcher.
Changed the behavior of the prefetcher not to perform prefetching as the page bounces back when the scrolling operation does not exceed the threshold to move to the next or previous screens. The condition is if the animator scrolling direction is the same as the direction of the pointer gesture, only then prefetching is performed.
Bug: 289088847
Test: Added test to verify behavior.
Change-Id: Ic742d3276d443948b76874ae04671b9b024609ad
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/pager/PagerGestureTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/pager/PagerPrefetcherTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/PagerState.kt
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit 62b37f3a7b291b9fe74d72f025788671a2dbadb6
Author: Shahd AbuDaghash <shahddaghash@google.com>
Date: Fri Jul 28 17:30:44 2023
Update Pager prefetching behavior to match ViewPager2
The number of pages retained when using ViewPager2 was different from Pager in Compose. Therefore, the number of prefetched pages in Pager was updated to match the behavior in Views. Also, the documentation was fixed to make it clear that there will be pages automatically pre-fetched more than specified in beyondBoundsPageCount.
Fixes: 289088847
Test: Fixed previous tests that were affected by the change.
Relnote: Fixed an issue where the prefetching in Pager did not match the behavior in Views.
Change-Id: I93352e6de29fa8bc23b3af7516872d3e2da7ce0e
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/pager/BasePagerTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/pager/PageSizeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/pager/PagerAccessibilityTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/pager/PagerOffscreenPageLimitPlacingTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/pager/PagerPrefetcherTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/LazyLayoutPager.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/Pager.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/PagerLayoutInfo.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/PagerMeasure.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/PagerMeasureResult.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/PagerState.kt
https://android-review.googlesource.com/2671298
Branch: androidx-main
commit 62b37f3a7b291b9fe74d72f025788671a2dbadb6
Author: Shahd AbuDaghash <shahddaghash@google.com>
Date: Fri Jul 28 17:30:44 2023
Update Pager prefetching behavior to match ViewPager2
The number of pages retained when using ViewPager2 was different from Pager in Compose. Therefore, the number of prefetched pages in Pager was updated to match the behavior in Views. Also, the documentation was fixed to make it clear that there will be pages automatically pre-fetched more than specified in beyondBoundsPageCount.
Fixes: 289088847
Test: Fixed previous tests that were affected by the change.
Relnote: Fixed an issue where the prefetching in Pager did not match the behavior in Views.
Change-Id: I93352e6de29fa8bc23b3af7516872d3e2da7ce0e
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/pager/BasePagerTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/pager/PageSizeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/pager/PagerAccessibilityTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/pager/PagerOffscreenPageLimitPlacingTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/pager/PagerPrefetcherTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/LazyLayoutPager.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/Pager.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/PagerLayoutInfo.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/PagerMeasure.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/PagerMeasureResult.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/PagerState.kt
na...@google.com <na...@google.com> #8
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.6.0-alpha03
androidx.compose.foundation:foundation-android:1.6.0-alpha03
Description
Jetpack Compose version: androidx.compose:compose-bom:2023.06.01
Jetpack Compose component(s) used: HorizontalPager
Android Studio Build: Build #AI-222.4459.24.2221.10121639, built on May 12, 2023
Kotlin version: 1.8.21
Steps to Reproduce or Code Sample to Reproduce:
Surface( modifier = Modifier.fillMaxSize(), color = MaterialTheme.colorScheme.background ) { // Display 10 items val pagerState = rememberPagerState() HorizontalPager( state = pagerState, pageCount = 5, beyondBoundsPageCount = 0 ) { page -> // Our page content Column(Modifier.fillMaxSize()) { Log.d("TOTO", "Page load :${page + 1}") Text( text = "Page: $page", modifier = Modifier.fillMaxWidth() ) } } }
On load, only first page is displayed -> OK.
first wrong behavior :
second wrong behavior