Make subclasses of ListenableWorker.Result public [289122517]

Assigned

Feature Request

Status Update

No update yet.

Description

ey...@gmail.com

created issue #1

Jun 27, 2023 11:55PM

The latest version of work (2.9.0-alpha01) restricts usages of ListenableWorker.Result.* classes to the work library group. I was previously using them to determine if a result was a success or not, e.g.

override suspend fun doWork(): Result {
  ...
}.also { result ->
  if(result is Result.Success) {
    // do something
  }
}

Comments

se...@google.com <se...@google.com> #2Jun 29, 2023 10:03AM

It was always like that you can see it in blame here or in the attached screenshot.

Screenshot 2023-06-29 at 11.00.46.png

105 KB

View

Download

ey...@gmail.com <ey...@gmail.com> #3Jun 29, 2023 11:41AM

That's odd, I've had this code for two or three years already.

ey...@gmail.com <ey...@gmail.com> #4Jun 29, 2023 03:46PM

I reverted the work update, and the issue is happening when using AGP Hedgehog. It looks like maybe lint wasn't picking up these violations, and that was fixed as part of AGP Hedgehog.

ey...@gmail.com <ey...@gmail.com> #5Jun 29, 2023 03:47PM

Could ListenableWorker.Result get functionality to determine whether it succeeded, failed, or needs to retry?

se...@google.com <se...@google.com> #6Jul 1, 2023 11:40AM

Yeah, I don't see currently reasons to hide these classes, but I'll check out what was the thought behind this originally.

se...@google.com <se...@google.com> Feb 2, 2024 02:21PM

Assigned to ku...@google.com.

Issue 289122517