Java 16 Records: equals(null) throws NullPointerException [289237734]

Fixed

Bug

Status Update

No update yet.

Description

bu...@gmail.com

created issue #1

Jun 29, 2023 05:44AM

Records auto-generate several methods including .equals().

With the current implementation Android's Record.equals() crashes when using .equals(null) with:

java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Class java.lang.Object.getClass()' on a null object reference

when doing:

record RecordData(float data) {}
...
new RecordData(1).equals(null)

In plain Java, new RecordData(1).equals(null) reports as false.

Proof-of-problem: https://github.com/OpenTracksApp/OpenTracks/blob/949ba54bab026be0d84d7e14453cda4f31a4fff0/src/androidTest/java/de/dennisguse/opentracks/data/model/TrackTest.java

AGP: com.android.tools.build:gradle:8.1.0-rc01 Follow-up to: https://issuetracker.google.com/issues/197081367

Comments

ch...@google.com <ch...@google.com> Jun 29, 2023 05:58AM

Reassigned to ch...@google.com.

ap...@google.com <ap...@google.com> #2Jun 29, 2023 09:08AM

This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.

ap...@google.com <ap...@google.com> #3Jun 29, 2023 12:25PM

Almost 2 months later and this is still broken

ap...@google.com <ap...@google.com> #4Jun 29, 2023 12:25PM

Since there is no progression, I wanted to share our quick-fix for the issue.

#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages

ap...@google.com <ap...@google.com> #5Jun 29, 2023 12:25PM

jb...@google.com What is the update on this?

ap...@google.com <ap...@google.com> #6Jun 29, 2023 12:25PM

What is the status of this item?

ap...@google.com <ap...@google.com> #7Jun 29, 2023 12:26PM

This has been fixed on master today (internal ref: ag/2945015) and will be available in the next SDK release.

ap...@google.com <ap...@google.com> #8Jun 29, 2023 01:02PM

Any ETA on next release?

ap...@google.com <ap...@google.com> #9Jun 29, 2023 01:02PM

Still broken and not updated? --package_file argument is not usable in it's current form on 26.1.1 straight from the developer site.

sg...@google.com <sg...@google.com> Jul 25, 2023 12:36PM

Marked as fixed.