Fixed
Status Update
No update yet.
Comments
ch...@google.com
ap...@google.com
Project: r8
Branch: main
commit 2f14e24afd704e4e1c464d18b9f5abae02cdc7e1
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Jun 29 11:04:22 2023
Fix incorrect equals() implementation in record desugaring
Bug:
Change-Id: I03a35dc2aec5f4abba5f9b664f3f9ffc9132e50d
M src/main/java/com/android/tools/r8/ir/synthetic/RecordCfCodeProvider.java
M src/test/examplesJava17/records/SimpleRecord.java
M src/test/java/com/android/tools/r8/desugar/records/RecordMergeTest.java
M src/test/java/com/android/tools/r8/desugar/records/SimpleRecordTest.java
M src/test/java/com/android/tools/r8/profile/art/completeness/RecordProfileRewritingTest.java
https://r8-review.googlesource.com/81280
Branch: main
commit 2f14e24afd704e4e1c464d18b9f5abae02cdc7e1
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Jun 29 11:04:22 2023
Fix incorrect equals() implementation in record desugaring
Bug:
Change-Id: I03a35dc2aec5f4abba5f9b664f3f9ffc9132e50d
M src/main/java/com/android/tools/r8/ir/synthetic/RecordCfCodeProvider.java
M src/test/examplesJava17/records/SimpleRecord.java
M src/test/java/com/android/tools/r8/desugar/records/RecordMergeTest.java
M src/test/java/com/android/tools/r8/desugar/records/SimpleRecordTest.java
M src/test/java/com/android/tools/r8/profile/art/completeness/RecordProfileRewritingTest.java
ap...@google.com
Project: r8
Branch: 8.1
commit e5638f7b60e86a158ee3896bd53d5659a5ee5162
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Jun 29 13:42:08 2023
Version 8.1.58
Bug:
Change-Id: I12b3c005c19fdffa6a3d50b6be46137cbe77d0a9
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/81289
Branch: 8.1
commit e5638f7b60e86a158ee3896bd53d5659a5ee5162
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Jun 29 13:42:08 2023
Version 8.1.58
Bug:
Change-Id: I12b3c005c19fdffa6a3d50b6be46137cbe77d0a9
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com
Project: r8
Branch: 8.1
commit 76702f15fc83eb92dadb3e2e3155d5b8dfd48c5a
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Jun 29 13:41:34 2023
Fix incorrect equals() implementation in record desugaring
Bug:
Change-Id: I03a35dc2aec5f4abba5f9b664f3f9ffc9132e50d
M src/main/java/com/android/tools/r8/ir/synthetic/RecordCfCodeProvider.java
M src/test/examplesJava17/records/SimpleRecord.java
M src/test/java/com/android/tools/r8/desugar/records/RecordMergeTest.java
M src/test/java/com/android/tools/r8/desugar/records/SimpleRecordTest.java
M src/test/java/com/android/tools/r8/profile/art/completeness/RecordProfileRewritingTest.java
https://r8-review.googlesource.com/81288
Branch: 8.1
commit 76702f15fc83eb92dadb3e2e3155d5b8dfd48c5a
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Jun 29 13:41:34 2023
Fix incorrect equals() implementation in record desugaring
Bug:
Change-Id: I03a35dc2aec5f4abba5f9b664f3f9ffc9132e50d
M src/main/java/com/android/tools/r8/ir/synthetic/RecordCfCodeProvider.java
M src/test/examplesJava17/records/SimpleRecord.java
M src/test/java/com/android/tools/r8/desugar/records/RecordMergeTest.java
M src/test/java/com/android/tools/r8/desugar/records/SimpleRecordTest.java
M src/test/java/com/android/tools/r8/profile/art/completeness/RecordProfileRewritingTest.java
ap...@google.com
Project: r8
Branch: 8.0
commit 75cbe4e1817f289bebd4689efa2d61edd09c1ad7
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Jun 29 13:41:15 2023
Version 8.0.55
Bug:
Change-Id: I0efbb1ece0f3a6202b21ca9989da95ca2cabd82a
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/81287
Branch: 8.0
commit 75cbe4e1817f289bebd4689efa2d61edd09c1ad7
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Jun 29 13:41:15 2023
Version 8.0.55
Bug:
Change-Id: I0efbb1ece0f3a6202b21ca9989da95ca2cabd82a
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com
Project: r8
Branch: 8.0
commit 761051986c559516f3f509932c6bd36b5465db08
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Jun 29 13:40:57 2023
Fix incorrect equals() implementation in record desugaring
Bug:
Change-Id: I03a35dc2aec5f4abba5f9b664f3f9ffc9132e50d
M src/main/java/com/android/tools/r8/ir/synthetic/RecordCfCodeProvider.java
M src/test/examplesJava17/records/SimpleRecord.java
M src/test/java/com/android/tools/r8/desugar/records/RecordMergeTest.java
M src/test/java/com/android/tools/r8/desugar/records/SimpleRecordTest.java
https://r8-review.googlesource.com/81286
Branch: 8.0
commit 761051986c559516f3f509932c6bd36b5465db08
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Jun 29 13:40:57 2023
Fix incorrect equals() implementation in record desugaring
Bug:
Change-Id: I03a35dc2aec5f4abba5f9b664f3f9ffc9132e50d
M src/main/java/com/android/tools/r8/ir/synthetic/RecordCfCodeProvider.java
M src/test/examplesJava17/records/SimpleRecord.java
M src/test/java/com/android/tools/r8/desugar/records/RecordMergeTest.java
M src/test/java/com/android/tools/r8/desugar/records/SimpleRecordTest.java
ap...@google.com
Project: r8
Branch: 8.1
commit 76702f15fc83eb92dadb3e2e3155d5b8dfd48c5a
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Jun 29 13:41:34 2023
Fix incorrect equals() implementation in record desugaring
Bug:
Change-Id: I03a35dc2aec5f4abba5f9b664f3f9ffc9132e50d
M src/main/java/com/android/tools/r8/ir/synthetic/RecordCfCodeProvider.java
M src/test/examplesJava17/records/SimpleRecord.java
M src/test/java/com/android/tools/r8/desugar/records/RecordMergeTest.java
M src/test/java/com/android/tools/r8/desugar/records/SimpleRecordTest.java
M src/test/java/com/android/tools/r8/profile/art/completeness/RecordProfileRewritingTest.java
https://r8-review.googlesource.com/81288
Branch: 8.1
commit 76702f15fc83eb92dadb3e2e3155d5b8dfd48c5a
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Jun 29 13:41:34 2023
Fix incorrect equals() implementation in record desugaring
Bug:
Change-Id: I03a35dc2aec5f4abba5f9b664f3f9ffc9132e50d
M src/main/java/com/android/tools/r8/ir/synthetic/RecordCfCodeProvider.java
M src/test/examplesJava17/records/SimpleRecord.java
M src/test/java/com/android/tools/r8/desugar/records/RecordMergeTest.java
M src/test/java/com/android/tools/r8/desugar/records/SimpleRecordTest.java
M src/test/java/com/android/tools/r8/profile/art/completeness/RecordProfileRewritingTest.java
ap...@google.com
Project: r8
Branch: 8.0
commit 4a14cfb9a43aa46e5df72315297d241b4926b676
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Jun 29 14:49:12 2023
Version 8.0.56
Bug:
Change-Id: I511720305b661f1100d48b4ce2d6e4607f5339b7
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/81293
Branch: 8.0
commit 4a14cfb9a43aa46e5df72315297d241b4926b676
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Jun 29 14:49:12 2023
Version 8.0.56
Bug:
Change-Id: I511720305b661f1100d48b4ce2d6e4607f5339b7
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com
Project: r8
Branch: 8.0
commit 3eb5287763ad4e279bc87f76ae2353897464e259
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Jun 29 14:45:53 2023
Rewrite IfType to If.Type
Change-Id: If0bf3a0938da4ee42a797c01a86e173c34649e56
Bug:
M src/main/java/com/android/tools/r8/ir/synthetic/RecordCfCodeProvider.java
https://r8-review.googlesource.com/81292
Branch: 8.0
commit 3eb5287763ad4e279bc87f76ae2353897464e259
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Jun 29 14:45:53 2023
Rewrite IfType to If.Type
Change-Id: If0bf3a0938da4ee42a797c01a86e173c34649e56
Bug:
M src/main/java/com/android/tools/r8/ir/synthetic/RecordCfCodeProvider.java
Description
Records auto-generate several methods including
.equals().With the current implementation Android's Record.equals() crashes when using
.equals(null)with:when doing:
In plain Java,
new RecordData(1).equals(null)reports asfalse.Proof-of-problem:https://github.com/OpenTracksApp/OpenTracks/blob/949ba54bab026be0d84d7e14453cda4f31a4fff0/src/androidTest/java/de/dennisguse/opentracks/data/model/TrackTest.java
AGP: com.android.tools.build:gradle:8.1.0-rc01 Follow-up to: