splashcreen vector icon with tag gradient causes crash on Android 6.0 and below [289242141]

Fixed

Bug

Status Update

No update yet.

Description

bm...@gmail.com

created issue #1

Jun 28, 2023 07:42PM

Component used: androidx.core.core-splashscreen

Version used: 1.0.1 or 1.1.0-alpha01

Devices/Android versions reproduced on: Android 6.0 (API32) or below

Recently I found a bug related to function getDrawable, converting vector with tag gradient, and because it was implemented from API24 then getDrawable causes app crush.

1st bug is located here -> https://github.com/androidx/androidx/blob/androidx-main/core/core-splashscreen/src/main/java/androidx/core/splashscreen/SplashScreen.kt#L264

instead of:

icon = currentTheme.getDrawable(typedValue.resourceId)

and it must be replaced on:

icon = AppCompatResources.getDrawable(activity, typedValue.resourceId)

2nd bug is located here -> https://github.com/androidx/androidx/blob/androidx-main/core/core-splashscreen/src/main/java/androidx/core/splashscreen/SplashScreen.kt#L354

instead of:

val iconBackgroundDrawable = context.getDrawable(R.drawable.icon_background)

and it must be replaced on:

val iconBackgroundDrawable = AppCompatResources.getDrawable(context, R.drawable.icon_background)

Example of vector drawable from project -> https://raw.githubusercontent.com/bmx666/MidiSheetMusic-Android/844c503e9859c7e253858e298e30f2929a7b0171/app/src/main/res/drawable-v24/ic_launcher_foreground.xml

<vector xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:aapt="http://schemas.android.com/aapt"
    android:width="108dp"
    android:height="108dp"
    android:viewportWidth="108"
    android:viewportHeight="108">
  <path
      android:pathData="M77.25,30.75 L31.063,77.688 61.375,108H108V61.328Z"
      android:strokeAlpha="0.23299997"
      android:strokeLineJoin="miter"
      android:strokeWidth="1"
      android:fillColor="#000000"
      android:strokeColor="#00000000"
      android:fillAlpha="0.23299997"
      android:strokeLineCap="butt"/>
  <path
      android:pathData="M54,54m-33,0a33,33 0,1 1,66 0a33,33 0,1 1,-66 0"
      android:strokeAlpha="0.99"
      android:strokeWidth="0.75"
      android:fillAlpha="0.99">
    <aapt:attr name="android:fillColor">
      <gradient 
          android:startY="21.6875"
          android:startX="21"
          android:endY="87"
          android:endX="86.3125"
          android:type="linear">
        <item android:offset="0" android:color="#FF80C1C4"/>
        <item android:offset="1" android:color="#FF48979B"/>
      </gradient>
    </aapt:attr>
  </path>
  <path
      android:pathData="M74.281,31.072 L47.074,35.869 43.344,51.065v11.788l-7.665,11.803 11.659,11.659A33,33 0,0 0,54 87,33 33,0 0,0 87,54 33,33 0,0 0,84.357 41.148Z"
      android:strokeAlpha="0.33000004"
      android:strokeLineJoin="miter"
      android:strokeWidth="0.6875"
      android:strokeColor="#00000000"
      android:fillAlpha="0.33000004"
      android:strokeLineCap="butt">
    <aapt:attr name="android:fillColor">
      <gradient 
          android:startY="28.095896"
          android:startX="29.057898"
          android:endY="87.97657"
          android:endX="89.35623"
          android:type="linear">
        <item android:offset="0" android:color="#FF000000"/>
        <item android:offset="1" android:color="#00000000"/>
      </gradient>
    </aapt:attr>
  </path>
  <path
      android:pathData="M74.281,31.072L43.344,36.527L43.344,43.402L43.344,62.912A7.219,7.219 0,0 0,40.938 62.49A7.219,7.219 0,0 0,33.719 69.709A7.219,7.219 0,0 0,40.938 76.928A7.219,7.219 0,0 0,48.139 70.053L48.156,70.053L48.156,42.553L69.469,38.795L69.469,58.1A7.219,7.219 0,0 0,67.063 57.678A7.219,7.219 0,0 0,59.844 64.896A7.219,7.219 0,0 0,67.063 72.115A7.219,7.219 0,0 0,74.264 65.24L74.281,65.24L74.281,64.896L74.281,37.947L74.281,31.072z"
      android:strokeWidth="0.68920535"
      android:fillColor="#f8f4f4"
      android:fillAlpha="1"/>
  <group>
    <clip-path android:pathData="M-0,0L108,0L108,108L-0,108Z M 0,0"/>
  </group>
  <group>
    <clip-path android:pathData="M-0,0L108,0L108,108L-0,108Z M 0,0"/>
    <group>
      <clip-path android:pathData="M-0.071,-0.071L108.071,-0.071L108.071,108.071L-0.071,108.071Z M 0,0"/>
      <group>
        <clip-path android:pathData="M-0.035,-0.035L108.035,-0.035L108.035,108.035L-0.035,108.035Z M 0,0"/>
      </group>
      <group>
        <clip-path android:pathData="M-0.035,-0.035L108.035,-0.035L108.035,108.035L-0.035,108.035Z M 0,0"/>
      </group>
    </group>
    <group>
      <clip-path android:pathData="M28,28L80,28L80,80L28,80Z M 0,0"/>
    </group>
    <group>
      <clip-path android:pathData="M36,36L72,36L72,72L36,72Z M 0,0"/>
    </group>
    <group>
      <clip-path android:pathData="M27.9,35.9L80.1,35.9L80.1,72.1L27.9,72.1Z M 0,0"/>
    </group>
    <group>
      <clip-path android:pathData="M35.9,27.9L72.1,27.9L72.1,80.1L35.9,80.1Z M 0,0"/>
    </group>
    <group>
      <clip-path android:pathData="M31.9,31.9L76.1,31.9L76.1,76.1L31.9,76.1Z M 0,0"/>
    </group>
    <group>
      <clip-path android:pathData="M18,18L90,18L90,90L18,90Z M 0,0"/>
    </group>
  </group>
</vector>

Comments

rg...@google.com <rg...@google.com> Jun 30, 2023 09:20AM

Reassigned to wi...@google.com.

bm...@gmail.com <bm...@gmail.com> #2Feb 2, 2024 04:25PM

The issue is reproducible with core-ktx 1.2.0 and 1.3.0-rc01.

ch...@google.com <ch...@google.com> Jul 18, 2024 01:55AM

Reassigned to ch...@google.com.

ap...@google.com <ap...@google.com> #3Jul 18, 2024 08:16AM

The Typeface.weight is not a weight of the underlying font file. It is a display style. On older APIs, the display style is adjusted if the Typeface is created from single font. However, after moving to CustomFallbackBuilder, that adjustment is removed since it can crate Typeface from multiple style font files.

Looks like it is good to set display style by ResourcesCompat.getFont for backward compatibility.

bm...@gmail.com <bm...@gmail.com> #4Aug 27, 2024 07:20PM

Hi Nona,

Can you please schedule a release after you merge the fix?

ch...@google.com <ch...@google.com> Aug 28, 2024 08:42AM

Marked as fixed.

pr...@google.com <pr...@google.com> #5Sep 5, 2024 08:09PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3d6aa2e9b3243dcc4de1f54bd8d40339bd69cb05
Author: Seigo Nonaka <nona@google.com>
Date: Wed May 27 17:38:05 2020

Adjust the Typeface display style with the style of given font

This behavir is implicitly done by Typeface.Builder and
Typeface.createXXX function but not to be done by
Typeface.CustomFallbackBuilder since it is designed to be working
with multiple font files which has different style.

Looks like the style argument is ignored on older API implementation.

Bug: 156853883
Bug: 152023266
Test: ResourcesCompatTest#testGetFont_adjustDisplayStyle passes on 29
Test: ./gradlew core:core:connectedAndroidTest on API 29, 28, 23
Change-Id: I3a377c339a7aed50973cf11df86ddf0069f4ec25

A core/core/src/androidTest/assets/fonts/thin_italic.ttf
A core/core/src/androidTest/assets/fonts/thin_italic.ttx
M core/core/src/androidTest/java/androidx/core/content/res/ResourcesCompatTest.java
A core/core/src/androidTest/res/font/thin_italic.ttf
M core/core/src/main/java/androidx/core/graphics/TypefaceCompatApi29Impl.java

https://android-review.googlesource.com/1318947