Fixed
Status Update
Comments
rg...@google.com <rg...@google.com>
bm...@gmail.com <bm...@gmail.com> #2
Any update?
ch...@google.com <ch...@google.com>
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit f46016287e7d95cc1a57b28fbdc5d0046bfe77fa
Author: chunmu <chunmu@google.com>
Date: Tue Jul 16 11:02:25 2024
Get splashscreen icon by AppCompatResources
Make splashscreen to get the drawables of icon and icon background by
AppCompatResources so as to provide better backport on API < 24
Bug: 289242141
Bug: 263972037
Test: Manually tested by modifying icons in the sample
Change-Id: Ib05e2e7da40ee7c7db39ff8512cfa97861b7ee3e
Signed-off-by: Chun-Mu Weng <chunmu@google.com>
M core/core-splashscreen/build.gradle
M core/core-splashscreen/src/main/java/androidx/core/splashscreen/SplashScreen.kt
https://android-review.googlesource.com/3175379
Branch: androidx-main
commit f46016287e7d95cc1a57b28fbdc5d0046bfe77fa
Author: chunmu <chunmu@google.com>
Date: Tue Jul 16 11:02:25 2024
Get splashscreen icon by AppCompatResources
Make splashscreen to get the drawables of icon and icon background by
AppCompatResources so as to provide better backport on API < 24
Bug: 289242141
Bug: 263972037
Test: Manually tested by modifying icons in the sample
Change-Id: Ib05e2e7da40ee7c7db39ff8512cfa97861b7ee3e
Signed-off-by: Chun-Mu Weng <chunmu@google.com>
M core/core-splashscreen/build.gradle
M core/core-splashscreen/src/main/java/androidx/core/splashscreen/SplashScreen.kt
bm...@gmail.com <bm...@gmail.com> #4
thanks for update! could you please close issue?
ch...@google.com <ch...@google.com>
pr...@google.com <pr...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.core:core-splashscreen:1.2.0-alpha02
Description
Component used: androidx.core.core-splashscreen
Version used: 1.0.1 or 1.1.0-alpha01
Devices/Android versions reproduced on: Android 6.0 (API32) or below
Recently I found a bug related to function getDrawable, converting vector with tag gradient, and because it was implemented from API24 then getDrawable causes app crush.
1st bug is located here ->https://github.com/androidx/androidx/blob/androidx-main/core/core-splashscreen/src/main/java/androidx/core/splashscreen/SplashScreen.kt#L264
instead of:
and it must be replaced on:
2nd bug is located here ->https://github.com/androidx/androidx/blob/androidx-main/core/core-splashscreen/src/main/java/androidx/core/splashscreen/SplashScreen.kt#L354
instead of:
and it must be replaced on:
Example of vector drawable from project ->https://raw.githubusercontent.com/bmx666/MidiSheetMusic-Android/844c503e9859c7e253858e298e30f2929a7b0171/app/src/main/res/drawable-v24/ic_launcher_foreground.xml