Deprecate isAtLeastU() [289269026]

Fixed

Bug

Status Update

No update yet.

Description

al...@google.com

created issue #1

Jun 28, 2023 09:05PM

We've finalized SDK_INT 34, we should deprecate the check.

Comments

al...@google.com <al...@google.com> Jun 28, 2023 09:15PM

Accepted by al...@google.com.

ap...@google.com <ap...@google.com> #2Jul 7, 2023 06:39PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3Jul 7, 2023 06:39PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2d0bac96f2d8f9ef7dd1d988e9c43fc622369977
Author: Alan Viverette <alanv@google.com>
Date: Fri Jul 07 11:10:07 2023

Replace usages of deprecated BuildCompat.isAtLeastU() et al

Bug: 289269026
Relnote: Removed usages of experimental isAtLeastU() API
Test: ./gradlew lintDebug
Change-Id: Ie9117598f70e8873011f98ebbe0e6cd502772c87

M activity/activity/src/main/java/androidx/activity/BackEventCompat.kt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/DropDownListView.java
M appsearch/appsearch/src/androidTest/java/androidx/appsearch/cts/app/AppSearchSessionPlatformCtsTest.java
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/BaselineProfiles.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/CompilationMode.kt
M core/core-i18n/src/androidTest/java/androidx/core/i18n/CheckTheJavaApisTest.java
M core/core-i18n/src/androidTest/java/androidx/core/i18n/DateTimeFormatterCommonOptionsTest.kt
M core/core-i18n/src/androidTest/java/androidx/core/i18n/DateTimeFormatterTest.kt
M core/core/src/androidTest/java/androidx/core/app/ActivityCompatTest.java
M core/core/src/androidTest/java/androidx/core/content/ContextCompatTest.java
M core/core/src/androidTest/java/androidx/core/content/IntentCompatTest.java
M core/core/src/androidTest/java/androidx/core/content/res/ResourcesCompatTest.java
M core/core/src/androidTest/java/androidx/core/os/BundleCompatTest.java
M core/core/src/androidTest/java/androidx/core/os/ParcelCompatTest.java
M core/core/src/androidTest/java/androidx/core/view/DisplayCutoutCompatTest.java
M core/core/src/main/java/androidx/core/app/ActivityCompat.java
M core/core/src/main/java/androidx/core/app/ComponentActivity.java
M core/core/src/main/java/androidx/core/app/GrammaticalInflectionManagerCompat.java
M core/core/src/main/java/androidx/core/app/ServiceCompat.java
M core/core/src/main/java/androidx/core/content/ContextCompat.java
M core/core/src/main/java/androidx/core/content/IntentCompat.java
M core/core/src/main/java/androidx/core/os/LocaleListCompat.java
M core/core/src/main/java/androidx/core/os/ParcelCompat.java
M core/core/src/main/java/androidx/core/text/util/LocalePreferences.java
M core/core/src/main/java/androidx/core/view/accessibility/AccessibilityNodeInfoCompat.java
M credentials/credentials-play-services-auth/src/androidTest/java/androidx/credentials/playservices/CredentialProviderPlayServicesImplJavaTest.java
M credentials/credentials-play-services-auth/src/androidTest/java/androidx/credentials/playservices/CredentialProviderPlayServicesImplTest.kt
M credentials/credentials/src/androidTest/java/androidx/credentials/PrepareGetCredentialResponseJavaTest.java
M credentials/credentials/src/androidTest/java/androidx/credentials/PrepareGetCredentialResponseTest.kt
M credentials/credentials/src/androidTest/java/androidx/credentials/TestUtils.kt
M credentials/credentials/src/androidTest/java/androidx/credentials/provider/CredentialProviderServiceJavaTest.java
M credentials/credentials/src/androidTest/java/androidx/credentials/provider/CredentialProviderServiceTest.kt
M credentials/credentials/src/androidTest/java/androidx/credentials/provider/PendingIntentHandlerJavaTest.java
M credentials/credentials/src/androidTest/java/androidx/credentials/provider/PendingIntentHandlerTest.kt
M graphics/graphics-core/src/androidTest/java/androidx/graphics/lowlatency/CanvasFrontBufferedRendererTest.kt
M graphics/graphics-core/src/androidTest/java/androidx/graphics/lowlatency/SingleBufferedCanvasRendererV34Test.kt
M graphics/graphics-core/src/main/java/androidx/graphics/lowlatency/SingleBufferedCanvasRenderer.kt
M graphics/graphics-path/api/current.txt
M graphics/graphics-path/api/restricted_current.txt
M graphics/graphics-path/src/main/java/androidx/graphics/path/PathIterator.kt
M graphics/graphics-path/src/main/java/androidx/graphics/path/PathIteratorImpl.kt
M media/media/src/main/java/androidx/media/app/NotificationCompat.java
M mediarouter/mediarouter/src/main/java/androidx/mediarouter/media/MediaRoute2Provider.java
M privacysandbox/ads/ads-adservices-java/src/androidTest/java/androidx/privacysandbox/ads/adservices/java/endtoend/TestUtil.java
M privacysandbox/sdkruntime/sdkruntime-client/src/main/java/androidx/privacysandbox/sdkruntime/client/SdkSandboxManagerCompat.kt
M privacysandbox/sdkruntime/sdkruntime-core/src/main/java/androidx/privacysandbox/sdkruntime/core/controller/SdkSandboxControllerCompat.kt
M recyclerview/recyclerview/src/androidTest/java/androidx/recyclerview/widget/StretchEdgeEffectTest.java
M samples/MediaRoutingDemo/src/main/java/com/example/androidx/mediarouting/RoutesManager.java
M samples/MediaRoutingDemo/src/main/java/com/example/androidx/mediarouting/activities/RouteListingPreferenceActivity.java
M text/text/src/main/java/androidx/compose/ui/text/android/BoringLayoutFactory.kt
M text/text/src/main/java/androidx/compose/ui/text/android/StaticLayoutFactory.kt
M transition/transition/src/androidTest/java/androidx/transition/ChangeBoundsTest.java
M transition/transition/src/androidTest/java/androidx/transition/ChangeClipBoundsTest.java
M transition/transition/src/androidTest/java/androidx/transition/ChangeImageTransformTest.java
M transition/transition/src/androidTest/java/androidx/transition/ChangeScrollTest.java
M transition/transition/src/androidTest/java/androidx/transition/ExplodeTest.java
M transition/transition/src/androidTest/java/androidx/transition/FadeTest.java
M transition/transition/src/androidTest/java/androidx/transition/SeekTransitionTest.kt
M transition/transition/src/androidTest/java/androidx/transition/SlideEdgeTest.java
M transition/transition/src/main/java/androidx/transition/Transition.java
M transition/transition/src/main/java/androidx/transition/TransitionManager.java

https://android-review.googlesource.com/2647279

ap...@google.com <ap...@google.com> #4Jul 7, 2023 06:39PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8479537c5d8391619a500a8c8ad18197dacf760b
Author: Alan Viverette <alanv@google.com>
Date: Thu Jun 29 09:23:38 2023

Rename BuildCompat prior to Kotlin migration

Bug: 289269026
Test: BuildCompatTest
Change-Id: I982a309fe5d8d95d915d0ad7ab69ebbf80c13933

M core/core/src/main/java/androidx/core/os/BuildCompat.kt

https://android-review.googlesource.com/2645579

ap...@google.com <ap...@google.com> #5Jul 7, 2023 06:39PM

Project: platform/frameworks/support
Branch: androidx-main

commit e9944e08804986b874b2dac5e563a2fcc725c011
Author: Alan Viverette <alanv@google.com>
Date: Thu Jun 29 09:26:04 2023

Convert BuildCompat to Kotlin

Relnote: Migrated BuildCompat to Kotlin for enhanced Deprecated tag
Bug: 289269026
Test: BuildCompatTest
Change-Id: I56775e11c79e893138b67add76f758489a4262de

M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/os/BuildCompat.kt

https://android-review.googlesource.com/2642076