Deprecate isAtLeastU() [289269026]

Fixed

Bug

Status Update

No update yet.

Description

al...@google.com

created issue #1

Jun 28, 2023 09:05PM

We've finalized SDK_INT 34, we should deprecate the check.

Comments

al...@google.com <al...@google.com> Jun 28, 2023 09:15PM

Accepted by al...@google.com.

ap...@google.com <ap...@google.com> #2Jul 7, 2023 06:39PM

Marked as fixed.

The internal systemBarsForVisualComponents right now only uses systemBars, which doesn't include the display cutout: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/internal/SystemBarsDefaultInsets.android.kt;l=24;drc=dcaa116fbfda77e64a319e1668056ce3b032469f

Updating to systemBars.union(displayCutout) should fix this, if that's a change we can make.

ap...@google.com <ap...@google.com> #3Jul 7, 2023 06:39PM

Thank you for looking into this! It would be crucial to get this right soon as the edge2edge project depends on handling this properly :)

ap...@google.com <ap...@google.com> #4Jul 7, 2023 06:39PM

Not taking the display cutout into account will impact cars heavily, since some have very large display cutouts:

https://developer.android.com/codelabs/build-a-parked-app#10

ap...@google.com <ap...@google.com> #5Jul 7, 2023 06:39PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Alex Vanyo <vanyo@google.com>
Link: https://android-review.googlesource.com/3422569

Add displayCutout to default Material insets

Expand for full commit details

Add displayCutout to default Material insets 
 
Relnote: "Adds displayCutout to the group of insets that Material 
components take into account by default, to avoid content overlapping 
with the display cutout. 
 
This is a behavior change that will impact how inset-aware 
components behave around a display cutout. This includes the default 
value of the WindowInsets parameter for inset-aware Material 3 
components, and the WindowInsets values provided in the component 
Defaults objects for both Material 2 and Material 3. 
If this change causes undesirable behavior, 
manually specify the WindowInsets parameter on a per-component basis." 
 
Fixes: 362508045 
 
Change-Id: I43ee9ad12db0450ebb9c65ce10d5c39d12628b6c

Files:

M compose/material/material/src/androidMain/kotlin/androidx/compose/material/SystemBarsDefaultInsets.android.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/MaterialComponentsInsetSupportTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/internal/SystemBarsDefaultInsets.android.kt

Hash: 692b440ac97b1831d5b35aafff241a98aeeacb93
Date: Wed Dec 18 19:49:15 2024