SavedStateHandle is empty for navigation.compose Dialogs after process death [289436035]

Fixed

Bug

Status Update

No update yet.

Description

lu...@gwplc.com

created issue #1

Jun 30, 2023 01:54PM

Component used: androidx.navigation.compose

Version used: 2.6.0

Devices/Android versions reproduced on: Emulator (Resizable, API 33), but seen of many devices in the wild.

Summary

When using the dialog extension method to add a navigation destination. If the content inside has a ViewModel that uses the SavedStateHandle. When the app is sent to the background, killed by the system, and then restored, the SavedStateHandle is empty.

In addition the use of a rememberSaveable in the content of the dialog doesn't restore its value after process death either.

Sample Project

A demo project Available on GitHub with reproduction steps.

Screen recording

Screen recording is attached, in which "Don't Keep Activities" is turned on to simulate the process death.

Screen Recording 2023-06-30 at 14.07.22.mov

4.3 MB

Download

Comments

il...@google.com <il...@google.com> Jul 11, 2023 10:12PM

Assigned to jb...@google.com.

jb...@google.com <jb...@google.com> Jul 20, 2023 06:01PM

Reassigned to cl...@google.com.

cl...@google.com <cl...@google.com> #2Aug 1, 2023 08:03PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 42d5037be3a80f5ff840eee1f0a74bfb8f287d66
Author: Ben Weiss <benweiss@google.com>
Date: Thu Dec 10 16:20:02 2020

Add factory functions for DynamicNavHostFragment

Bug: 175222619
Test: updateApi and cAT
RelNote: Add factory functions for DynamicNavHostFragment
Change-Id: Icd51523a8f3cc3f93fffc1796c6a270bc28eaede

M navigation/navigation-dynamic-features-fragment/api/current.txt
M navigation/navigation-dynamic-features-fragment/api/public_plus_experimental_current.txt
M navigation/navigation-dynamic-features-fragment/api/restricted_current.txt
M navigation/navigation-dynamic-features-fragment/src/androidTest/java/androidx/navigation/dynamicfeatures/fragment/DynamicFragmentNavigatorDestinationBuilderTest.kt
M navigation/navigation-dynamic-features-fragment/src/androidTest/java/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragmentTest.kt
M navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragment.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.java

https://android-review.googlesource.com/1523818

ap...@google.com <ap...@google.com> #3Aug 29, 2023 10:31PM

I couldn't seem to find the create method in my codebase on the latest Navigation release 2.3.5. Has this change been merged into latest release?

https://androidx.tech/artifacts/navigation/navigation-dynamic-features-fragment/2.3.5-source/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragment.kt.html

cl...@google.com <cl...@google.com> #4Aug 30, 2023 05:34PM

Marked as fixed.

This adds new APIs therefore will be available in Navigation 2.4.0-alpha01.

pr...@google.com <pr...@google.com> #5Sep 6, 2023 07:56PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.2
androidx.lifecycle:lifecycle-viewmodel-savedstate:2.7.0-alpha02