Fixed
Status Update
No update yet.
Comments
il...@google.com
jb...@google.com
cl...@google.com
Yigit, do you have time to fix it?
reemission of the same liveData is racy
reemission of the same liveData is racy
ap...@google.com
yea i'll take it.
cl...@google.com
Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.
pr...@google.com
just emitting same live data reproduces the issue.
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
Description
Component used:
androidx.navigation.composeVersion used:
2.6.0Devices/Android versions reproduced on: Emulator (Resizable, API 33), but seen of many devices in the wild.
Summary
When using the
dialogextension method to add a navigation destination. If the content inside has aViewModelthat uses theSavedStateHandle. When the app is sent to the background, killed by the system, and then restored, theSavedStateHandleis empty.In addition the use of a
rememberSaveablein the content of thedialogdoesn't restore its value after process death either.Sample Project
A demo project
Screen recording
Screen recording is attached, in which "Don't Keep Activities" is turned on to simulate the process death.