Lint 31.0.2 fails with java.util.NoSuchElementException: Array is empty. [289695599]

Fixed

Bug

Status Update

No update yet.

Description

va...@gmail.com

created issue #1

Jul 2, 2023 10:04PM

Full stacktrace:

java.util.NoSuchElementException: Array is empty.
	at kotlin.collections.ArraysKt___ArraysKt.first(_Arrays.kt:1012)
	at com.android.tools.lint.checks.infrastructure.SuppressibleTestMode.rewriteKotlinOrJava(SuppressibleTestMode.kt:359)
	at com.android.tools.lint.checks.infrastructure.SuppressibleTestMode.rewrite(SuppressibleTestMode.kt:185)
	at com.android.tools.lint.checks.infrastructure.SuppressibleTestMode.before(SuppressibleTestMode.kt:133)
	at com.android.tools.lint.checks.infrastructure.TestLintRunner.runMode(TestLintRunner.kt:238)
	at com.android.tools.lint.checks.infrastructure.TestLintRunner.runMode(TestLintRunner.kt:220)
	at com.android.tools.lint.checks.infrastructure.TestLintRunner.runMode$default(TestLintRunner.kt:194)
	at com.android.tools.lint.checks.infrastructure.TestLintRunner.run(TestLintRunner.kt:131)
	at com.android.tools.lint.checks.infrastructure.TestLintTask.run(TestLintTask.java:1047)
	at com.vanniktech.lintrules.android.AnnotationOrderDetectorTest.suppressWarningsBeforeModule(AnnotationOrderDetectorTest.kt:503)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:108)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
	at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:40)
	at org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:60)
	at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:52)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
	at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94)
	at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker$2.run(TestWorker.java:176)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:129)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:100)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:60)
	at org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56)
	at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:113)
	at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:65)
	at worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69)
	at worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74)

Public failing test: AnnotationOrderDetectorTest#suppressWarningsBeforeModule in https://github.com/vanniktech/lint-rules/pull/424

Comments

sh...@gmail.com <sh...@gmail.com> #2Jul 3, 2023 03:15AM

To much slow

ak...@google.com <ak...@google.com> Jul 3, 2023 09:39AM

Assigned to an...@google.com.

js...@google.com <js...@google.com> #3Jul 3, 2023 06:59PM

Reassigned to tn...@google.com.

Likely from this line: https://cs.android.com/android-studio/platform/tools/base/+/mirror-goog-studio-main:lint/libs/lint-tests/src/main/java/com/android/tools/lint/checks/infrastructure/SuppressibleTestMode.kt;l=378;drc=f9c36e578a3ee73d04fa651d553287a90e5180c8

        val attributes = parameters.attributes
        ...
        val begin = attributes.first().startOffset

In addition to that one, there are a couple more first() and last() calls that are vulnerable to this kind of exception if, for some reasons, attributes is empty.

va...@gmail.com <va...@gmail.com> #4Sep 17, 2023 04:51PM

Still an issue with 31.1.1, when are you planning to fix this?

tn...@google.com <tn...@google.com> #5Sep 18, 2023 03:22PM

Here's the test file which triggers this bug:

    package foo;

    @Module @SuppressWarnings public interface MyModule {

The problem here is the @SuppressWarnings annotation; lint assumes it has arguments (which it should; the above code is invalid). Of course, lint should be working on the fly in the editor on broken source too, so I've uploaded a fix for this (ag/24790474), but I'm guessing the above wasn't intentional for the test case.

tn...@google.com <tn...@google.com> #6Sep 18, 2023 06:27PM

Marked as fixed.

Fixed by https://cs.android.com/android-studio/platform/tools/base/+/df22abc72064ee5cbf95e75a083f0e471fd90e15 for an upcoming Iguana canary. Thanks for the report!

an...@google.com <an...@google.com> #7Sep 21, 2023 09:04PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Iguana | 2023.2.1 Canary 5
Android Gradle Plugin 8.3.0-alpha05

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!