Fixed
Status Update
No update yet.
Comments
jb...@google.com
th...@gmail.com
Hi. Thanks for reporting this. Fixed in alpha-04
al...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
il...@google.com
deleted
ma...@sainsburysbank.co.uk
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit e579f23a7d1d45ab268b8e52efa58f7820426c74
Author: Clara Fok <clarafok@google.com>
Date: Fri Sep 22 14:47:57 2023
Fix double system back press with postponed Fragment container
Previously we identify system back press by tracking `transitionInProgress`. When popping a fragment where the incoming fragment has postponeEnterTransition, the outgoing fragment has a delayed completion and stays in transition longer. If this postponed incoming fragment is also popped at the same time (a double pop back to back), it will not get popped from NavController backstack by virtue of the previous outgoing entry still in transition.
Now we keep track of expected operations from FragmentManager by tracking entries that are already pushed/popped by NavController. We identify a system back press if we get a FragmentManager callback that we did not expect.
Test: ./gradlew navigation:navigation-fragment:cC
Bug: 289877514
Relnote: "Fixed issue where system back press results in incorrect currentDestination. Now the currentDestination correctly reflects the displayed Fragment after system back press."
Change-Id: Id0d6ca28ac2e6c8521784bf0bf569efee7a862dc
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
https://android-review.googlesource.com/2759780
Branch: androidx-main
commit e579f23a7d1d45ab268b8e52efa58f7820426c74
Author: Clara Fok <clarafok@google.com>
Date: Fri Sep 22 14:47:57 2023
Fix double system back press with postponed Fragment container
Previously we identify system back press by tracking `transitionInProgress`. When popping a fragment where the incoming fragment has postponeEnterTransition, the outgoing fragment has a delayed completion and stays in transition longer. If this postponed incoming fragment is also popped at the same time (a double pop back to back), it will not get popped from NavController backstack by virtue of the previous outgoing entry still in transition.
Now we keep track of expected operations from FragmentManager by tracking entries that are already pushed/popped by NavController. We identify a system back press if we get a FragmentManager callback that we did not expect.
Test: ./gradlew navigation:navigation-fragment:cC
Bug: 289877514
Relnote: "Fixed issue where system back press results in incorrect currentDestination. Now the currentDestination correctly reflects the displayed Fragment after system back press."
Change-Id: Id0d6ca28ac2e6c8521784bf0bf569efee7a862dc
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
cl...@google.com
Fixed internally and will be available in navigation 2.7.4
ma...@sainsburysbank.co.uk
Confirmed this fix works - thank you!
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-fragment:2.8.0-alpha01
cn...@gmail.com
Am still facing the same issue tried several methods no success so far wonder any work around this would be highly appreciated thanks
il...@google.com
Re
Description
Version used: 2.6
Devices/Android versions reproduced on: All
When using Navigation 2.6.0 There is an issue when poping backstack twice rapidely, for example if you have 3 fragments A, B, C with navigation from A to B and B to C, if you try to pop backstack quickly twice from fragment C you ending up to fragment A as expected but you current desination is fragment B instead of fragment A.
2.5.x is working without this issue.
Checked attched example