Fixed
Status Update
Comments
jb...@google.com <jb...@google.com>
th...@gmail.com <th...@gmail.com> #2
since these are in public API (:/) we need to do this in 1.2
al...@gmail.com <al...@gmail.com> #3
since it is already marked as deprecated, we can probably do it by now.
il...@google.com <il...@google.com> #4
Opening diff shortly
ma...@sainsburysbank.co.uk <ma...@sainsburysbank.co.uk> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit e579f23a7d1d45ab268b8e52efa58f7820426c74
Author: Clara Fok <clarafok@google.com>
Date: Fri Sep 22 14:47:57 2023
Fix double system back press with postponed Fragment container
Previously we identify system back press by tracking `transitionInProgress`. When popping a fragment where the incoming fragment has postponeEnterTransition, the outgoing fragment has a delayed completion and stays in transition longer. If this postponed incoming fragment is also popped at the same time (a double pop back to back), it will not get popped from NavController backstack by virtue of the previous outgoing entry still in transition.
Now we keep track of expected operations from FragmentManager by tracking entries that are already pushed/popped by NavController. We identify a system back press if we get a FragmentManager callback that we did not expect.
Test: ./gradlew navigation:navigation-fragment:cC
Bug: 289877514
Relnote: "Fixed issue where system back press results in incorrect currentDestination. Now the currentDestination correctly reflects the displayed Fragment after system back press."
Change-Id: Id0d6ca28ac2e6c8521784bf0bf569efee7a862dc
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
https://android-review.googlesource.com/2759780
Branch: androidx-main
commit e579f23a7d1d45ab268b8e52efa58f7820426c74
Author: Clara Fok <clarafok@google.com>
Date: Fri Sep 22 14:47:57 2023
Fix double system back press with postponed Fragment container
Previously we identify system back press by tracking `transitionInProgress`. When popping a fragment where the incoming fragment has postponeEnterTransition, the outgoing fragment has a delayed completion and stays in transition longer. If this postponed incoming fragment is also popped at the same time (a double pop back to back), it will not get popped from NavController backstack by virtue of the previous outgoing entry still in transition.
Now we keep track of expected operations from FragmentManager by tracking entries that are already pushed/popped by NavController. We identify a system back press if we get a FragmentManager callback that we did not expect.
Test: ./gradlew navigation:navigation-fragment:cC
Bug: 289877514
Relnote: "Fixed issue where system back press results in incorrect currentDestination. Now the currentDestination correctly reflects the displayed Fragment after system back press."
Change-Id: Id0d6ca28ac2e6c8521784bf0bf569efee7a862dc
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
cl...@google.com <cl...@google.com> #7
Fixed internally and will be available in navigation 2.7.4
ma...@sainsburysbank.co.uk <ma...@sainsburysbank.co.uk> #8
Confirmed this fix works - thank you!
na...@google.com <na...@google.com> #9
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-fragment:2.8.0-alpha01
cn...@gmail.com <cn...@gmail.com> #10
Am still facing the same issue tried several methods no success so far wonder any work around this would be highly appreciated thanks
il...@google.com <il...@google.com> #11
Re
Description
Version used: 2.6
Devices/Android versions reproduced on: All
When using Navigation 2.6.0 There is an issue when poping backstack twice rapidely, for example if you have 3 fragments A, B, C with navigation from A to B and B to C, if you try to pop backstack quickly twice from fragment C you ending up to fragment A as expected but you current desination is fragment B instead of fragment A.
2.5.x is working without this issue.
Checked attched example