Fixed
Status Update
Comments
jb...@google.com <jb...@google.com>
th...@gmail.com <th...@gmail.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
al...@gmail.com <al...@gmail.com> #3
il...@google.com <il...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ma...@sainsburysbank.co.uk <ma...@sainsburysbank.co.uk> #5
I've discovered this happens when navigation between fragments has an animation. Removing the animation the issue goes away.
This is present in version 2.7.2.
This seems to be an issue where `onDestinationChanged` is not being called correctly. This results in the fragment still half present, and especially obvious when the toolbar is set up with the nav controller.
This is present in version 2.7.2.
This seems to be an issue where `onDestinationChanged` is not being called correctly. This results in the fragment still half present, and especially obvious when the toolbar is set up with the nav controller.
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit e579f23a7d1d45ab268b8e52efa58f7820426c74
Author: Clara Fok <clarafok@google.com>
Date: Fri Sep 22 14:47:57 2023
Fix double system back press with postponed Fragment container
Previously we identify system back press by tracking `transitionInProgress`. When popping a fragment where the incoming fragment has postponeEnterTransition, the outgoing fragment has a delayed completion and stays in transition longer. If this postponed incoming fragment is also popped at the same time (a double pop back to back), it will not get popped from NavController backstack by virtue of the previous outgoing entry still in transition.
Now we keep track of expected operations from FragmentManager by tracking entries that are already pushed/popped by NavController. We identify a system back press if we get a FragmentManager callback that we did not expect.
Test: ./gradlew navigation:navigation-fragment:cC
Bug: 289877514
Relnote: "Fixed issue where system back press results in incorrect currentDestination. Now the currentDestination correctly reflects the displayed Fragment after system back press."
Change-Id: Id0d6ca28ac2e6c8521784bf0bf569efee7a862dc
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
https://android-review.googlesource.com/2759780
Branch: androidx-main
commit e579f23a7d1d45ab268b8e52efa58f7820426c74
Author: Clara Fok <clarafok@google.com>
Date: Fri Sep 22 14:47:57 2023
Fix double system back press with postponed Fragment container
Previously we identify system back press by tracking `transitionInProgress`. When popping a fragment where the incoming fragment has postponeEnterTransition, the outgoing fragment has a delayed completion and stays in transition longer. If this postponed incoming fragment is also popped at the same time (a double pop back to back), it will not get popped from NavController backstack by virtue of the previous outgoing entry still in transition.
Now we keep track of expected operations from FragmentManager by tracking entries that are already pushed/popped by NavController. We identify a system back press if we get a FragmentManager callback that we did not expect.
Test: ./gradlew navigation:navigation-fragment:cC
Bug: 289877514
Relnote: "Fixed issue where system back press results in incorrect currentDestination. Now the currentDestination correctly reflects the displayed Fragment after system back press."
Change-Id: Id0d6ca28ac2e6c8521784bf0bf569efee7a862dc
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
cl...@google.com <cl...@google.com> #7
Fixed internally and will be available in navigation 2.7.4
ma...@sainsburysbank.co.uk <ma...@sainsburysbank.co.uk> #8
Confirmed this fix works - thank you!
na...@google.com <na...@google.com> #9
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-fragment:2.8.0-alpha01
cn...@gmail.com <cn...@gmail.com> #10
Am still facing the same issue tried several methods no success so far wonder any work around this would be highly appreciated thanks
il...@google.com <il...@google.com> #11
Re
Description
Version used: 2.6
Devices/Android versions reproduced on: All
When using Navigation 2.6.0 There is an issue when poping backstack twice rapidely, for example if you have 3 fragments A, B, C with navigation from A to B and B to C, if you try to pop backstack quickly twice from fragment C you ending up to fragment A as expected but you current desination is fragment B instead of fragment A.
2.5.x is working without this issue.
Checked attched example