Navigation 2.6.0 doesn't set right current destination when poping backstack twice [289877514]

Fixed

Bug

Status Update

No update yet.

Description

sa...@gmail.com

created issue #1

Jul 4, 2023 05:23PM

Component used: Navigation
Version used: 2.6
Devices/Android versions reproduced on: All

When using Navigation 2.6.0 There is an issue when poping backstack twice rapidely, for example if you have 3 fragments A, B, C with navigation from A to B and B to C, if you try to pop backstack quickly twice from fragment C you ending up to fragment A as expected but you current desination is fragment B instead of fragment A.

2.5.x is working without this issue.

Checked attched example

Navigation26PopbackstackIssue.zip

19 MB

Download

Comments

jb...@google.com <jb...@google.com> Jul 5, 2023 03:32PM

Assigned to cl...@google.com.

th...@gmail.com <th...@gmail.com> #2Aug 17, 2023 01:27AM

Oh I forgot to mention that I thought it might be connected to this issue: https://issuetracker.google.com/issues/243778589. But after trying 2.5.2 I can say that the issue persists.

Message last modified on Aug 17, 2023 01:51AM

al...@gmail.com <al...@gmail.com> #3Aug 22, 2023 01:16PM

Please provide a minimal sample project along with the minimal steps to recreate the issue in the project.

il...@google.com <il...@google.com> #4Aug 30, 2023 08:29PM

Sorry for the delay. I got a working example here: https://github.com/Del-S/issues. The project is set up to crash when navigating to ThirdFragment (nested nav graph) with poping the graph.

I poked into it a little bit and it seems to be connected to SafeArgs gradle plugin. When safe args is used to navigate to ThirdFragment (with nested graph poped) it will try to recreate te parent but there were no arguments passed so it crashes.

Steps to reproduce:

Navigate from Second Fragment to Child nav graph (with non-nullable parameters).
Navigate to Third fragment using SafeArgs and the app crashes.

Crash log:

Process: cz.dels.issues, PID: 1743
java.lang.NullPointerException: null cannot be cast to non-null type kotlin.Long
at androidx.navigation.NavType$Companion$LongType$1.get(NavType.kt:352)
at androidx.navigation.NavType$Companion$LongType$1.get(NavType.kt:342)
at androidx.navigation.NavArgument.verify(NavArgument.kt:76)
at androidx.navigation.NavDestination.addInDefaultArgs(NavDestination.kt:502)
at androidx.navigation.NavController.addEntryToBackStack(NavController.kt:1865)
at androidx.navigation.NavController.addEntryToBackStack$default(NavController.kt:1813)
at androidx.navigation.NavController$navigate$4.invoke(NavController.kt:1721)
at androidx.navigation.NavController$navigate$4.invoke(NavController.kt:1719)
at androidx.navigation.NavController$NavControllerNavigatorState.push(NavController.kt:287)
at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:246)
at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:162)
at androidx.navigation.NavController.navigateInternal(NavController.kt:260)
at androidx.navigation.NavController.navigate(NavController.kt:1719)
at androidx.navigation.NavController.navigate(NavController.kt:1545)
at androidx.navigation.NavController.navigate(NavController.kt:1472)
at androidx.navigation.NavController.navigate(NavController.kt:1930)
at cz.dels.issues.SecondFragment.onViewCreated$lambda-0(SecondFragment.kt:38)
at cz.dels.issues.SecondFragment.$r8$lambda$XDYnOS_cYrafiNQ5rcCu1WCn0IE(Unknown Source:0)
at cz.dels.issues.SecondFragment$$ExternalSyntheticLambda0.onClick(Unknown Source:2)

Note: If in step 2 SaveArgs is not used then navigation works correctly. More information is here: https://github.com/Del-S/issues/blob/master/app/src/main/java/cz/dels/issues/SecondFragment.kt#L37.

ma...@sainsburysbank.co.uk <ma...@sainsburysbank.co.uk> #5Sep 7, 2023 08:04AM

Ups a typo: Navigate from ~~Second~~ First Fragment to Child nav graph (with non-nullable parameters).

Note: sorry for the spam but I am not able to edit my own comment.

Message last modified on Sep 7, 2023 08:10AM

ap...@google.com <ap...@google.com> #6Sep 26, 2023 07:20PM

This has been fixed and will be available in navigation 2.6.0-alpha08

cl...@google.com <cl...@google.com> #7Sep 26, 2023 08:23PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 6b358154b794a0456b089ac8e548bfb830dd6c22
Author: Clara Fok <clarafok@google.com>
Date: Tue Mar 14 17:56:12 2023

Fix missing non-nullable arg when rebuilding hierarchy

When navigating with NavDirections, args is populated with an empty bundle. This causes issue when we rebuild parent hierarchy while adding a new entry to NavBackStack. If the Entry being rebuilt contains a non-nullalbe arg, i.e. Long, this empty bundle will cause an exception.

Test: ./gradlew navigation:navigation-runtime:cC
Bug: 249988437
Change-Id: I5c8ce739ad9a3428c8a8de13eae391bfff0db5df

M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt

https://android-review.googlesource.com/2488855

ma...@sainsburysbank.co.uk <ma...@sainsburysbank.co.uk> #8Nov 23, 2023 02:29PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-runtime:2.6.0-alpha08

na...@google.com <na...@google.com> #9Jan 24, 2024 07:52PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.8.0-alpha01

cn...@gmail.com <cn...@gmail.com> #10May 11, 2024 08:26PM

Am still facing the same issue tried several methods no success so far wonder any work around this would be highly appreciated thanks

il...@google.com <il...@google.com> #11May 13, 2024 04:26PM

Re comment#10 - please file a new bug with a sample project that reproduces your problem.