Unable to assert updates on AndroidView using espresso in unit test [291094055]

Fixed

Bug

Status Update

No update yet.

Description

th...@google.com

created issue #1

Jul 13, 2023 04:46PM

I was unable to assert state change during unit test using espresso view matchers like so:

  @Test
  fun someTest() {
    composeRule.setContent {
      SomeComposable()
    }

    onView(withText(MY_TEXT)).check(matches(withEffectiveVisibility(VISIBLE)))
  }

where SomeComposable contains an AndroidView composable that has an update block depending on a state created inside the composable.

Example of when it doesn't work in unit test -- creating the state where the composable wraps around the AndroidView()

  @Composable
  fun SomeComposable(
    messageId: String,
  ) {
    val title by CreatesSomeState(messageId)
    AndroidView(
      factory = { context -> ...},
      update = { view ->
        view.apply {
          text = title
          ...
        }
      }
    )
   }

Example of when it does work -- pushing the state delegation to another composable and having the AndroidView-wrapping Composable only accept the final string returned from state

@Composable
fun AHigherLevelComposable(messageId: String) {
   val title by CreatesSomeState(messageId)
  SomeComposable(title)
}

@Composable
  fun SomeComposable(
    title: String,
  ) {
    AndroidView(
      factory = { context -> ...},
      update = { view ->
        view.apply {
          text = title
          ...
        }
      }
    )
  }

Comments

th...@google.com <th...@google.com> #2Jul 13, 2023 04:47PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

kl...@google.com <kl...@google.com> Jul 13, 2023 04:49PM

Accepted by kl...@google.com.

ap...@google.com <ap...@google.com> #3Jul 13, 2023 07:15PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 9e3c7fe79369a1f772438339bf86958eb99ee4f2
Author: Zach Klippenstein <klippenstein@google.com>
Date: Thu Jul 13 09:43:02 2023

Defer AndroidView update callback until view is attached.

The snapshot observer is only started when the view is attached, so if
we run the update callback before that, none of the state reads will be
observed.

This bug is not triggered in a test if the state is set by the test –
it's only triggered if the state is updated by an effect. Added a test
that does that and fails before this fix.

This is also technically more efficient, since it avoids running the
update callback if the view never becomes attached. I think it also
means we can use the Owner's SnapshotStateObserver instead of creating
our own, although I haven't made that change in this CL.

Fixes:

b/291094055

Test: AndroidViewTest.androidView_updateObservesStateChanges_fromEffect
Relnote: "`AndroidView`'s `update` callback's first invocation will now
be defered until the view is attached, instead of running when the
composition that introduces the `AndroidView` is applied. This fixes
a bug where the `update` callback wouldn't be invalidated if a state
it read was changed immediately by an effect."
Change-Id: Ie94381c17c417b4161d1531c9731a3b077ad46fb

M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/viewinterop/AndroidViewTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/viewinterop/AndroidViewHolder.android.kt

https://android-review.googlesource.com/2657055

na...@google.com <na...@google.com> #4Jul 26, 2023 05:21PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.ui:ui:1.6.0-alpha02
androidx.compose.ui:ui-android:1.6.0-alpha02

Issue 291094055

Description

Issue summary

Comments

th...@google.com <th...@google.com> #2Jul 13, 2023 04:47PM

kl...@google.com <kl...@google.com> Jul 13, 2023 04:49PM

ap...@google.com <ap...@google.com> #3Jul 13, 2023 07:15PM

na...@google.com <na...@google.com> #4Jul 26, 2023 05:21PM

Add comment

Issue metadata