[Lint] TranslucentViewDetector crashes in filterIncident function and causes lint to produce wrong result [291319992]

Fixed

Bug

Status Update

No update yet.

Description

ko...@gmail.com

created issue #1

Jul 16, 2023 10:43AM

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:

I cannot reproduce this issue outside of our repo and here is what I know from my investigation.
project.allLibraries is a NonNull function. The code shouldn't produce null value.
To be able to debug, I copied the same rule into our project. I added two println(context.project.allLibraries) before context.getLocation(attr, LocationType.VALUE) call. They print the expected project list and more importantly, the following call to getLocation does NOT crash.

I resolved our issue by inlining the rule and calling allProject.

Exception in filterIncident causes https://issuetracker.google.com/issues/291446497.

TranslucentViewDetector should not throw an exception when context.getLocation(attr, LocationType.VALUE) is called.
I expect an exception in filterIncident to fail the lint run.

java.lang.NullPointerException: project.allLibraries must not be null
        at com.android.tools.lint.detector.api.Context.findNodeInProject(Context.kt:324)
        at com.android.tools.lint.detector.api.Context.getLocation(Context.kt:247)
        at com.roadrunner.lint.checks.TranslucentViewDetector.filterIncident(TranslucentViewDetector.kt:201)
        at com.android.tools.lint.client.api.LintDriver.mergeConditionalIncidents(LintDriver.kt:713)
        at com.android.tools.lint.LintCliClient.mergeIncidents(LintCliClient.kt:695)
        at com.android.tools.lint.LintCliClient.mergeState(LintCliClient.kt:595)
        at com.android.tools.lint.client.api.LintDriver$LintClientWrapper.mergeState(LintDriver.kt:3020)
        at com.android.tools.lint.client.api.LintDriver$mergeOnly$1.invoke(LintDriver.kt:491)
        at com.android.tools.lint.client.api.LintDriver$mergeOnly$1.invoke(LintDriver.kt:486)
        at com.android.tools.lint.client.api.LintDriver.doAnalyze(LintDriver.kt:530)
        at com.android.tools.lint.client.api.LintDriver.doAnalyze$default(LintDriver.kt:501)
        at com.android.tools.lint.client.api.LintDriver.mergeOnly(LintDriver.kt:486)
        at com.android.tools.lint.LintCliClient$mergeOnly$1.invoke(LintCliClient.kt:261)
        at com.android.tools.lint.LintCliClient$mergeOnly$1.invoke(LintCliClient.kt:259)
        at com.android.tools.lint.LintCliClient.run(LintCliClient.kt:289)
        at com.android.tools.lint.LintCliClient.mergeOnly(LintCliClient.kt:259)
        at com.android.tools.lint.Main.run(Main.java:1670)
        at com.android.tools.lint.Main.run(Main.java:274)
        at jdk.internal.reflect.GeneratedMethodAccessor1468.invoke(Unknown Source)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)
        at com.android.build.gradle.internal.lint.AndroidLintWorkAction.invokeLintMainRunMethod(AndroidLintWorkAction.kt:98)
        at com.android.build.gradle.internal.lint.AndroidLintWorkAction.runLint(AndroidLintWorkAction.kt:87)
        at com.android.build.gradle.internal.lint.AndroidLintWorkAction.execute(AndroidLintWorkAction.kt:62)
        at org.gradle.workers.internal.DefaultWorkerServer.execute(DefaultWorkerServer.java:63)
        at org.gradle.workers.internal.NoIsolationWorkerFactory$1$1.create(NoIsolationWorkerFactory.java:66)
        at org.gradle.workers.internal.NoIsolationWorkerFactory$1$1.create(NoIsolationWorkerFactory.java:62)
        at org.gradle.internal.classloader.ClassLoaderUtils.executeInClassloader(ClassLoaderUtils.java:100)
        at org.gradle.workers.internal.NoIsolationWorkerFactory$1.lambda$execute$0(NoIsolationWorkerFactory.java:62)
        at org.gradle.workers.internal.AbstractWorker$1.call(AbstractWorker.java:44)
        at org.gradle.workers.internal.AbstractWorker$1.call(AbstractWorker.java:41)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)
        at org.gradle.workers.internal.AbstractWorker.executeWrappedInBuildOperation(AbstractWorker.java:41)
        at org.gradle.workers.internal.NoIsolationWorkerFactory$1.execute(NoIsolationWorkerFactory.java:59)
        at org.gradle.workers.internal.DefaultWorkerExecutor.lambda$submitWork$0(DefaultWorkerExecutor.java:169)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.runExecution(DefaultConditionalExecutionQueue.java:187)
        at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.access$700(DefaultConditionalExecutionQueue.java:120)
        at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner$1.run(DefaultConditionalExecutionQueue.java:162)
        at org.gradle.internal.Factories$1.create(Factories.java:31)
        at org.gradle.internal.work.DefaultWorkerLeaseService.withLocks(DefaultWorkerLeaseService.java:249)
        at org.gradle.internal.work.DefaultWorkerLeaseService.runAsWorkerThread(DefaultWorkerLeaseService.java:109)
        at org.gradle.internal.work.DefaultWorkerLeaseService.runAsWorkerThread(DefaultWorkerLeaseService.java:114)
        at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.runBatch(DefaultConditionalExecutionQueue.java:157)
        at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.run(DefaultConditionalExecutionQueue.java:126)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
        at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:49)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
        at java.base/java.lang.Thread.run(Thread.java:833)

Version of Gradle Plugin: 8.0.2 Version of Gradle: 8 Version of Java: 17 OS: Mac

Comments

lu...@google.com <lu...@google.com> Jul 18, 2023 09:55AM

Assigned to an...@google.com.

ya...@google.com <ya...@google.com> Aug 16, 2023 07:10PM

Status: New

tn...@google.com <tn...@google.com> #2Aug 21, 2023 07:02PM

Marked as fixed, reassigned to tn...@google.com.

I can reproduce this (thanks for the repro project!)

It looks like the problem is that the desugared api list from r8 contains this entry:

java/util/Collection#removeIf(Ljava/util/function/Predicate;)Z

but the bytecode here doesn't match -- it's java/util/ArrayList. Collection isn't a directly implemented interface or a direct super class, it's an interface on the super super class. The most efficient thing runtime wise would be for the signature list to inline this method on all implemented subclasses. But I should probably at least for now go and make the desugared API lookup do something similar to what it does for API lookup -- search through all super classes and interfaces as well. This isn't a new problem, so I'm very surprised this hasn't come up before (or it has, and I've forgotten).

ko...@gmail.com <ko...@gmail.com> #3Aug 22, 2023 05:20PM

(I have a pending CL that was working to improve the handling of fields now that r8 handles desugaring fields, I'll try to dust that off and combine the fix in there.)

Issue 291319992

Description

Issue summary

Comments

lu...@google.com <lu...@google.com> Jul 18, 2023 09:55AM

ya...@google.com <ya...@google.com> Aug 16, 2023 07:10PM

tn...@google.com <tn...@google.com> #2Aug 21, 2023 07:02PM

ko...@gmail.com <ko...@gmail.com> #3Aug 22, 2023 05:20PM

Add comment

Issue metadata