Material3 for compose does not allow us to create a state object for the Date Picker `DatePickerState` outside of composition [291524052]

Fixed

Bug

Status Update

No update yet.

Description

st...@gmail.com

created issue #1

Jul 17, 2023 01:32PM

Jetpack Compose version: 1.2.0-alpha03
Jetpack Compose component used: androidx.compose.material3:material3
Android Studio Build: N/A
Kotlin version: N/A

DatePickerState used to be a public class, now in 1.2.x it is an interface. Before I was constructing an instance of this class in a state holding class (as described in the docs https://developer.android.com/jetpack/compose/state#managing-state) Now I can no longer do that, since DatePickerStateImpl is private, and the only exposed way to construct one with the rememberDatePickerState(), which is a composable function.

I feel like it should not only be possible to construct those state objects in composition. Hoisting this state into my own state holder has been super useful to be able to control the state there, and have the composables themselves use the state as it is, without constructing it and dealing with logic like which dates are allowed etc. and simply emit the UI as it should be.

Can this scenario please be considered? The docs that I linked above even are the ones who promote the idea of having these state holders, so the material3 library disallowing it for specifically the date picker component feels quite out of place.

Comments

st...@gmail.com <st...@gmail.com> #2Jul 21, 2023 09:13PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

Message last modified on Jul 21, 2023 09:26PM

st...@gmail.com <st...@gmail.com> #3Sep 20, 2023 08:55PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

sg...@google.com <sg...@google.com> Sep 21, 2023 07:13AM

Reassigned to sg...@google.com.

sg...@google.com <sg...@google.com> Sep 21, 2023 01:29PM

Accepted by sg...@google.com.

ap...@google.com <ap...@google.com> #4Sep 21, 2023 06:04PM

Project: platform/frameworks/support
Branch: androidx-main

commit 05edc3f3f48149fac2bdf6a761c92fd50f5b304c
Author: Shalom Gibly <sgibly@google.com>
Date: Thu Sep 21 06:31:52 2023

Adds functions for creating date picker states

Adds non-composable functions for creating a DatePickerState and a
DateRangePickerState.

Bug: 291524052
Test: DatePickerTest and RangeRangePickerTest
Relnote: "Non-Composable functions have been added for creating a
DatePickerState and DateRangePickerState directly. These funcions can be
used as an alternative to the Composable rememberDatePickerState and
rememberDateRangePickerState functions when needed."

Change-Id: I703262a5a9d3e87da82adf1c9993b462cd8d941a

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/DatePickerTest.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/DateRangePickerTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/DatePicker.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/DateRangePicker.kt

https://android-review.googlesource.com/2759465

sg...@google.com <sg...@google.com> Sep 21, 2023 06:15PM

Marked as fixed.

st...@gmail.com <st...@gmail.com> #5Sep 21, 2023 06:34PM

Thank you!!!

sg...@google.com <sg...@google.com> #6Sep 22, 2023 08:25AM

Thank you for nudging us on this! :)