Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit ec65efaf307154df9183a3c35d4dc265bf600bae
Author: Chris Craik <ccraik@google.com>
Date: Mon Jul 24 16:04:22 2023
Reduce strictness of profileable checks
Fixes: 291722507
Test: TrivialStartupBenchmark on userdebug device, with profileable tag removed (still works)
Test: TrivialStartupBenchmark on user device, with profileable tag removed, method tracing enabled (still works)
Relnote: "Removed macrobenchmark NOT-PROFILEABLE error on API 31+, and
skip profileable check on eng/userdebug rooted devices."
Also slightly rewords debuggable/profileable error messages.
Change-Id: I2abac3fea3fb6eec37c50c774d7fe034abe6bc18
M benchmark/benchmark-common/src/main/java/androidx/benchmark/DeviceInfo.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Errors.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Macrobenchmark.kt
https://android-review.googlesource.com/2674124
Branch: androidx-main
commit ec65efaf307154df9183a3c35d4dc265bf600bae
Author: Chris Craik <ccraik@google.com>
Date: Mon Jul 24 16:04:22 2023
Reduce strictness of profileable checks
Fixes: 291722507
Test: TrivialStartupBenchmark on userdebug device, with profileable tag removed (still works)
Test: TrivialStartupBenchmark on user device, with profileable tag removed, method tracing enabled (still works)
Relnote: "Removed macrobenchmark NOT-PROFILEABLE error on API 31+, and
skip profileable check on eng/userdebug rooted devices."
Also slightly rewords debuggable/profileable error messages.
Change-Id: I2abac3fea3fb6eec37c50c774d7fe034abe6bc18
M benchmark/benchmark-common/src/main/java/androidx/benchmark/DeviceInfo.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Errors.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Macrobenchmark.kt
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-common:1.2.0-beta03androidx.benchmark:benchmark-macro:1.2.0-beta03
Description
Component used: macrobenchmark 1.2.0-alpha16 Devices/Android versions reproduced on: pixel 6 api 33 userdebug
When running benchmarks on userdebug build on an app that isn't
<profileable />, macrobenchmark fails with theNOT-PROFILEABLEerror and you need to suppress it.On userdebug builds though, it shouldn't complain at all as the app can be profiled anyway.