Status Update
No update yet.
Comments
lo...@gmail.com
I also encounter this issue. Additionally, I also noticed that the Dialog composable is broken too when using this setup. However, in the case of the Dialog, sometimes the adjustment to the rotation works, but sometimes not.
ju...@telesoftas.com
+1
h9...@drdiary.co.kr
+1
ma...@google.com
ke...@google.com
ap...@google.com
Branch: androidx-main
commit ca9123c5ec83d3536a70d1ffbc890f195068fc77
Author: Kevin Truong <kevinctruong@google.com>
Date: Mon Sep 11 16:43:12 2023
[BottomSheet] Recreate Modal BottomSheet on configuration change
Adding the configuration as a remember key to ModalBottomSheetWindow, so that we'll recreate the modal bottom sheet correctly on configuration change.
Bug: 292204649
Test: Adding a modal bottom sheet test to ensure that the bottom sheet is matching the width of the screen even when it's changed via the configuration.
Change-Id: I3b0ace1747417b368feef3e1fc8bf5b39261f4b2
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
ke...@google.com
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.2.0-alpha08androidx.compose.material3:material3-android:1.2.0-alpha08
di...@zillowgroup.com
va...@google.com
va...@google.com
to...@gmail.com
Can confirm it's present in M3 1.3 alpha 2
dh...@sky.uk
se...@google.com
What devices did you use to replicate this behavior.
ve...@gmail.com
st...@gmail.com
The fact that this was fixed and then reverted back to be broken again is at least a little bit funny 😄 Is there a plan for this to be re-reverted to be fixed again, or is it perhaps fixed again in some future Alpha which we can try? Was the fix reverted because it was introducing some other unrelated problem which is yet to be addressed?
se...@google.com
This was underlying issues with popup window behaviors. The latest beta includes a dialog implementation which should appropriately resize with configuration changes.
to...@gmail.com
Anyway to have a statement about
sn...@gmail.com
```
if (configuration.orientation == Configuration.ORIENTATION_LANDSCAPE) { ModalBottomSheet(...) { Content() } }
else { ModalBottomSheet(...) { Content() } } // the very same ModalBottomSheet as in the first clause
```
Google, I am open for hire, by the way.
Description
Jetpack Compose version:
androidx.compose.material3:material3:1.1.1(BOM 2023.06.01)Jetpack Compose component used:
androidx.compose.material3:material3Android Studio Build: N/A
Kotlin version: N/A
Steps to Reproduce or Code Sample to Reproduce:
android:configChanges="keyboard|keyboardHidden|orientation|screenSize|screenLayout"andandroid:windowSoftInputMode="adjustResize"The first two screenshots show how it looks like when you first open it on landscape mode (looks ok) and then rotate to portrait mode. And the third and fourth screenshot show how it looks like when you first open it in portrait mode (looks ok) and then how it looks like when you rotate your device.