Make Shapes library more Compose-compatible [292289543]

Fixed

Bug

Status Update

No update yet.

Description

ch...@google.com

created issue #1

Jul 21, 2023 10:56PM

The Shapes library uses a handle of Android-specific types (Canvas, Path, PointF, Matrix, and RectF). Compose requires libraries that it uses (which it would like add Shapes to) to be KMP-friendly, using non-android-specific types.
We should change Shapes to remove the Android-isms. potentially by using the existing abstractions that Compose already has for these types (same names, except PointF -> Offset)

Comments

ap...@google.com <ap...@google.com> #2Aug 23, 2023 02:12PM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

ap...@google.com <ap...@google.com> #3Aug 23, 2023 10:51PM

Great! Thanks a lot, I'll look for the live updates soon!

ap...@google.com <ap...@google.com> #4Aug 29, 2023 09:33PM

Project: platform/frameworks/support
Branch: androidx-main

commit a7179016de19a696fcb03d420cbdfd0f62227eb0
Author: Chet Haase <chet@google.com>
Date: Thu Aug 24 08:19:20 2023

Add Android-specific APIs to KMP shapes library

This CL adds utility APIs on top of the core shapes API which
makes it easier to size/position and draw these shapes.

Bug: 292289543
Test: unit and regression tests pass
Relnote: Adding Android-specific transform and drawing APIs

Change-Id: I079f6f0cbfef6d4496bff858fb659be206d78988

M graphics/graphics-shapes/api/current.txt
M graphics/graphics-shapes/api/restricted_current.txt
A graphics/graphics-shapes/src/androidMain/kotlin/androidx/graphics/shapes/Android.kt
D graphics/integration-tests/testapp/src/main/java/androidx/graphics/shapes/test/Android.kt
A graphics/integration-tests/testapp/src/main/java/androidx/graphics/shapes/test/MorphView.kt
M graphics/integration-tests/testapp/src/main/java/androidx/graphics/shapes/test/ShapeActivity.kt
M graphics/integration-tests/testapp/src/main/java/androidx/graphics/shapes/test/ShapeView.kt

https://android-review.googlesource.com/2725255

ch...@google.com <ch...@google.com> #5Aug 31, 2023 01:07AM

Marked as fixed.

There may be more to do here when Compose writes code on top of the library; we will make any necessary API adjustments at that time, since that was the whole reason behind this KMP-ification.
Meanwhile, marking this bug closed, since the changes above are the ones we set out to do for the purpose of making it work better for Compose. Open new bugs as appropriate for specific issues which arise.

na...@google.com <na...@google.com> #6Dec 13, 2023 06:33PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.graphics:graphics-shapes:1.0.0-alpha04

al...@gmail.com <al...@gmail.com> #7Jan 22, 2025 01:55PM

Ah, I get it—breaking free from Android-specific types to make Shapes KMP-friendly sounds like a solid move! Swapping those Android-isms for Compose's abstractions feels like a cleaner, future-proof approach. Just like creating versatile graphics solutions—

https://iconicsgraphics.com/ comes to mind for their adaptable services—this shift will definitely help with cross-platform harmony. Good luck with the refactor!

Issue 292289543