Fixed
Status Update
Comments
st...@google.com <st...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 4a1e1666fc9e7106593766f2935605d8ee107f81
Author: Ankit <ankitikna@google.com>
Date: Wed Aug 23 11:56:45 2023
SwipeToReveal with EdgeSwipeToDismiss
`Modifier.edgeSwipeToDismiss` works with scrollable by intercepting
the scroll and fling events and sending them to SwipeToDismissBox
before the child node consumes it. However, SwipeToReveal depends
upon swipeable modifier which is a draggable modifier which does
not emit scroll/fling events. To enable edge swipe with SwipeToReveal
a `NestedScrollDispatcher` is required to dispatch the drag events
as scroll/fling event.
Relnote: """
Add NestedScrollDispatcher with SwipeToReveal which can be used with
Modifier.edgeSwipeToDismiss.
"""
Bug: 293444286
Bug: 293436983
Test: Manual testing
Change-Id: I95774a7df008db12756215dc8a064001008103c5
M wear/compose/compose-foundation/src/androidTest/kotlin/androidx/wear/compose/foundation/SwipeToRevealTest.kt
M wear/compose/compose-foundation/src/androidTest/kotlin/androidx/wear/compose/foundation/SwipeableV2Test.kt
M wear/compose/compose-foundation/src/main/java/androidx/wear/compose/foundation/SwipeToReveal.kt
M wear/compose/compose-foundation/src/main/java/androidx/wear/compose/foundation/SwipeableV2.kt
M wear/compose/integration-tests/demos/src/main/java/androidx/wear/compose/integration/demos/FoundationDemos.kt
M wear/compose/integration-tests/demos/src/main/java/androidx/wear/compose/integration/demos/SwipeToRevealDemo.kt
https://android-review.googlesource.com/2722537
Branch: androidx-main
commit 4a1e1666fc9e7106593766f2935605d8ee107f81
Author: Ankit <ankitikna@google.com>
Date: Wed Aug 23 11:56:45 2023
SwipeToReveal with EdgeSwipeToDismiss
`Modifier.edgeSwipeToDismiss` works with scrollable by intercepting
the scroll and fling events and sending them to SwipeToDismissBox
before the child node consumes it. However, SwipeToReveal depends
upon swipeable modifier which is a draggable modifier which does
not emit scroll/fling events. To enable edge swipe with SwipeToReveal
a `NestedScrollDispatcher` is required to dispatch the drag events
as scroll/fling event.
Relnote: """
Add NestedScrollDispatcher with SwipeToReveal which can be used with
Modifier.edgeSwipeToDismiss.
"""
Bug: 293444286
Bug: 293436983
Test: Manual testing
Change-Id: I95774a7df008db12756215dc8a064001008103c5
M wear/compose/compose-foundation/src/androidTest/kotlin/androidx/wear/compose/foundation/SwipeToRevealTest.kt
M wear/compose/compose-foundation/src/androidTest/kotlin/androidx/wear/compose/foundation/SwipeableV2Test.kt
M wear/compose/compose-foundation/src/main/java/androidx/wear/compose/foundation/SwipeToReveal.kt
M wear/compose/compose-foundation/src/main/java/androidx/wear/compose/foundation/SwipeableV2.kt
M wear/compose/integration-tests/demos/src/main/java/androidx/wear/compose/integration/demos/FoundationDemos.kt
M wear/compose/integration-tests/demos/src/main/java/androidx/wear/compose/integration/demos/SwipeToRevealDemo.kt
an...@google.com <an...@google.com>
na...@google.com <na...@google.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.wear.compose:compose-foundation:1.3.0-alpha06
Description
SwipeToReveal
component is preventing the swipe gesture to navigate back from a screen using aSwipeToDismissBox
.Same behaviour is observed when applying the modifier
edgeSwipeToDismiss
toSwipeToReveal
.SwipeToReveal
andModifier.edgeSwipeToDismiss
If this is a bug in the library, we would appreciate if you could attach:
Please see attached.