Verified
Status Update
No update yet.
Comments
ar...@google.com
an...@airbnb.com
This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.
ri...@google.com
ch...@google.com
Almost 2 months later and this is still broken
an...@airbnb.com
Since there is no progression, I wanted to share our quick-fix for the issue.
#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages
#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages
ch...@google.com
jb...@google.com What is the update on this?
ch...@google.com
What is the status of this item?
an...@airbnb.com
This has been fixed on master today (internal ref: ag/2945015) and will be available in the next SDK release.
ch...@google.com
Any ETA on next release?
ch...@google.com
Still broken and not updated? --package_file argument is not usable in it's current form on 26.1.1 straight from the developer site.
ap...@google.com
Comfirmed that this seems to still be broken. Can we have an update please?
```
(15:58:11) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --version
26.1.1
(15:58:17) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --install --package_file=package_file
Warning: Unknown argument --package_file=package_file
```
```
(15:58:11) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --version
26.1.1
(15:58:17) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --install --package_file=package_file
Warning: Unknown argument --package_file=package_file
```
ap...@google.com
Hi, is there any update to this issue? Thanks.
ap...@google.com
Hi Google. You claim it's been fixed on master, but we haven't had a new release since the broken version 26.1.1. Can you please release the fix?
ap...@google.com
Yeah, still not fixed --'
ap...@google.com
Can't believe this still isn't fixed 2 years later for a command line utility that sits on the main dev site.
ap...@google.com
Any updates on this? The help for this command clearly states this argument is supported.
ap...@google.com
Has anyone re-tried it?
We switched back to RUN sdkmanager --package_file=$ANDROID_HOME/packages.txt in our Dockerfile back in March of 2021.
ap...@google.com
For what it's worth, I did a quick test with the latest CLI: 11076708 (
./sdkmanager --sdk_root="../sdk" --package_file=deps.txt
Deps.txt:
platform-tools
extras;google;instantapps
build-tools;35.0.0-rc3
So perhaps this is now resolved? I haven't tried it with more packages
ap...@google.com
Project: r8
Branch: 8.2
commit 937b41f403fd2972f9e74a1441b40e4c99c34657
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 10:39:02 2023
Only allow instances of final classes in filled-new-array
Bug:
Change-Id: I0554aaaba74509a5afff9147ba11e6cfd68c7e14
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/test/java/com/android/tools/r8/workaround/FilledNewArrayFromSubtypeWithMissingInterfaceWorkaroundTest.java
https://r8-review.googlesource.com/82322
Branch: 8.2
commit 937b41f403fd2972f9e74a1441b40e4c99c34657
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 10:39:02 2023
Only allow instances of final classes in filled-new-array
Bug:
Change-Id: I0554aaaba74509a5afff9147ba11e6cfd68c7e14
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/test/java/com/android/tools/r8/workaround/FilledNewArrayFromSubtypeWithMissingInterfaceWorkaroundTest.java
ap...@google.com
Project: r8
Branch: 8.2
commit bd0c69e00cf701477bce85095a3f15f544692c2f
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 10:38:51 2023
Reproduce error from filled-new-array with subtype and missing interface
Bug:
Change-Id: I128ca78d97d5893722b857714f51364e69897186
M src/test/java/com/android/tools/r8/Dex2OatTestRunResult.java
A src/test/java/com/android/tools/r8/workaround/FilledNewArrayFromSubtypeWithMissingInterfaceWorkaroundTest.java
https://r8-review.googlesource.com/82282
Branch: 8.2
commit bd0c69e00cf701477bce85095a3f15f544692c2f
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 10:38:51 2023
Reproduce error from filled-new-array with subtype and missing interface
Bug:
Change-Id: I128ca78d97d5893722b857714f51364e69897186
M src/test/java/com/android/tools/r8/Dex2OatTestRunResult.java
A src/test/java/com/android/tools/r8/workaround/FilledNewArrayFromSubtypeWithMissingInterfaceWorkaroundTest.java
ap...@google.com
Project: r8
Branch: 8.2
commit b44cd016482f23c7ea9309d1c3f05fc982300b91
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 10:38:39 2023
Avoid conflating register sets at move-exception
In-resolution moves to a move-exception instruction cannot be inserted before the move-exception instruction.
Previously, we worked around this by adding the in-resolution moves to a move-exception instruction as in-resolution moves to the goto instruction that is always after the move-exception instruction (since catch handlers are split blocks).
The in-resolution moves to the move-exception instruction must be inserted before any of the in-resolution moves to the goto instruction, however. By conflating the two in-resolution move sets, the subsequent parallel move scheduling may incorrectly reorder two moves.
Example: Consider that the in-resolution moves for the move-exception instruction is the set { move r11, r3 } and the in-resolution moves for the goto instruction is the set { move r1, r11 }.
The instructions must be laid out in sequence as:
move r11, r3
move r1, r11
When the two sets are conflated as { move r11, r3; move r1, r11 }, parallel move scheduling will instead layout the moves as follows, which may lead to arbitrary errors:
move r1, r11
move r11, r3
Fix: Instead of conflating the two in-resolution move sets, this CL simply inserts the in-resolution moves for the move-exception instruction immediately after the move-exception instruction.
Bug:
Change-Id: I3975902ce63fb1f03914441c7c7357c839ff8a74
M src/main/java/com/android/tools/r8/ir/regalloc/LinearScanRegisterAllocator.java
M src/main/java/com/android/tools/r8/ir/regalloc/SpillMoveSet.java
https://r8-review.googlesource.com/82281
Branch: 8.2
commit b44cd016482f23c7ea9309d1c3f05fc982300b91
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 10:38:39 2023
Avoid conflating register sets at move-exception
In-resolution moves to a move-exception instruction cannot be inserted before the move-exception instruction.
Previously, we worked around this by adding the in-resolution moves to a move-exception instruction as in-resolution moves to the goto instruction that is always after the move-exception instruction (since catch handlers are split blocks).
The in-resolution moves to the move-exception instruction must be inserted before any of the in-resolution moves to the goto instruction, however. By conflating the two in-resolution move sets, the subsequent parallel move scheduling may incorrectly reorder two moves.
Example: Consider that the in-resolution moves for the move-exception instruction is the set { move r11, r3 } and the in-resolution moves for the goto instruction is the set { move r1, r11 }.
The instructions must be laid out in sequence as:
move r11, r3
move r1, r11
When the two sets are conflated as { move r11, r3; move r1, r11 }, parallel move scheduling will instead layout the moves as follows, which may lead to arbitrary errors:
move r1, r11
move r11, r3
Fix: Instead of conflating the two in-resolution move sets, this CL simply inserts the in-resolution moves for the move-exception instruction immediately after the move-exception instruction.
Bug:
Change-Id: I3975902ce63fb1f03914441c7c7357c839ff8a74
M src/main/java/com/android/tools/r8/ir/regalloc/LinearScanRegisterAllocator.java
M src/main/java/com/android/tools/r8/ir/regalloc/SpillMoveSet.java
ap...@google.com
Project: r8
Branch: 8.2
commit e5053eb5908dae15c3c090aa097982d1172639e1
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 10:39:14 2023
Version 8.2.22
Bug:
Change-Id: I1e59e6fb494a79a9961a2a8a86add05519f2c6f9
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/82283
Branch: 8.2
commit e5053eb5908dae15c3c090aa097982d1172639e1
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 10:39:14 2023
Version 8.2.22
Bug:
Change-Id: I1e59e6fb494a79a9961a2a8a86add05519f2c6f9
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com
Project: r8
Branch: 8.1
commit 964ccac8e5b4a5712a6dc505f4a3d21e5d4c54b0
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 10:50:08 2023
Reproduce error from filled-new-array with subtype and missing interface
Bug:
Change-Id: I128ca78d97d5893722b857714f51364e69897186
M src/test/java/com/android/tools/r8/Dex2OatTestRunResult.java
A src/test/java/com/android/tools/r8/workaround/FilledNewArrayFromSubtypeWithMissingInterfaceWorkaroundTest.java
https://r8-review.googlesource.com/82324
Branch: 8.1
commit 964ccac8e5b4a5712a6dc505f4a3d21e5d4c54b0
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 10:50:08 2023
Reproduce error from filled-new-array with subtype and missing interface
Bug:
Change-Id: I128ca78d97d5893722b857714f51364e69897186
M src/test/java/com/android/tools/r8/Dex2OatTestRunResult.java
A src/test/java/com/android/tools/r8/workaround/FilledNewArrayFromSubtypeWithMissingInterfaceWorkaroundTest.java
ap...@google.com
Project: r8
Branch: 8.1
commit 77fb862cd612fe3a7cb0f4aa35b3ee4003bcd12e
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 10:49:55 2023
Avoid conflating register sets at move-exception
In-resolution moves to a move-exception instruction cannot be inserted before the move-exception instruction.
Previously, we worked around this by adding the in-resolution moves to a move-exception instruction as in-resolution moves to the goto instruction that is always after the move-exception instruction (since catch handlers are split blocks).
The in-resolution moves to the move-exception instruction must be inserted before any of the in-resolution moves to the goto instruction, however. By conflating the two in-resolution move sets, the subsequent parallel move scheduling may incorrectly reorder two moves.
Example: Consider that the in-resolution moves for the move-exception instruction is the set { move r11, r3 } and the in-resolution moves for the goto instruction is the set { move r1, r11 }.
The instructions must be laid out in sequence as:
move r11, r3
move r1, r11
When the two sets are conflated as { move r11, r3; move r1, r11 }, parallel move scheduling will instead layout the moves as follows, which may lead to arbitrary errors:
move r1, r11
move r11, r3
Fix: Instead of conflating the two in-resolution move sets, this CL simply inserts the in-resolution moves for the move-exception instruction immediately after the move-exception instruction.
Bug:
Change-Id: I3975902ce63fb1f03914441c7c7357c839ff8a74
M src/main/java/com/android/tools/r8/ir/regalloc/LinearScanRegisterAllocator.java
M src/main/java/com/android/tools/r8/ir/regalloc/SpillMoveSet.java
https://r8-review.googlesource.com/82323
Branch: 8.1
commit 77fb862cd612fe3a7cb0f4aa35b3ee4003bcd12e
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 10:49:55 2023
Avoid conflating register sets at move-exception
In-resolution moves to a move-exception instruction cannot be inserted before the move-exception instruction.
Previously, we worked around this by adding the in-resolution moves to a move-exception instruction as in-resolution moves to the goto instruction that is always after the move-exception instruction (since catch handlers are split blocks).
The in-resolution moves to the move-exception instruction must be inserted before any of the in-resolution moves to the goto instruction, however. By conflating the two in-resolution move sets, the subsequent parallel move scheduling may incorrectly reorder two moves.
Example: Consider that the in-resolution moves for the move-exception instruction is the set { move r11, r3 } and the in-resolution moves for the goto instruction is the set { move r1, r11 }.
The instructions must be laid out in sequence as:
move r11, r3
move r1, r11
When the two sets are conflated as { move r11, r3; move r1, r11 }, parallel move scheduling will instead layout the moves as follows, which may lead to arbitrary errors:
move r1, r11
move r11, r3
Fix: Instead of conflating the two in-resolution move sets, this CL simply inserts the in-resolution moves for the move-exception instruction immediately after the move-exception instruction.
Bug:
Change-Id: I3975902ce63fb1f03914441c7c7357c839ff8a74
M src/main/java/com/android/tools/r8/ir/regalloc/LinearScanRegisterAllocator.java
M src/main/java/com/android/tools/r8/ir/regalloc/SpillMoveSet.java
ap...@google.com
Project: r8
Branch: 8.1
commit 439b2606165d2a4903d80b4fab96dcb90ab095bb
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 11:21:25 2023
Only allow instances of final classes in filled-new-array
Bug:
Change-Id: I0554aaaba74509a5afff9147ba11e6cfd68c7e14
M src/main/java/com/android/tools/r8/ir/optimize/CodeRewriter.java
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/test/java/com/android/tools/r8/workaround/FilledNewArrayFromSubtypeWithMissingInterfaceWorkaroundTest.java
https://r8-review.googlesource.com/82340
Branch: 8.1
commit 439b2606165d2a4903d80b4fab96dcb90ab095bb
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 11:21:25 2023
Only allow instances of final classes in filled-new-array
Bug:
Change-Id: I0554aaaba74509a5afff9147ba11e6cfd68c7e14
M src/main/java/com/android/tools/r8/ir/optimize/CodeRewriter.java
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/test/java/com/android/tools/r8/workaround/FilledNewArrayFromSubtypeWithMissingInterfaceWorkaroundTest.java
ap...@google.com
Project: r8
Branch: 4.0
commit 684c429d5cec188ef3df3a466cb098ec9837e1e7
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 12:55:09 2023
Avoid conflating register sets at move-exception
In-resolution moves to a move-exception instruction cannot be inserted before the move-exception instruction.
Previously, we worked around this by adding the in-resolution moves to a move-exception instruction as in-resolution moves to the goto instruction that is always after the move-exception instruction (since catch handlers are split blocks).
The in-resolution moves to the move-exception instruction must be inserted before any of the in-resolution moves to the goto instruction, however. By conflating the two in-resolution move sets, the subsequent parallel move scheduling may incorrectly reorder two moves.
Example: Consider that the in-resolution moves for the move-exception instruction is the set { move r11, r3 } and the in-resolution moves for the goto instruction is the set { move r1, r11 }.
The instructions must be laid out in sequence as:
move r11, r3
move r1, r11
When the two sets are conflated as { move r11, r3; move r1, r11 }, parallel move scheduling will instead layout the moves as follows, which may lead to arbitrary errors:
move r1, r11
move r11, r3
Fix: Instead of conflating the two in-resolution move sets, this CL simply inserts the in-resolution moves for the move-exception instruction immediately after the move-exception instruction.
Bug:
Change-Id: I3975902ce63fb1f03914441c7c7357c839ff8a74
M src/main/java/com/android/tools/r8/ir/regalloc/LinearScanRegisterAllocator.java
M src/main/java/com/android/tools/r8/ir/regalloc/SpillMoveSet.java
https://r8-review.googlesource.com/82330
Branch: 4.0
commit 684c429d5cec188ef3df3a466cb098ec9837e1e7
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 12:55:09 2023
Avoid conflating register sets at move-exception
In-resolution moves to a move-exception instruction cannot be inserted before the move-exception instruction.
Previously, we worked around this by adding the in-resolution moves to a move-exception instruction as in-resolution moves to the goto instruction that is always after the move-exception instruction (since catch handlers are split blocks).
The in-resolution moves to the move-exception instruction must be inserted before any of the in-resolution moves to the goto instruction, however. By conflating the two in-resolution move sets, the subsequent parallel move scheduling may incorrectly reorder two moves.
Example: Consider that the in-resolution moves for the move-exception instruction is the set { move r11, r3 } and the in-resolution moves for the goto instruction is the set { move r1, r11 }.
The instructions must be laid out in sequence as:
move r11, r3
move r1, r11
When the two sets are conflated as { move r11, r3; move r1, r11 }, parallel move scheduling will instead layout the moves as follows, which may lead to arbitrary errors:
move r1, r11
move r11, r3
Fix: Instead of conflating the two in-resolution move sets, this CL simply inserts the in-resolution moves for the move-exception instruction immediately after the move-exception instruction.
Bug:
Change-Id: I3975902ce63fb1f03914441c7c7357c839ff8a74
M src/main/java/com/android/tools/r8/ir/regalloc/LinearScanRegisterAllocator.java
M src/main/java/com/android/tools/r8/ir/regalloc/SpillMoveSet.java
ap...@google.com
Project: r8
Branch: 4.0
commit c9bd88348443b3b3571568215179f04e0db8264f
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 12:56:50 2023
Version 4.0.65
Bug:
Change-Id: I2030aa0f72a124ded924a6c39287351d0f2cf1a7
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/82331
Branch: 4.0
commit c9bd88348443b3b3571568215179f04e0db8264f
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 12:56:50 2023
Version 4.0.65
Bug:
Change-Id: I2030aa0f72a124ded924a6c39287351d0f2cf1a7
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com
Project: r8
Branch: 8.0
commit c2fadd146f0a752ee81a06c7129ac9667884fdea
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 12:54:38 2023
Avoid conflating register sets at move-exception
In-resolution moves to a move-exception instruction cannot be inserted before the move-exception instruction.
Previously, we worked around this by adding the in-resolution moves to a move-exception instruction as in-resolution moves to the goto instruction that is always after the move-exception instruction (since catch handlers are split blocks).
The in-resolution moves to the move-exception instruction must be inserted before any of the in-resolution moves to the goto instruction, however. By conflating the two in-resolution move sets, the subsequent parallel move scheduling may incorrectly reorder two moves.
Example: Consider that the in-resolution moves for the move-exception instruction is the set { move r11, r3 } and the in-resolution moves for the goto instruction is the set { move r1, r11 }.
The instructions must be laid out in sequence as:
move r11, r3
move r1, r11
When the two sets are conflated as { move r11, r3; move r1, r11 }, parallel move scheduling will instead layout the moves as follows, which may lead to arbitrary errors:
move r1, r11
move r11, r3
Fix: Instead of conflating the two in-resolution move sets, this CL simply inserts the in-resolution moves for the move-exception instruction immediately after the move-exception instruction.
Bug:
Change-Id: I3975902ce63fb1f03914441c7c7357c839ff8a74
M src/main/java/com/android/tools/r8/ir/regalloc/LinearScanRegisterAllocator.java
M src/main/java/com/android/tools/r8/ir/regalloc/SpillMoveSet.java
https://r8-review.googlesource.com/82342
Branch: 8.0
commit c2fadd146f0a752ee81a06c7129ac9667884fdea
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 12:54:38 2023
Avoid conflating register sets at move-exception
In-resolution moves to a move-exception instruction cannot be inserted before the move-exception instruction.
Previously, we worked around this by adding the in-resolution moves to a move-exception instruction as in-resolution moves to the goto instruction that is always after the move-exception instruction (since catch handlers are split blocks).
The in-resolution moves to the move-exception instruction must be inserted before any of the in-resolution moves to the goto instruction, however. By conflating the two in-resolution move sets, the subsequent parallel move scheduling may incorrectly reorder two moves.
Example: Consider that the in-resolution moves for the move-exception instruction is the set { move r11, r3 } and the in-resolution moves for the goto instruction is the set { move r1, r11 }.
The instructions must be laid out in sequence as:
move r11, r3
move r1, r11
When the two sets are conflated as { move r11, r3; move r1, r11 }, parallel move scheduling will instead layout the moves as follows, which may lead to arbitrary errors:
move r1, r11
move r11, r3
Fix: Instead of conflating the two in-resolution move sets, this CL simply inserts the in-resolution moves for the move-exception instruction immediately after the move-exception instruction.
Bug:
Change-Id: I3975902ce63fb1f03914441c7c7357c839ff8a74
M src/main/java/com/android/tools/r8/ir/regalloc/LinearScanRegisterAllocator.java
M src/main/java/com/android/tools/r8/ir/regalloc/SpillMoveSet.java
ap...@google.com
Project: r8
Branch: 8.0
commit 2edf53642866e17052a8e05c4b4a39fff0c2da52
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 12:54:48 2023
Version 8.0.60
Bug:
Change-Id: I6aa0d73858b8ee7b314c86dcef6728e7476cc773
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/82345
Branch: 8.0
commit 2edf53642866e17052a8e05c4b4a39fff0c2da52
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 12:54:48 2023
Version 8.0.60
Bug:
Change-Id: I6aa0d73858b8ee7b314c86dcef6728e7476cc773
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com
Project: r8
Branch: 4.0
commit 684c429d5cec188ef3df3a466cb098ec9837e1e7
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 12:55:09 2023
Avoid conflating register sets at move-exception
In-resolution moves to a move-exception instruction cannot be inserted before the move-exception instruction.
Previously, we worked around this by adding the in-resolution moves to a move-exception instruction as in-resolution moves to the goto instruction that is always after the move-exception instruction (since catch handlers are split blocks).
The in-resolution moves to the move-exception instruction must be inserted before any of the in-resolution moves to the goto instruction, however. By conflating the two in-resolution move sets, the subsequent parallel move scheduling may incorrectly reorder two moves.
Example: Consider that the in-resolution moves for the move-exception instruction is the set { move r11, r3 } and the in-resolution moves for the goto instruction is the set { move r1, r11 }.
The instructions must be laid out in sequence as:
move r11, r3
move r1, r11
When the two sets are conflated as { move r11, r3; move r1, r11 }, parallel move scheduling will instead layout the moves as follows, which may lead to arbitrary errors:
move r1, r11
move r11, r3
Fix: Instead of conflating the two in-resolution move sets, this CL simply inserts the in-resolution moves for the move-exception instruction immediately after the move-exception instruction.
Bug:
Change-Id: I3975902ce63fb1f03914441c7c7357c839ff8a74
M src/main/java/com/android/tools/r8/ir/regalloc/LinearScanRegisterAllocator.java
M src/main/java/com/android/tools/r8/ir/regalloc/SpillMoveSet.java
https://r8-review.googlesource.com/82330
Branch: 4.0
commit 684c429d5cec188ef3df3a466cb098ec9837e1e7
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Aug 11 12:55:09 2023
Avoid conflating register sets at move-exception
In-resolution moves to a move-exception instruction cannot be inserted before the move-exception instruction.
Previously, we worked around this by adding the in-resolution moves to a move-exception instruction as in-resolution moves to the goto instruction that is always after the move-exception instruction (since catch handlers are split blocks).
The in-resolution moves to the move-exception instruction must be inserted before any of the in-resolution moves to the goto instruction, however. By conflating the two in-resolution move sets, the subsequent parallel move scheduling may incorrectly reorder two moves.
Example: Consider that the in-resolution moves for the move-exception instruction is the set { move r11, r3 } and the in-resolution moves for the goto instruction is the set { move r1, r11 }.
The instructions must be laid out in sequence as:
move r11, r3
move r1, r11
When the two sets are conflated as { move r11, r3; move r1, r11 }, parallel move scheduling will instead layout the moves as follows, which may lead to arbitrary errors:
move r1, r11
move r11, r3
Fix: Instead of conflating the two in-resolution move sets, this CL simply inserts the in-resolution moves for the move-exception instruction immediately after the move-exception instruction.
Bug:
Change-Id: I3975902ce63fb1f03914441c7c7357c839ff8a74
M src/main/java/com/android/tools/r8/ir/regalloc/LinearScanRegisterAllocator.java
M src/main/java/com/android/tools/r8/ir/regalloc/SpillMoveSet.java
ap...@google.com
Project: r8
Branch: main
commit 4818724dc6821648d5b52d8db3453fe2a7471dc4
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Sun Aug 13 08:19:53 2023
Update FilledNewArray test expectations
Bug:
Change-Id: Ic9e62aa64cf8fef177d558bad745a6d474fb0fda
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/TestParameters.java
M src/test/java/com/android/tools/r8/rewrite/arrays/FilledArrayDataRemoveCheckCastTest.java
M src/test/java/com/android/tools/r8/rewrite/arrays/SimplifyArrayConstructionTest.java
https://r8-review.googlesource.com/82365
Branch: main
commit 4818724dc6821648d5b52d8db3453fe2a7471dc4
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Sun Aug 13 08:19:53 2023
Update FilledNewArray test expectations
Bug:
Change-Id: Ic9e62aa64cf8fef177d558bad745a6d474fb0fda
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/TestParameters.java
M src/test/java/com/android/tools/r8/rewrite/arrays/FilledArrayDataRemoveCheckCastTest.java
M src/test/java/com/android/tools/r8/rewrite/arrays/SimplifyArrayConstructionTest.java
ap...@google.com
Project: r8
Branch: 8.2
commit 329bb7c1dab09933316bafedc05ffddb95111b19
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Sun Aug 13 13:52:23 2023
Update FilledNewArray test expectations
Bug:
Change-Id: Ic9e62aa64cf8fef177d558bad745a6d474fb0fda
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/TestParameters.java
M src/test/java/com/android/tools/r8/rewrite/arrays/FilledArrayDataRemoveCheckCastTest.java
M src/test/java/com/android/tools/r8/rewrite/arrays/SimplifyArrayConstructionTest.java
https://r8-review.googlesource.com/82400
Branch: 8.2
commit 329bb7c1dab09933316bafedc05ffddb95111b19
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Sun Aug 13 13:52:23 2023
Update FilledNewArray test expectations
Bug:
Change-Id: Ic9e62aa64cf8fef177d558bad745a6d474fb0fda
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/TestParameters.java
M src/test/java/com/android/tools/r8/rewrite/arrays/FilledArrayDataRemoveCheckCastTest.java
M src/test/java/com/android/tools/r8/rewrite/arrays/SimplifyArrayConstructionTest.java
ap...@google.com
Project: r8
Branch: 8.2
commit a0efa73ffad29cbb7f1bc289e0091dfcc86422d3
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Sun Aug 13 13:52:43 2023
Version 8.2.23
Bug:
Change-Id: Ia9d86f84a5fa4820d7afd7fbe0bba4ea7e097567
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/82401
Branch: 8.2
commit a0efa73ffad29cbb7f1bc289e0091dfcc86422d3
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Sun Aug 13 13:52:43 2023
Version 8.2.23
Bug:
Change-Id: Ia9d86f84a5fa4820d7afd7fbe0bba4ea7e097567
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com
Project: r8
Branch: 8.1
commit 86dcafc9f0fc6ef2ee7e4d1c93b3c1f17e4b3292
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Sun Aug 13 14:07:20 2023
Update FilledNewArray test expectations
Bug:
Change-Id: Ic9e62aa64cf8fef177d558bad745a6d474fb0fda
M src/main/java/com/android/tools/r8/ir/optimize/CodeRewriter.java
M src/test/java/com/android/tools/r8/TestParameters.java
M src/test/java/com/android/tools/r8/rewrite/arrays/FilledArrayDataRemoveCheckCastTest.java
M src/test/java/com/android/tools/r8/rewrite/arrays/SimplifyArrayConstructionTest.java
https://r8-review.googlesource.com/82366
Branch: 8.1
commit 86dcafc9f0fc6ef2ee7e4d1c93b3c1f17e4b3292
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Sun Aug 13 14:07:20 2023
Update FilledNewArray test expectations
Bug:
Change-Id: Ic9e62aa64cf8fef177d558bad745a6d474fb0fda
M src/main/java/com/android/tools/r8/ir/optimize/CodeRewriter.java
M src/test/java/com/android/tools/r8/TestParameters.java
M src/test/java/com/android/tools/r8/rewrite/arrays/FilledArrayDataRemoveCheckCastTest.java
M src/test/java/com/android/tools/r8/rewrite/arrays/SimplifyArrayConstructionTest.java
ap...@google.com
Project: r8
Branch: 8.2
commit 329bb7c1dab09933316bafedc05ffddb95111b19
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Sun Aug 13 13:52:23 2023
Update FilledNewArray test expectations
Bug:
Change-Id: Ic9e62aa64cf8fef177d558bad745a6d474fb0fda
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/TestParameters.java
M src/test/java/com/android/tools/r8/rewrite/arrays/FilledArrayDataRemoveCheckCastTest.java
M src/test/java/com/android/tools/r8/rewrite/arrays/SimplifyArrayConstructionTest.java
https://r8-review.googlesource.com/82400
Branch: 8.2
commit 329bb7c1dab09933316bafedc05ffddb95111b19
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Sun Aug 13 13:52:23 2023
Update FilledNewArray test expectations
Bug:
Change-Id: Ic9e62aa64cf8fef177d558bad745a6d474fb0fda
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/TestParameters.java
M src/test/java/com/android/tools/r8/rewrite/arrays/FilledArrayDataRemoveCheckCastTest.java
M src/test/java/com/android/tools/r8/rewrite/arrays/SimplifyArrayConstructionTest.java
ch...@google.com
This should now be fixed in R8 4.0.66, 8.0.61, 8.1.63 and 8.2.23.
The verification error reported in
Additionally, I cherry-picked fixes to avoid another verification error with R8 8.1.63 and 8.2.23. This was caused by R8 8.1 and 8.2 starting to use the fillednewarray instruction in more cases, which triggered a bug in ART.
It would be great if you could confirm if your issue is resolved with the latest version.
an...@airbnb.com
Sorry for late reply, was out on PTO, but I just also verified the fix with the original issue we had. Thank you!
Description
DESCRIBE THE ISSUE IN DETAIL:
Our app started crashing today out of the blue without any code change (or tooling version upgrades) to the code in question:
I saw several of those fixed in the past months so we updated to latest version of R8 (4.0.64) but we are still seeing it.
We are working around this right now by just keeping the class in question but I think this is a bug in R8.
I included the broken .aab and .apk files and also an input dump and shared it with "the usual" people. Happy to share it with others if required, or provide more information.
IMPORTANT: Please readhttps://developer.android.com/studio/report-bugs.html carefully and supply
all required information.
Studio Build: Not relevant Version of Gradle Plugin: 7.4.2 Version of Kotlin: 1.8.21 Version of Gradle: 7.6 Version of Java: openjdk 17.0.8 2023-07-18 LTS OS: Linux