Status Update
Comments
rk...@google.com <rk...@google.com>
rk...@google.com <rk...@google.com> #2
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
rk...@google.com <rk...@google.com>
ra...@google.com <ra...@google.com> #3
cm...@gmail.com <cm...@gmail.com> #4
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
cm...@gmail.com <cm...@gmail.com> #6
I tried on the Emulator "Pixel2 API 31" and it was not working. I enabled the mic settings and powered down the emulator. When I start up the emulator again, the mic settings are all set to disabled.
Do I have to manually update the emulator or recreate the emulator?
rk...@google.com <rk...@google.com> #7
Could you please confirm your emulator build ends with -10591065
? If not, you want to manually update it (download sdk-repo-PLATFORM-emulator-10591065.zip
, e.g. sdk-repo-windows-emulator-10591065.zip
). If you are on MacOS, you want to run xattr -d com.apple.quarantine FILENAME
on the downloaded file before unpacking it.
cm...@gmail.com <cm...@gmail.com> #8
Where is this emulator build number, try to locate it but failed. Only place is in the AVD settings, and the value shows: SE1A.211212.001.B1
As the emulator update, where is the place to download the image zip files. My system running OS is Ubuntu 22.04. Other ASD info as follow:
Build: AI-221.6008.13.2211.9619390, 202302170051,
AI-221.6008.13.2211.9619390, JRE 11.0.15+0-b2043.56-8887301x64 JetBrains s.r.o., OS Linux(amd64) v6.2.0-26-generic, screens 3840.0x2160.0, 2560.0x1600.0
AS: Electric Eel | 2022.1.1 Patch 2 Kotlin plugin: 221-1.8.0-release-for-android-studio-AS5591.52 Android Gradle Plugin: 4.2.2 Gradle: 6.9 Gradle JDK: version 11.0.15 NDK: from module: 20.0.5594570, from local.properties: (not specified), latest from SDK: 22.1.7171670 CMake: from local.properties: (not specified), latest from SDK: 3.18.1-g262b901, from PATH: 3.22.1
rk...@google.com <rk...@google.com> #9
Where is this emulator build number
Click the "..." (three dots on the emulator panel), then "Help", then "About".
As the emulator update, where is the place to download the image zip files.
cm...@gmail.com <cm...@gmail.com> #10
Thanks for the info.
Yes, my current emulator is 32.1.12-9751036, after updated the emulator version, the mic settings persistent saving is working now.
Also the mic is also working for API-33 when enabled.
By the way, any reason why I did not get a notification to update the emulator. I believe it was so in the past. Did I accidentally disabled the auto update option.
Thanks for the help.
rk...@google.com <rk...@google.com> #11
By the way, any reason why I did not get a notification to update the emulator.
I am not sure, as the SDK Manager is a different component. Yes, 32.x.x is somewhat old.
Description